From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: MaDhAt2r <madhat2r@dukefoo.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Add support for sqsh sql src blocks
Date: Mon, 28 Nov 2016 23:12:19 +0100 [thread overview]
Message-ID: <87a8cjfe4c.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vavdkmes.fsf@ArchNemesis.i-did-not-set--mail-host-address--so-tickle-me> (madhat2r@dukefoo.com's message of "Thu, 24 Nov 2016 08:00:43 -0600")
Hello,
MaDhAt2r <madhat2r@dukefoo.com> writes:
> ob-sql-el: Add support for `sqsh' as an SQL engine
Thank you for the patch. Some comments follow.
> - (`mssql "SET NOCOUNT ON
> + ((or `mssql `sqsh ) "SET NOCOUNT ON
There is a spurious white space above.
> - (org-babel-expand-body:sql body params)))
> + (org-babel-expand-body:sql body params)
> + ;; sqsh requires `go' inserted at EOF
> + (if (equal (intern engine) `sqsh)
> + "\ngo"
> + "")
> + ))
;; sqsh requires "go" inserted at EOF.
also, do not leave dangling parenthesis at the end of the expression
above.
> + (cond
> + ((equal (intern engine) 'sqsh)
> + (org-table-import out-file '(4))
> + )
> + (t
> + (org-table-import out-file '(16))
> + )
> + )
See above about parenthesis.
Eventually, could you write a proper commit message, e.g.
* lisp/ob-sql.el (org-babel-sql-dbstring-sqsh): New function
(....): Added ....
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-11-28 22:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 14:00 Add support for sqsh sql src blocks MaDhAt2r
2016-11-28 22:12 ` Nicolas Goaziou [this message]
2016-11-30 1:07 ` [Patch v2] " MaDhAt2r
2016-12-03 8:08 ` Nicolas Goaziou
2016-12-03 15:38 ` MaDhAt2r
2016-12-03 21:06 ` Nicolas Goaziou
2016-12-03 21:31 ` MaDhAt2r
2016-12-05 21:47 ` Nicolas Goaziou
2016-12-04 13:01 ` Sebastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8cjfe4c.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=madhat2r@dukefoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.