From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24870: 26.0.50; parse-partial-sexp ignores comment-end Date: Mon, 23 Jan 2017 19:30:23 -0500 Message-ID: <87a8ahuwo0.fsf@users.sourceforge.net> References: <87h967cj0f.fsf@users.sourceforge.net> <87eg1bcg0y.fsf@users.sourceforge.net> <20161214215834.GB3881@acm.fritz.box> <20161215164458.GA2437@acm.fritz.box> <8737hldce8.fsf@users.sourceforge.net> <20161229111428.GA12532@acm.fritz.box> <87eg0q89ky.fsf@users.sourceforge.net> <87mvevzp8q.fsf@users.sourceforge.net> <20170123201232.GB4397@acm> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485217818 31291 195.159.176.226 (24 Jan 2017 00:30:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 24 Jan 2017 00:30:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24870@debbugs.gnu.org, Matt Armstrong To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 24 01:30:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVozx-0007Ht-0T for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Jan 2017 01:30:09 +0100 Original-Received: from localhost ([::1]:45407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVp02-0001g0-4O for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Jan 2017 19:30:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVozw-0001eE-Gh for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 19:30:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVozr-0006nD-KO for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 19:30:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41342) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cVozr-0006mx-HC for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 19:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cVozq-0000Oy-Rm for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 19:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jan 2017 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24870-submit@debbugs.gnu.org id=B24870.14852177651470 (code B ref 24870); Tue, 24 Jan 2017 00:30:02 +0000 Original-Received: (at 24870) by debbugs.gnu.org; 24 Jan 2017 00:29:25 +0000 Original-Received: from localhost ([127.0.0.1]:39541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVozE-0000Nd-Sg for submit@debbugs.gnu.org; Mon, 23 Jan 2017 19:29:25 -0500 Original-Received: from mail-it0-f67.google.com ([209.85.214.67]:34766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVozD-0000NH-9X; Mon, 23 Jan 2017 19:29:24 -0500 Original-Received: by mail-it0-f67.google.com with SMTP id o185so12174176itb.1; Mon, 23 Jan 2017 16:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iz6VYnqMuCf7hZ2bQxumuESYzZW/L5/wWjeT/Yb3WVw=; b=SLIeKDFs1wYhStAIQgqBxoqv2zD4nspiPo8ag8rTV/RBDYTXm5WjYJuIyao3rDkynY 1cJwSHbbaID80deLO23pc1EEgG5lPHMgrEuv88MVMtVbohYt6pp2Hk9l3hVnHIWap1hg aAngWSCg7S7gr98bXefztXECXWUqSgXga5MCI37OcNyghEtXf6Ye1Blhj6HdFixIkGpP h2UtfNnOQoh+KIETF6n+rooJm9MIHPycygW7Dsnb8okouQJh9+oLhI6djZXnAjTyMrhr DR/Upz63/Lyy+NFBne/ALL1mQ4hdKRVpT6PAZD4m9ZID7czgjJIeXYqa2uJW3+ZuKycM lzog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=iz6VYnqMuCf7hZ2bQxumuESYzZW/L5/wWjeT/Yb3WVw=; b=icoIppBIjm5Agu3ONowWYLj1HmRDsERFWT8gWwf/wuJRoXXwZfjOevcpVyMyYcz8h6 Kg7kVqE06E40J2IVOg+735iDBauMRSLgQJGTdF3xeTXT1oMFvPQ7/TWlCg5RemNeF6HP NtSGkRprTa6VHZ3fOOuDWQ7M/8dQS7rWWs/otTrmKzZPwgtfGFLuZ2pZ892i01l3+0cc k8Zi5i6Hxc1wLMSStXKLOcPcjHjmppc1ayW0bEFD1FVY4y4viR/idZx+tBj7Lmjk2VHT fpyrgDLx/hJIzMiH0E12oZ8JAuMQpB8L0oX9/UPuV0P6t12PEm4yZ0gHhIxxFIzCqPR1 Z6jQ== X-Gm-Message-State: AIkVDXIYMu1bPlqe5KcGevG1Dr5KoLOpoG9EUREd4k8Vpsd6aCp235mVNBuzwT3cW0BD1g== X-Received: by 10.36.77.10 with SMTP id l10mr16810759itb.59.1485217757562; Mon, 23 Jan 2017 16:29:17 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 197sm7365631ita.14.2017.01.23.16.29.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jan 2017 16:29:16 -0800 (PST) In-Reply-To: <20170123201232.GB4397@acm> (Alan Mackenzie's message of "Mon, 23 Jan 2017 20:12:32 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128347 Archived-At: tags 24870 fixed close 24870 quit Alan Mackenzie writes: > > On Thu, Jan 12, 2017 at 21:07:49 -0500, npostavs@users.sourceforge.net wrote: >> npostavs@users.sourceforge.net writes: > >> > Alan Mackenzie writes: > >> >> (ii) In `parse-partial-sexp-continue-over-comment-marker', variable aftC >> >> is the position in the middle of the comment closer "*/". I don't think >> >> you are testing in any way that element 10 (nil, or the syntax of the >> >> position just before the end point when that position might be the first >> >> character of a two-character construct, i.e. an escape or first char of a >> >> double-char comment delimiter) is correct. > >> > My idea was that its effect would be tested by using pps-preC as >> > OLDSTATE, which avoids having to encode the specifics in the test. I >> > added another clause which uses pps-aftC to cover parsing from the >> > middle of a comment closer as well as opener. > > > I've just had another fairly intensive look at the patches, and I > agree. Thanks for the review. > > I think it's time to commit these. What do you say? Yep, pushed to master [1: 201dfe3]. 1: 2017-01-23 19:28:30 -0500 201dfe311868932d10da146808fcdd681948ba53 Fix comment detection on open parens