all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: npostavs@users.sourceforge.net
Cc: 25505@debbugs.gnu.org
Subject: bug#25505: 24.5; doc of `define-minor-mode': incorrect for :keymap
Date: Wed, 15 Feb 2017 15:49:14 +0100	[thread overview]
Message-ID: <87a89n33x1.fsf@drachen> (raw)
In-Reply-To: <8737flmxr3.fsf@users.sourceforge.net> (npostavs's message of "Fri, 10 Feb 2017 18:28:32 -0500")

npostavs@users.sourceforge.net writes:

> The doc says "variable name" as opposed to "expression", I think it's
> clear that expression will be evaluated, and something which is not an
> expression will not be evaluated.  I guess we could add "it should be
> an unquoted variable name..."

I agree with Drew that the paragraph about the KEYMAP arg could be
improved.  Currently we have

| Optional KEYMAP is the default keymap bound to the mode keymap.  If
| non-nil, it should be a variable name (whose value is a keymap), or
| ...

It's not clear that this is about specifying the _name_ of a keymap (a
symbol), in contrast to specifying a keymap (value).

I also agree that the doc could make clearer if and when the arguments
are evaluated.


Michael.





  parent reply	other threads:[~2017-02-15 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 18:24 bug#25505: 24.5; doc of `define-minor-mode': incorrect for :keymap Drew Adams
2017-01-23 17:12 ` Drew Adams
2017-02-10 23:28 ` npostavs
2017-02-10 23:43   ` Drew Adams
2017-02-15 14:49   ` Michael Heerdegen [this message]
2017-02-15 16:55     ` Noam Postavsky
2021-09-25 16:12   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a89n33x1.fsf@drachen \
    --to=michael_heerdegen@web.de \
    --cc=25505@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.