From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars Date: Wed, 22 Feb 2017 09:23:16 -0800 Message-ID: <87a89edtrv.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1487786357 25194 195.159.176.226 (22 Feb 2017 17:59:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Feb 2017 17:59:17 +0000 (UTC) To: 25839@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 22 18:59:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgbC3-0005nJ-OL for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Feb 2017 18:59:12 +0100 Original-Received: from localhost ([::1]:54466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgbC6-0007AV-9q for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Feb 2017 12:59:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgae5-0000U2-Lb for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:24:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgae2-0003gj-Hx for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:24:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53267) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cgae2-0003gV-FM for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cgae2-000498-9H for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2017 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.148778421815906 (code B ref -1); Wed, 22 Feb 2017 17:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Feb 2017 17:23:38 +0000 Original-Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgadc-00048R-Jl for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgadb-00048F-Gr for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgadV-0003SA-DF for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:30 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42329) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgadV-0003S2-9H for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgadU-0007mU-42 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:23:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgadR-0003Qt-08 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:23:28 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:59965) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgadQ-0003P3-QQ for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:23:24 -0500 Original-Received: from localhost (71-212-6-137.tukw.qwest.net [71.212.6.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 43B3BBE5F7 for ; Wed, 22 Feb 2017 17:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1487784197; bh=X4smDS/Zp7DrDr7SlGwzatPvhmLMi71ET2SJ7o/6PRU=; h=From:To:Subject:Date:From; b=fHdq/m8jEjdkfK74tt7rXWGNymiqw5hnLw0WaEEQSmDl9EG1n3LNXa293ZjwD1nuE 8Bn8j7AUfp/riVNA6ZqY6j69KNL9Alx8ewPBvLC6xEvbkmFQ+KpfB1aoMYnrifmmTg QxPgaOFK5QiGAmOrWiZVIHZqhT2GO982cq2tFDZU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129655 Archived-At: --=-=-= Content-Type: text/plain The current implementation of gnus-registry-article-marks-to-chars errors out because it tries to use mapconcat on a list of characters. I've attached a patch that extracts the characters first and then uses the mapconcat with char-to-string. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-char-to-string-in-gnus-registry-article-marks-to.patch >From b05ff977a349688fc006fac399b0f29516f0ecef Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Wed, 22 Feb 2017 09:21:53 -0800 Subject: [PATCH] Use char-to-string in gnus-registry-article-marks-to-chars * lisp/gnus/gnus-registry.el (gnus-registry-article-marks-to-chars): Otherwise it was running a list of characters through mapconcat, which produced an error. --- lisp/gnus/gnus-registry.el | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el index f728b19111..8229927176 100644 --- a/lisp/gnus/gnus-registry.el +++ b/lisp/gnus/gnus-registry.el @@ -967,13 +967,15 @@ 'gnus-registry-user-format-function-M (defun gnus-registry-article-marks-to-chars (headers) "Show the marks for an article by the :char property." (let* ((id (mail-header-message-id headers)) - (marks (when id (gnus-registry-get-id-key id 'mark)))) - (mapconcat (lambda (mark) - (plist-get - (cdr-safe - (assoc mark gnus-registry-marks)) - :char)) - marks ""))) + (marks (when id (gnus-registry-get-id-key id 'mark))) + (mark-chars + (delq nil (mapcar (lambda (mark) + (plist-get + (cdr-safe + (assoc mark gnus-registry-marks)) + :char)) + marks)))) + (mapconcat #'char-to-string mark-chars ""))) ;; use like this: ;; (defalias 'gnus-user-format-function-M 'gnus-registry-article-marks-to-names) -- 2.11.1 --=-=-= Content-Type: text/plain In GNU Emacs 26.0.50 (build 28, x86_64-unknown-linux-gnu, GTK+ Version 3.22.8) of 2017-02-19 built on clem Repository revision: c8d14cfc6c2d19077d137c7e917fbb4f104de222 --=-=-=--