From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28570: Added patch, pinging Date: Mon, 16 Oct 2017 20:49:56 -0400 Message-ID: <87a80qha2z.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508201482 5929 195.159.176.226 (17 Oct 2017 00:51:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Oct 2017 00:51:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 28570@debbugs.gnu.org, dgutov@yandex.ru To: =?UTF-8?Q?G=C3=B6ktu=C4=9F?= Kayaalp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 17 02:51:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4G69-0008T2-9c for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Oct 2017 02:51:09 +0200 Original-Received: from localhost ([::1]:35935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4G6G-0002jM-A0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 20:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4G65-0002h8-Re for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 20:51:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4G61-0001of-V1 for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 20:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4G61-0001oZ-RZ for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 20:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e4G61-0006kY-LR for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 20:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Oct 2017 00:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28570 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28570-submit@debbugs.gnu.org id=B28570.150820141325885 (code B ref 28570); Tue, 17 Oct 2017 00:51:01 +0000 Original-Received: (at 28570) by debbugs.gnu.org; 17 Oct 2017 00:50:13 +0000 Original-Received: from localhost ([127.0.0.1]:44499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4G5E-0006jQ-2s for submit@debbugs.gnu.org; Mon, 16 Oct 2017 20:50:12 -0400 Original-Received: from mail-io0-f182.google.com ([209.85.223.182]:43987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4G5C-0006jD-8L for 28570@debbugs.gnu.org; Mon, 16 Oct 2017 20:50:10 -0400 Original-Received: by mail-io0-f182.google.com with SMTP id 134so447359ioo.0 for <28570@debbugs.gnu.org>; Mon, 16 Oct 2017 17:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mK1+qAIPGWMs9KX3nYEUzB7w39zYoVgnKNf8i9IQpd8=; b=NMmYGb4bz6dxR6qAyFpK0ACX4m/yUl5u4rQ56RRg0I2U8+nHMiRIRHuDhTU2m2x9rn EcJiumTeUvT2DmEv3nMdH880L+GOYiTNBl81+L6ikobj7ooSAzbNXnlHMzFFrBRtQs1v KMV1Ux9ovTfmH/CcYdBl9BgSzyp3KkZ8AqWEVi5NJcgyNl2LFKsZ3+WDrZVzGfetG+tv fj1CmDYc781JIF4E+smZOgUn0MW4izs+gM/JcXX55gx7iwJ4yenlkDHOPhFHeKKa7uMh irwpFTfX4tPTiLKwYTRLoZKg1d+W92uhivzTr0TH/L/DxUIRaCEWajqkKprcdlKcxOIz 5gOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=mK1+qAIPGWMs9KX3nYEUzB7w39zYoVgnKNf8i9IQpd8=; b=rIgY100I9wclF9DzeU1e0MuIKIwBdBOfslxxwcgbnsK128Gai7HJr5Q2B3f8/zwjoi Yr7iGM4eQ307UW0Jp318BNzTYkwu/bgqc7C04W1s0h6EKVB4wwFyQDcqGGykbDlLDmIL q7VMd44SCHVQAnf2M4W6jVjzUrPD807MJCmMuVkCVI5WyFw+9JoYPl6OChHLhnb6ucuF tRaxl7Gp2CgzrprqSd0/mPYpgqL/x4tp0oFKiMTwzxrs0e28et2vTz703g8J/ByVMZCH TftglwC9+U5HPEAVTdAh4D9NKY6zVcnuqSAfwBGcGG+pn1jz/9mNnqW0M5Vmyul9zIdI Bfcg== X-Gm-Message-State: AMCzsaWwsgEHzQRA7pmsLcYuUUWQt2GBuRgB0CQnFSUhzMGtSf56LFLf ntO1TVBmK7y1DJf/i39TFLZR9Q== X-Google-Smtp-Source: ABhQp+RcSwmPzH46wHblVolcA/VS54eTeR+pYnRoN/M3aqEurL8WCpA+xUzvKMcNmeZfGmohUVnldg== X-Received: by 10.107.152.67 with SMTP id a64mr418422ioe.168.1508201404383; Mon, 16 Oct 2017 17:50:04 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y73sm4664046itc.8.2017.10.16.17.50.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Oct 2017 17:50:03 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?G=C3=B6ktu=C4=9F?= Kayaalp"'s message of "Mon, 16 Oct 2017 18:51:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138565 Archived-At: G=C3=B6ktu=C4=9F Kayaalp writes: > Hi, I have added a patch to this bug as was requested. I'm just pinging > in case it went unnoticed as it seems to me that nothing has happened to > it in the past six days. Anyways I guess I actually had to attach the > patch file from git-format-patch, so I'm doing that in this message. > Please excuse me for this mess, I'm quite ignorant of git, but I'll have > learned my lesson for my next patch. Both came through fine. I do generally recommend sending as attachment because it seems to work more reliably across different email clients. Also, when sending a series of patches, it avoids getting them out of order. > Add an implementation of this for vc-rcs that does nothing to suppress > the message the default function adds to the vc-dir buffer (Bug#28570). Hmm, maybe reword as Add a do-nothing implementation for vc-rcs to suppress the message which the default function adds to the vc-dir buffer (Bug#28570). Your version kind of reads to me as saying that the added vc-rcs implementation doesn't suppress the message. > +(defun vc-rcs-dir-extra-headers (&rest ignore)) You should use `_' (or `_ignore') instead of `ignore' to suppress this compiler warning: In toplevel form: ../../lisp/vc/vc-rcs.el:180:1:Warning: Unused lexical argument =E2=80=98ign= ore=E2=80=99