bug#28570: Added patch, pinging

[Noam Postavsky <npostavs@users.sourceforge.net>]

Göktuğ Kayaalp <self@gkayaalp.com> writes:

> Hi, I have added a patch to this bug as was requested.  I'm just pinging
> in case it went unnoticed as it seems to me that nothing has happened to
> it in the past six days.  Anyways I guess I actually had to attach the
> patch file from git-format-patch, so I'm doing that in this message.
> Please excuse me for this mess, I'm quite ignorant of git, but I'll have
> learned my lesson for my next patch.

Both came through fine.  I do generally recommend sending as attachment
because it seems to work more reliably across different email clients.
Also, when sending a series of patches, it avoids getting them out of
order.

> Add an implementation of this for vc-rcs that does nothing to suppress
> the message the default function adds to the vc-dir buffer (Bug#28570).

Hmm, maybe reword as

    Add a do-nothing implementation for vc-rcs to suppress the message which
    the default function adds to the vc-dir buffer (Bug#28570).

Your version kind of reads to me as saying that the added vc-rcs
implementation doesn't suppress the message.

> +(defun vc-rcs-dir-extra-headers (&rest ignore))

You should use `_' (or `_ignore') instead of `ignore' to suppress this
compiler warning:

In toplevel form:
../../lisp/vc/vc-rcs.el:180:1:Warning: Unused lexical argument ‘ignore’