From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Date: Tue, 24 Oct 2017 19:33:30 -0400 Message-ID: <87a80gce9h.fsf@users.sourceforge.net> References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> <83o9pbjh8b.fsf@gnu.org> <87o9ozcfl0.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508888061 6927 195.159.176.226 (24 Oct 2017 23:34:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 24 Oct 2017 23:34:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 28797@debbugs.gnu.org, kaushal.modi@gmail.com To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 25 01:34:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e78hy-0008WT-Sd for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 01:34:07 +0200 Original-Received: from localhost ([::1]:45925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e78i6-0008KI-2V for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Oct 2017 19:34:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e78hx-0008GD-QK for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 19:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e78hu-0002aB-LH for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 19:34:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e78hu-0002Zz-Ic for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 19:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e78hu-0001AQ-9R for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 19:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2017 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.15088880214449 (code B ref 28797); Tue, 24 Oct 2017 23:34:02 +0000 Original-Received: (at 28797) by debbugs.gnu.org; 24 Oct 2017 23:33:41 +0000 Original-Received: from localhost ([127.0.0.1]:60411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e78hY-00019h-Tr for submit@debbugs.gnu.org; Tue, 24 Oct 2017 19:33:41 -0400 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:52648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e78hX-00019Q-H5 for 28797@debbugs.gnu.org; Tue, 24 Oct 2017 19:33:39 -0400 Original-Received: by mail-it0-f42.google.com with SMTP id j140so12079482itj.1 for <28797@debbugs.gnu.org>; Tue, 24 Oct 2017 16:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=a7R/fD4yq8iqbWF90C/z1NERRaHULSEQtzRaK1I/g/o=; b=ZhnWISqA6xnksRTPfrLtQ9HKnVgvyfqvpkIA8FCrdU3097d6b9RrJ799VyEl1eT7cr sOuHwmO+jng6gz5rqgyyQgqagUSeyt6EHrfjM1ebKTPS8p4tMfPCJ/pxJfGhCBRKNQZp 1MlHZ5vMNC/eR7fTtl1asoiSQy+xaqRauu1FFtbWp6XDfTfKmQkM0bKh5PuDD+9qO2tW sMdLhGkq93RWjR4O97vGi2cNCeXyI68/eTFBt06EqfgeDkuAzbuOjQj7Q0WcCObv4ocw 5Q1sOc8vVjqkS0YtKoVNbWPRpIzBvbMSiiltMkpB2oj+7d4G9CnwZEouW8Z7dwLfAj9b 34TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=a7R/fD4yq8iqbWF90C/z1NERRaHULSEQtzRaK1I/g/o=; b=I5YI6z3Ibgisol7g/ZaJ7+3YaoepcBczfHt4jQEKDSIo/1BICDVaQrA0r0ynTsOxqz EVbQ1laPvKR05A/qiMUe8IkobrdcBjsyuZSXxoXulzsPkyIF8UqUhIjdRctw7X0uO0yc l/lN03+Os+rulKe3Mw9CRqO0UKSdgTxK5u2PTgNnVwJ0tbcr9IQYbynixw9XR3RcedP3 rVi9L1PP/zJ1Me8rFbWIRnVGqazjj8D6/oaB4aCKF1PFFxnzBQTshpLHIeP2ZiB/rNQt JblcZybvqI5Duh65OtVQj3P2hr8qYf/hQQQNUPAsgD34q45sg9yTJQM51FhhRk+pX4LG X9xQ== X-Gm-Message-State: AMCzsaXaX25ReRXGH7M4jLJzS/pwvOsAa7QgjyNaiXUvIQkEB6nrVAT9 UoKpwL/F4deSjvxE8CcpdRc= X-Google-Smtp-Source: ABhQp+SbrWpvXjdqf3b9V+VKrkRHQ8e5ZWMvJ7N78THxv92zE6GLfPuH6d100fd8im8RUJwfuFeYNQ== X-Received: by 10.36.77.131 with SMTP id l125mr301430itb.7.1508888013919; Tue, 24 Oct 2017 16:33:33 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b66sm669797itb.28.2017.10.24.16.33.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 16:33:32 -0700 (PDT) In-Reply-To: (Tino Calancha's message of "Wed, 25 Oct 2017 00:41:23 +0900 (JST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138939 Archived-At: Tino Calancha writes: > On Sun, 22 Oct 2017, Noam Postavsky wrote: > >>The "no" case of dired-test-bug27940 is failing now. I guess if >>RECURSIVE is set to nil, we should not try to delete non-empty >>directories, or maybe just catch the error if it happens? Just to clarify, I wrote this before I had figured the Bug#11218 issue. We *are* currently catching the error, but due to Bug#11218 catching with condition-case-unless-debug (as opposed to condition-case) doesn't work inside ert tests. > * lisp/dired (dired-delete-file): If the dir is non-empty and > RECURSIVE is nil then return 'skip and don't try to delete > the dir (Bug#28797). I think it's okay to do this if we think it would be better for users to avoid triggering the error messages altogether. But it should be a separate decision from whether we want condition-case or condition-case-unless-debug.