From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#19391: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion Date: Sun, 26 Nov 2017 21:42:45 -0500 Message-ID: <87a7z8o316.fsf@users.sourceforge.net> References: <1424775586.11596.7@mail.samertm.com> <83a8zuqdle.fsf@gnu.org> <1425455434.1450.1@mail.samertm.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511750594 28151 195.159.176.226 (27 Nov 2017 02:43:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 27 Nov 2017 02:43:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 19391@debbugs.gnu.org To: Samer Masterson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 27 03:43:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ9Ny-0006ju-I7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Nov 2017 03:43:06 +0100 Original-Received: from localhost ([::1]:58879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJ9O5-0001Ix-O1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Nov 2017 21:43:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJ9Nx-0001GG-Hz for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 21:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJ9Nu-0003QO-9v for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 21:43:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51162) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJ9Nu-0003QK-5T for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 21:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJ9Nt-0007PX-SE for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 21:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2017 02:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19391-submit@debbugs.gnu.org id=B19391.151175057428475 (code B ref 19391); Mon, 27 Nov 2017 02:43:01 +0000 Original-Received: (at 19391) by debbugs.gnu.org; 27 Nov 2017 02:42:54 +0000 Original-Received: from localhost ([127.0.0.1]:59843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ9Nm-0007P8-EA for submit@debbugs.gnu.org; Sun, 26 Nov 2017 21:42:54 -0500 Original-Received: from mail-io0-f169.google.com ([209.85.223.169]:45565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ9Nl-0007Oo-54; Sun, 26 Nov 2017 21:42:53 -0500 Original-Received: by mail-io0-f169.google.com with SMTP id z74so34717957iof.12; Sun, 26 Nov 2017 18:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SLg+QzeOfFtW30YPJARrjr1qaDtMKjKNIIn8RsGOsnw=; b=a6EVda13/C1VLelzPU4YsAgFwBUnhuqr21V64eSqGwiUshSEst7ooLDc8jPmEMHJ6i gPMCf7msAzD4TqW8bAbPoOdx8nZJIt/s/b6LV0moX3DrTOPiDUUBsmqww4wnELz/7qUe kQAmnZC4Axk1ulKeaRHZ3oxSlkwjUJBpEpyV+AVSPpcs8hA/ZvPSDc2v40uwjk4TJIv9 SQ7XEk+VN7wvfYIqwGX1Hc5TjfrueYD+0n15f5EpN8fR0ELemLPkjfBTOiSa0yaAkibg xZ6XFd+KV5qDm6SeWXpPXFgAiO8R4ph6fFdnSNL8YOqD+WpGdCre5eWLCPorJch0AG3E 1aZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=SLg+QzeOfFtW30YPJARrjr1qaDtMKjKNIIn8RsGOsnw=; b=q6DGZsUq5TXOMO+vu95Vgjgy9WlJlxw2ZEfkS5hNb2cZEmSlcZb0LkQhkOHjlGfYxs fTBVZBj40wdErsMib0DVvWGDz2QPCNjPXsuD0XpjnGhnE2H+Gv/zuBPXak4Ik5Qg2I1b GZNQCdL3C9LAZ+dzLkS2xII8/gMWpj8MrBN+Fp+9G7I7OcT3kJWac6XyiFHl4O5ehcPT uAWMZbycm+0RrqCwGaG7pe06bHtMawOyC7Ut7Yff9H2iOtGO9AYn0lSI7fN8HWHJoMSg IcJ0W3DOLnWnx7DLrtRNP+3BlwI7tWqiG8//u14++n/hvIQF+vxqWyj0W7lmsEIqhF0O LRgQ== X-Gm-Message-State: AJaThX55Lwp73YKWotToM3yaqySqieTSUAPiAaBQQmOIV9HyPYQ1IFPv 6M40hjW/X3iSefqEPHCWOQMQ9w== X-Google-Smtp-Source: AGs4zMYeJjBWy6+3PtnewGb4kgh9lt4X35Qu1oR3GZoTOKzxKMmoaIBsc1T6WuYI40dghW2b6T1JKw== X-Received: by 10.107.183.77 with SMTP id h74mr42775807iof.0.1511750567257; Sun, 26 Nov 2017 18:42:47 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i133sm9375009itf.1.2017.11.26.18.42.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Nov 2017 18:42:46 -0800 (PST) In-Reply-To: <1425455434.1450.1@mail.samertm.com> (Samer Masterson's message of "Tue, 03 Mar 2015 23:50:34 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140435 Archived-At: tags 19391 fixed close 19391 25.1 quit Samer Masterson writes: > - The syntax for the shorthand should be distinct from any other > lisp objects, so that we don't have to put out fires when people try > to do things that are valid but overlap with the shorthand (e.g. this > bug was caused by eshell's external shell feature redirecting to a > symbol.) Something like # would work. > - The shorthand should be processed as a buffer (similar to how # > is processed). That means the shorthand won't > require extra code anywhere except for the reader. > - The shorthand should be on by default, and probably shouldn't have > an option to disable it. The reason for this is that the shorthand > would be universally beneficial and backwards compatible, and making > it controlled by an option is inviting bugs when we shouldn't be. Something along these lines was pushed for Emacs 25. [1: e37da5a4a8]: 2015-05-17 14:28:51 -0700 eshell: Introduce new buffer syntax https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e37da5a4a8055826f0fc1051083495a828509672>