From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#18743: 25.0.50; Clang 3.0 fails to compile src/fns.c, GCC 4.8 cannot dump emacs Date: Sun, 03 Dec 2017 14:24:22 -0500 Message-ID: <87a7yzipi1.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1512329110 4806 195.159.176.226 (3 Dec 2017 19:25:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Dec 2017 19:25:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Alan Third , 18743@debbugs.gnu.org To: Peter Dyballa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 03 20:25:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLZsv-00011I-Cj for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Dec 2017 20:25:05 +0100 Original-Received: from localhost ([::1]:39940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLZt2-00024d-Mf for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Dec 2017 14:25:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLZsw-00024W-7J for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 14:25:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLZst-0002J4-0w for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 14:25:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLZss-0002Ik-Sh for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 14:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLZss-0006IB-J5 for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 14:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Dec 2017 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18743 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: unreproducible Original-Received: via spool by 18743-submit@debbugs.gnu.org id=B18743.151232907224146 (code B ref 18743); Sun, 03 Dec 2017 19:25:02 +0000 Original-Received: (at 18743) by debbugs.gnu.org; 3 Dec 2017 19:24:32 +0000 Original-Received: from localhost ([127.0.0.1]:43793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLZsO-0006HM-Hz for submit@debbugs.gnu.org; Sun, 03 Dec 2017 14:24:32 -0500 Original-Received: from mail-it0-f45.google.com ([209.85.214.45]:45885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLZsM-0006H4-V1 for 18743@debbugs.gnu.org; Sun, 03 Dec 2017 14:24:31 -0500 Original-Received: by mail-it0-f45.google.com with SMTP id z6so7895311iti.4 for <18743@debbugs.gnu.org>; Sun, 03 Dec 2017 11:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sBSDfxNHVhdq7AV2gV4fvfoPh0YCylq3LnA5ECYnXlw=; b=XuN1PxHrxUx07tkvMMVaJzUrToEzVAEPDcmA4fim0aC3+b6NTTBN6xl+kIrqWTWcha zhN3kriBqpoeTTUlYoP8brOOZyGtmwABSs4LtMgdTQmq0BmnrpVNTdsSPZhk7SAaM9o8 YIbGLzfKjfJz49t1rFhB3+aPi3+CN+PLB3ncQ/AR/VQ2kCjwSzKDMrh6O1KINHLMBu+i MG98Fjum+WOE+nHdie9lOcsudMDQvZRJkwOFopjNs5FtvI6MotXMJlIfMaxrspOgIQdU Y4b2OUoQg0GpcRGuGnBOECV7WyWdEr4H3Jl/aO/WxFGeyHvoKpK8j/cbn+ihQmCZfjzi un3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=sBSDfxNHVhdq7AV2gV4fvfoPh0YCylq3LnA5ECYnXlw=; b=kkBz+RY6v4uyZNGX1+SjzCGwblk3RkB8jt8CLTml1BeUiPE/pSFMcrfrU/vmqeEcyV Altly4OxwnUhgiuoLqSiPcxuQNBGGWp/GGt27pZAlYEUwC06/YPXYLbQoiYKsABOGe0/ SGqIXgd+6fNZgH9UMYJsmhItqxQKyal6Htna2ZcJaYx57SX4wx9SomZvVgaqDTYfW1Vz GRSeroHRVoym6ZbV1bYXWuS8zwl0r25CX8W2YTxps9Wn/PamNgShW0uQnCJJKeNWpF09 y72htZhTbKtwPeOz5BC7YWNUQswbwlFZe4GyyA+04wFUbN6+dYtlBXllVhePApsrAky8 3fzA== X-Gm-Message-State: AJaThX6eraTo/mj8B39x1eAlmKuat1g/jdvmQpf26EjDgh8Hd8TbnfVZ Px7V0nUNFNVP5U93LZP+WNYPsw== X-Google-Smtp-Source: AGs4zMb4V6jKvDqS2pCqY2oXDFONjGIyVJ7D5WbrE6xfywLhp6NeahWYoC5aI38QoQNZM8nEPwrEew== X-Received: by 10.107.129.139 with SMTP id l11mr20844715ioi.143.1512329065143; Sun, 03 Dec 2017 11:24:25 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 140sm1413267itx.3.2017.12.03.11.24.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Dec 2017 11:24:23 -0800 (PST) In-Reply-To: (Peter Dyballa's message of "Wed, 25 May 2016 23:40:46 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140650 Archived-At: --=-=-= Content-Type: text/plain Peter Dyballa writes: > With Clang 3.0 I still get this error: > Other versions of Clang build GNU Emacs. So only 3.0 fails with this, while both earlier and later versions succeed? > fns.c:1929:16: error: read-only variable is not assignable > *dest++ = *a++; > ~^ > I guess the following should fix it, though I'm not sure if it's worth doing. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-increment-array-Bug-18743.patch Content-Description: patch >From b7e08e341c19e1d2c8b1105ea1d94979577dbd02 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Tue, 28 Nov 2017 20:54:00 -0500 Subject: [PATCH] Don't increment array (Bug#18743) * src/fns.c (merge_vectors): Use integer indexes instead of incrementing pointers. --- src/fns.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/fns.c b/src/fns.c index 9db9bea9f7..e4ff0924b9 100644 --- a/src/fns.c +++ b/src/fns.c @@ -1812,27 +1812,26 @@ merge_vectors (Lisp_Object pred, Lisp_Object dest[VLA_ELEMS (alen + blen)]) { eassume (0 < alen && 0 < blen); - Lisp_Object const *alim = a + alen; - Lisp_Object const *blim = b + blen; + ptrdiff_t ai = 0, bi = 0, di = 0; while (true) { - if (inorder (pred, a[0], b[0])) + if (inorder (pred, a[ai], b[bi])) { - *dest++ = *a++; - if (a == alim) + dest[di++] = a[ai++]; + if (ai >= alen) { if (dest != b) - memcpy (dest, b, (blim - b) * sizeof *dest); + memcpy (&dest[di], &b[bi], (blen - bi) * sizeof *dest); return; } } else { - *dest++ = *b++; - if (b == blim) + dest[di++] = b[bi++]; + if (bi >= blen) { - memcpy (dest, a, (alim - a) * sizeof *dest); + memcpy (&dest[di], &a[ai], (alen - ai) * sizeof *dest); return; } } -- 2.11.0 --=-=-=--