From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.bugs Subject: bug#30610: clarify linux-mode usage from Lisp Date: Sat, 03 Mar 2018 18:17:19 -0500 Message-ID: <87a7vobvgg.fsf@gmail.com> References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1520122282 29381 195.159.176.226 (4 Mar 2018 00:11:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Mar 2018 00:11:22 +0000 (UTC) User-Agent: mu4e 1.0-alpha3; emacs 26.0.91 Cc: 30610@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 04 01:11:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esHFF-0006zQ-SW for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Mar 2018 01:11:18 +0100 Original-Received: from localhost ([::1]:42787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esHHI-0005vi-Fm for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Mar 2018 19:13:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esHH0-0005oq-Hh for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 19:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esHGx-0008UQ-CX for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 19:13:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35427) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esHGx-0008TO-7O for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 19:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1esGPh-00005y-Ko for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 18:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Mar 2018 23:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30610 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30610-submit@debbugs.gnu.org id=B30610.1520119058336 (code B ref 30610); Sat, 03 Mar 2018 23:18:01 +0000 Original-Received: (at 30610) by debbugs.gnu.org; 3 Mar 2018 23:17:38 +0000 Original-Received: from localhost ([127.0.0.1]:43310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGPJ-00005M-QR for submit@debbugs.gnu.org; Sat, 03 Mar 2018 18:17:37 -0500 Original-Received: from mail-qk0-f182.google.com ([209.85.220.182]:45175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGPI-000056-AA for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 18:17:36 -0500 Original-Received: by mail-qk0-f182.google.com with SMTP id g2so16459850qkd.12 for <30610@debbugs.gnu.org>; Sat, 03 Mar 2018 15:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=mTmy8ewBRAX1u2prOcf7IP21reIZW9qL0jOtdDCPV2Q=; b=nTqtraWBV3DXwaCdcsJfaffRUD8upEzqcCAQ2uEKeofCFYBPRiqHjmUxgSivuEJql5 rHHct5qCPF+Mn6hqrnpoHBvpbR+4MkisxCwZz3JhKsf7f+p8qvF0UNncbwKw155m7qyx 9E158F33QLvHrMYT7KIB8ZdPKwfFQv2G1RM458tzOUZl9jg4AN1P2gO0DbkoUAyD7tcg tUIhTZQPrf30Ui/GuBSNa43UYkKYsNLdUxKfF9x5p7uTT65TL1SvAhEI/dtTf6T89Z9O H0jR4d5HEKIqwVKngEVgkgtdZDnCvlWhpsMInZn6cCAw9TF53oALqLdkX+9jAcZYBNqO qS+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=mTmy8ewBRAX1u2prOcf7IP21reIZW9qL0jOtdDCPV2Q=; b=cg5GlqUSI6lRLFuH+4pgWUVQ6EyrNSUkt16fB322FI1Lcz7GcerqL+lTYp1U74y7+t X2l1jQISSc/nEEYwI4Zqu/NNJ378PvVO6bsgu2HLprre0yyxnBcf0nKh5JPvdNbFfRHp ATpWP0t2Z2lCk1pLagLTjmn1Mr7yG9Ju/90B49KtRUHGdg4G7Vx+7BuGT7dLWCVnn9EM n1llz+KT2MjWMxDGkZ7LQ9Bj80ZkB/6e7bKD3I+xeVBNUUgdoCl0zDpqJmp1sg82xCqN S+Okf/MA6qsDK9oFszpOC9BuvRMpxxzSz4ZdLyts0Pbntsj7WkemxybJOYAjMkOSUQPl Go/Q== X-Gm-Message-State: AElRT7E6nb21cPtMwxWQYfqaw3Hfv1M3aBV3+SzhQfVmQ/zSo2Ar86dI FdNgnzVFKxGoF8PrPMDnVbM5Mbcs X-Google-Smtp-Source: AG47ELs2oyLvMOwjpz2RGUN8AGxRa0zpHHq9Ygf9wIvV3pCvS5c8JeIOek5Ap20ZOF2G605dZLWjRw== X-Received: by 10.55.217.28 with SMTP id u28mr15067484qki.148.1520119050559; Sat, 03 Mar 2018 15:17:30 -0800 (PST) Original-Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id s39sm7063674qth.10.2018.03.03.15.17.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Mar 2018 15:17:29 -0800 (PST) In-reply-to: <87bmg740qd.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143883 Archived-At: --=-=-= Content-Type: text/plain Noam Postavsky writes: > John Shahid writes: > >> Worth noting that this is my first patch to Emacs. Let me know if >> there's anything wrong with the way I submitted the patch. > > The patch looks fine, but the commit message should have a ChangeLog > style entry as described in CONTRIBUTE under "Commit messages". fixed and attached a new patch > And if you haven't assigned copyright for Emacs, it should also have a > 'Copyright-paperwork-exempt: yes' line. Note that we only accept up > to 15 lines worth of unassigned patches. If you want to start the > assignment process, fill out the form at [1] and send it to > fsf-records@gnu.org (they will reply with further instructions). i filled out and sent the paper work. i also exempt this commit from the paperwork since it is a very minor change. thanks, -js --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-linum.el-clarify-linum-mode-handling-of-ARG.patch >From 113b30d8739dc8d1673a53d06b201e6c9ea1a54a Mon Sep 17 00:00:00 2001 From: John Shahid Date: Sun, 25 Feb 2018 14:33:00 -0500 Subject: [PATCH] lisp/linum.el: clarify linum-mode handling of `ARG' Copyright-paperwork-exempt: yes --- lisp/linum.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/linum.el b/lisp/linum.el index 9df0c5d023..fa66d62bfe 100644 --- a/lisp/linum.el +++ b/lisp/linum.el @@ -76,8 +76,12 @@ linum-delay (define-minor-mode linum-mode "Toggle display of line numbers in the left margin (Linum mode). With a prefix argument ARG, enable Linum mode if ARG is positive, -and disable it otherwise. If called from Lisp, enable the mode -if ARG is omitted or nil. +and disable it otherwise. + +When called from Lisp, toggles the mode if the argument is +`toggle', disables the mode if the argument is a non-positive +integer, and enables the mode otherwise (including if the +argument is omitted or nil or a positive integer). Linum mode is a buffer-local minor mode." :lighter "" ; for desktop.el -- 2.16.2 --=-=-=--