From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31097: 27.0.50; Interprogram paste is destructively modified Date: Thu, 12 Apr 2018 19:35:43 -0400 Message-ID: <87a7u8kng0.fsf@gmail.com> References: <87fu45loow.fsf@tcd.ie> <87bmetloaq.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523576052 32152 195.159.176.226 (12 Apr 2018 23:34:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Apr 2018 23:34:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 31097@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 13 01:34:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6ljD-0008Eq-Eh for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Apr 2018 01:34:07 +0200 Original-Received: from localhost ([::1]:53251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6llI-0006OL-Ed for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2018 19:36:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6ll9-0006Na-NY for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 19:36:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6ll4-0004rt-Q4 for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 19:36:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40899) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f6ll4-0004rT-L3 for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 19:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f6ll4-00029o-DG for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 19:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2018 23:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31097 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31097-submit@debbugs.gnu.org id=B31097.15235761548276 (code B ref 31097); Thu, 12 Apr 2018 23:36:02 +0000 Original-Received: (at 31097) by debbugs.gnu.org; 12 Apr 2018 23:35:54 +0000 Original-Received: from localhost ([127.0.0.1]:48796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6lkv-00029L-T9 for submit@debbugs.gnu.org; Thu, 12 Apr 2018 19:35:54 -0400 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:54149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6lks-000291-Tg; Thu, 12 Apr 2018 19:35:51 -0400 Original-Received: by mail-it0-f43.google.com with SMTP id m134-v6so1066028itb.3; Thu, 12 Apr 2018 16:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=19iHGBO4Nqabju6Hv971mbwOtR9F3DN3ogZELo8NctU=; b=nXUkK8UurFF5Q9zqqliVPJSE/uf0oW0eyXVLfbWFJc2XXFwTnfZoaYqohzNGT5zQCe tToIyL6Uwua/UHBQ35sUsik+AkbGjgHzvGydJz/FoWcO6VoYqHiKJZgjw/L2q1hpJHws yDcNc2iZ5fwMXsHeMnOsip0AMDfGHTCc7ASV7F9vRzYPWSha8l4O9V//zUPbDZtgW1Py p6P/yu9wFlK8P18QcfNrKaPlhOtHEHlYRVG1uflyv8YYZ5QSP62F8K/A6btKT+zhnR1N GEkI8eu3OVNY53Fcx2cCaeT53FjHo/V8bpPO/TjLs6UICv2I7VqzmHCUZ4IQQWhRqvKT darg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=19iHGBO4Nqabju6Hv971mbwOtR9F3DN3ogZELo8NctU=; b=qGHxU/Rz7DcVj7waOqbeIjBjf1eWaSfOUNS0oPFuQAnNWN2haQlLCQsbwl2amUK+a3 r1AaHH0RYJMgeL26w+vO8STzMcXP8nPXXMrbZ5F8M3EBKxe9WffYV5J+7vkLoYlJYZ6q OVkwjInxczMzG/Y7m9OthJAqqpfmsJ6Rb2jwG6RvP/NgPvfpWofsKOW4SDeweqXVxa6U 7a4GRb4rRAjepdJiMO6ke0laFZya4SxInHZFs3oxImyAEDgl6aJdYP8+Na0LGNmt7Acf R0al1U3mtn27DMS7i5B55BLtJ5BRdDrSDuwT0AD3saa7pWDEbpClsNFZVKB/v0UYyDPD 7JWQ== X-Gm-Message-State: ALQs6tBlJQ3k3KMKds4xUiIZqHF15bePd+0gNDoxWVczZMkDJUa10SdM WbPePF0Y+Lm4N74K1rKMA3yjag== X-Google-Smtp-Source: AIpwx49u0DUN+4OIrkegs6fsV6JyvPmRfvUhlI9Rnce0JbtQ3xybrAD2KxF27xB08CcXqa0fMtcvQw== X-Received: by 2002:a24:ac61:: with SMTP id m33-v6mr3103828iti.116.1523576145310; Thu, 12 Apr 2018 16:35:45 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n201-v6sm335762itn.7.2018.04.12.16.35.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Apr 2018 16:35:44 -0700 (PDT) In-Reply-To: <87bmetloaq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 08 Apr 2018 16:18:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145222 Archived-At: severity 31097 minor quit "Basil L. Contovounesios" writes: > * simple.el (kill-new, current-kill): Non-destructively reverse list > returned by interprogram-paste-function. (bug#31097) Seems reasonable. Perhaps add some comments in case someone tries to "optimize" it later? > If optional arg DO-NOT-MOVE is non-nil, then don't actually > move the yanking point; just return the Nth kill forward." > - > (let ((interprogram-paste (and (= n 0) > - (let ((ARGth-kill-element > + (let ((nth-kill-element > (nthcdr (mod (- n (length kill-ring-yank-pointer)) > (length kill-ring)) > kill-ring))) > (unless do-not-move > - (setq kill-ring-yank-pointer ARGth-kill-element) > + (setq kill-ring-yank-pointer nth-kill-element) > (when (and yank-pop-change-selection > (> n 0) > interprogram-cut-function) > - (funcall interprogram-cut-function (car ARGth-kill-element)))) > - (car ARGth-kill-element))))) > + (funcall interprogram-cut-function (car nth-kill-element)))) > + (car nth-kill-element))))) I don't think these hunks are needed.