From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#31148: 26.1; require w32 errors Date: Fri, 13 Apr 2018 12:58:46 -0500 Message-ID: <87a7u7ng2x.fsf@gmail.com> References: <87d0z3w46w.fsf@gmail.com> <83bmen5eca.fsf@gnu.org> <87bmenw30w.fsf@gmail.com> <83a7u758da.fsf@gnu.org> <87bmenngou.fsf@gmail.com> <834lkf56vm.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523642231 17804 195.159.176.226 (13 Apr 2018 17:57:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Apr 2018 17:57:11 +0000 (UTC) User-Agent: mu4e 1.0; emacs 26.1 Cc: 31148@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 13 19:57:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f72wd-0004Vu-Di for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Apr 2018 19:57:07 +0200 Original-Received: from localhost ([::1]:42592 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f72yj-0006XG-0Z for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Apr 2018 13:59:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f72yY-0006UP-Ot for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2018 13:59:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f72yU-00069P-TI for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2018 13:59:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42978) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f72yU-00069J-PC for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2018 13:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f72yU-0008PG-II for bug-gnu-emacs@gnu.org; Fri, 13 Apr 2018 13:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Apr 2018 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31148-submit@debbugs.gnu.org id=B31148.152364233532300 (code B ref 31148); Fri, 13 Apr 2018 17:59:02 +0000 Original-Received: (at 31148) by debbugs.gnu.org; 13 Apr 2018 17:58:55 +0000 Original-Received: from localhost ([127.0.0.1]:50875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f72yM-0008Os-NA for submit@debbugs.gnu.org; Fri, 13 Apr 2018 13:58:54 -0400 Original-Received: from mail-oi0-f41.google.com ([209.85.218.41]:45871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f72yL-0008Og-Bf for 31148@debbugs.gnu.org; Fri, 13 Apr 2018 13:58:53 -0400 Original-Received: by mail-oi0-f41.google.com with SMTP id 71-v6so9114734oie.12 for <31148@debbugs.gnu.org>; Fri, 13 Apr 2018 10:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=bCccCJUrnaL/L87TkobVKi4G3O6N1tLppL230gNtAsE=; b=FDmhTVivKtETptd14YaYoMF8utiGAjyn/axUTLUyKSB58WF55wZ+Gj8Hq3i0bjXsgy ET9Qz45Ue4VabuVpyQMXeeoBb4hUEDyezVvJjfQNfZsD3x5otCmuudayjJylnwqPcuTC 49ELCwcBeo0ErZgv+zFANT2XbKI7Tuy2RqmyafFw9icPquQhnV9D8U/4Y0rlQAkNYY2R lPouh2XxbBtbct6IAJAQX4qGLcO6jKWSXg3lBpsGEGU6Nc2jqIzhdeSBSlYnYCtwxFbs MocPZJP3N8/MWIMnxQuw5KVc1pUN3DO6ZtDZJOxECB7I98zN5ZDCeqFLxBimhGkSqUUY VrmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=bCccCJUrnaL/L87TkobVKi4G3O6N1tLppL230gNtAsE=; b=e8eibpbZ6zkrxdOf4L85MtyPeS8B9vHYW3WD33D7pdgpHaCUpn2M0XslBhJs8dfFSd Uwt4I+c14FCYKpEH+gocpzqnBYJ+6kRebz8pCuCfk+ggYJycoHifj6RyJnK7oBrJ9X7I DL1jgoWaey8dR1uBeMgcOAbvtizcQ1MY7o6XtrdqT7q5Bi6zRNdit/Sl3sTw5DloQB3u 4oSlyE9M22oo7GqumMqnDXOBFVvptH3kcZw/xkcWJm5t9IS9Ai+e1cjwuRlUlkTqfF6V LDVnotaoVGkW5wnbEPItty+x1fwUyEAW9/ihryp94IA++NucER0XUIS8NYs3zZAIy9M+ FB1w== X-Gm-Message-State: ALQs6tBrt/FFJ9VMq6+8Te2E+A2o2fwqnZ0eONHBnemovNIm+nQcST5J fK+svkRy7HTuStWfBzd60NwZlZ4a X-Google-Smtp-Source: AIpwx49IVVyPmfunvocyKG2RgBCv2mH97YGlGCTafPDlQq7jEgSubUxE/+flrYRPS9TKbwgUM5DQOg== X-Received: by 2002:aca:3946:: with SMTP id g67-v6mr8544087oia.292.1523642327390; Fri, 13 Apr 2018 10:58:47 -0700 (PDT) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id 19-v6sm3643359oiq.23.2018.04.13.10.58.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Apr 2018 10:58:46 -0700 (PDT) In-reply-to: <834lkf56vm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145298 Archived-At: On Fri 13 Apr 2018 at 12:54, Eli Zaretskii wrote: >> From: Alex Branham >> Cc: 31148@debbugs.gnu.org >> Date: Fri, 13 Apr 2018 12:45:37 -0500 >> >> (if (not (w32-shell-dos-semantics)) >> (add-hook 'comint-output-filter-functions 'ess-bugs-exit-notify-sh)) >> >> Which causes errors on non-windows machines unless you wrap the call to >> w32-shell-dos-semantics in (and (fboundp ...)), which looks weird to me: >> >> (if (not (and >> (fboundp 'w32-shell-dos-semantics) >> (w32-shell-dos-semantics))) >> (add-hook 'comint-output-filter-functions 'ess-bugs-exit-notify-sh)) >> >> They also have code like: >> >> (if (ess-microsoft-p) >> (w32-short-file-name ...)) >> >> which causes byte compiler warnings about w32 being undefined. I guess >> the best/only way to get rid of these is to (declare-function ... ), >> right? > > Yes, declare-function should solve at least some of those. > > As for the rest, I suggest to define a variable/function (seems like > ess-microsoft-p is already doing that) to tell you whether you are on > MS-Windows, e.g., by looking at system-type, and then condition all > the calls to w32-specific functions on that variable/function. Thanks, will do. I guess this bug report can be closed (can I do that myself?) Thanks again, Alex