From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers Date: Sun, 15 Jul 2018 08:33:36 +0300 Message-ID: <87a7qtnjv3.fsf_-_@tcd.ie> References: <87efnan46u.fsf@linux-m68k.org> <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> <601m6cc6.fsf@lifelogs.com> <83o9fefnv9.fsf@gnu.org> <83in5lg4ol.fsf@gnu.org> <83efg9fxnj.fsf@gnu.org> <838t6hfa4h.fsf@gnu.org> <87h8l4lt9q.fsf@gmail.com> <831sc8fttu.fsf@gnu.org> <87sh4lwwg6.fsf_-_@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1531632707 32356 195.159.176.226 (15 Jul 2018 05:31:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 15 Jul 2018 05:31:47 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: cpitclaudel@gmail.com, tzz@lifelogs.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca, larsi@gnus.org, Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 15 07:31:42 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1feZdF-0008J7-GJ for ged-emacs-devel@m.gmane.org; Sun, 15 Jul 2018 07:31:41 +0200 Original-Received: from localhost ([::1]:44371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1feZfL-0000aF-VN for ged-emacs-devel@m.gmane.org; Sun, 15 Jul 2018 01:33:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1feZfF-0000a8-HM for emacs-devel@gnu.org; Sun, 15 Jul 2018 01:33:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1feZfC-0007SQ-EK for emacs-devel@gnu.org; Sun, 15 Jul 2018 01:33:45 -0400 Original-Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:37625) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1feZfC-0007Rn-4F for emacs-devel@gnu.org; Sun, 15 Jul 2018 01:33:42 -0400 Original-Received: by mail-ed1-x541.google.com with SMTP id b10-v6so325679eds.4 for ; Sat, 14 Jul 2018 22:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Dq9Pj9HxJ41fj5oIbV0XWZXK1xhx42IzgQYvpXIf00U=; b=1XrcvK3ZLEYdSmI3qZTxjDr5EsmC8nWiS4xeRpD47EbXGnTyI5sJuEqFLFB6wWeUl7 aL5Ubp8OnC+DOY3KMsEQB6/i+sPLO6d7OPiUSYwUiwtWr7ouar2sWK3TSeoGlGgMNMWv 7hrgzRSMBnTIEvro0xCl840vwsfwFAVGjvn5F0yd8lb3Dst4SjH5VRpKs6MIoGD9Ob2A oCOo3F+Apamfb6fwYhbh7VMgRPBQcHVxWp/R6zSjdIgC6fTAXcxnvRSywUV4fZ2+P9aF EETbKrFeH5SiD4Cyw9LCFDcdfhyWKjX8HHdEdrq6m+IC5SZJfy8jLg5pmLbpIHOP1jOx GmgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Dq9Pj9HxJ41fj5oIbV0XWZXK1xhx42IzgQYvpXIf00U=; b=fLPGP7361ZIY1jfVZ7ceZkqxMTTbCIP5j58nLg7SDIl0TP9XrTDEZjjqyRcpOTcehC jUylol4q8b4o5jv+dBIOElnjQT8Bl853lpLwlqrpmRBw0iy1KZ8yVjB+I9tw32zIqpGg PQ8vhNQaSEBSCCHTToS5db3NlFMLMn6QSH12s/Ty8nKbh0gD7ydr9eJvKtuFog+KvKTd ziaWHufaQ3Bh5MlG06RwkCSrcJNYxl1KHMrLY5udllWeKKr+x7XnNSf0HYp9Of/Er45r mRGWynhsnfgYPVLqhDc9gk2uhZAnvx+xgmUEpUB5zHsPYRKqeNPHQ0Jy89OxlOS6KO9B D8fw== X-Gm-Message-State: AOUpUlFBB5vpp4blhjmyc+llsx8722bFOUienO8v8k8y1rOEYdRNLPhi BtEuYt8s8O1TCY9tFD6LgJ13sA== X-Google-Smtp-Source: AAOMgpfxc03QsgHkFXQ+Cec/gpj+p8LeXnTtmD7kW4aKu4cFBbwiUxhh4IN1yMxPXywreaw/CLXHuA== X-Received: by 2002:a50:d5de:: with SMTP id g30-v6mr12949711edj.307.1531632820059; Sat, 14 Jul 2018 22:33:40 -0700 (PDT) Original-Received: from localhost ([213.233.148.29]) by smtp.gmail.com with ESMTPSA id x40-v6sm19810673ede.23.2018.07.14.22.33.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Jul 2018 22:33:39 -0700 (PDT) In-Reply-To: <87sh4lwwg6.fsf_-_@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1?= =?utf-8?Q?vora=22's?= message of "Sat, 14 Jul 2018 18:36:57 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::541 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227421 Archived-At: Hi Jo=C3=A3o, just a minor question: Jo=C3=A3o T=C3=A1vora writes: > From 867540c9310ee12ca477e744571d93f56f5f888d Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Jo=3DC3=3DA3o=3D20T=3DC3=3DA1vora?=3D > Date: Sat, 14 Jul 2018 18:29:48 +0100 > Subject: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffe= rs > > * lisp/vc/add-log.el (add-log-file-name): Update docstring. > (add-log-use-pseudo-changelog): New defcustom. > (add-log-find-changelog-buffer): New helper. > (add-change-log-entry): Can work with ChangeLog file-less > buffers. Change name of argument FILE-NAME arg to be more > explicit. Explain new meaning of arg in docstring. > (add-log--changelog-buffer-p): New helper. > > * lisp/vc/log-edit.el (log-edit-changelog-entries): Use > add-log-use-pseudo-changelog and add-log-find-changelog-buffer. > --- > lisp/vc/add-log.el | 67 +++++++++++++++++++++++++++++++++++++-------- > lisp/vc/log-edit.el | 6 ++-- > 2 files changed, 59 insertions(+), 14 deletions(-) > > diff --git a/lisp/vc/add-log.el b/lisp/vc/add-log.el > index 4d69aac454..983024327c 100644 > --- a/lisp/vc/add-log.el > +++ b/lisp/vc/add-log.el > @@ -744,6 +744,7 @@ find-change-log > file-name) >=20=20 > (defun add-log-file-name (buffer-file log-file) > + "Compute file-name of BUFFER-FILE as displayed in LOG-FILE." > ;; Never want to add a change log entry for the ChangeLog file itself. > (unless (or (null buffer-file) (string=3D buffer-file log-file)) > (if add-log-file-name-function > @@ -767,15 +768,49 @@ add-log-file-name > (file-name-sans-versions buffer-file) > buffer-file)))) >=20=20 > +(defcustom add-log-use-pseudo-changelog nil > + "If non-nil, don't create ChangeLog files for log entries." > + :type :boolean) > + > +(put 'add-log-use-pseudo-changelog 'safe-local-variable 'booleanp) Any reason to prefer this over adding ":safe 'booleanp" directly to the defcustom? Thanks, --=20 Basil