From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] open bookmark in other frame Date: Wed, 10 Oct 2018 16:35:50 -0500 Message-ID: <87a7nliix5.fsf@red-bean.com> References: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr> <87ftxd8smp.fsf@mbork.pl> Reply-To: Karl Fogel NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539207239 25569 195.159.176.226 (10 Oct 2018 21:33:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 Oct 2018 21:33:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: Pierre-Yves Luyten , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 10 23:33:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAM77-0006Xu-OA for ged-emacs-devel@m.gmane.org; Wed, 10 Oct 2018 23:33:53 +0200 Original-Received: from localhost ([::1]:59249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAM9E-0007QY-9j for ged-emacs-devel@m.gmane.org; Wed, 10 Oct 2018 17:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAM96-0007QQ-GU for emacs-devel@gnu.org; Wed, 10 Oct 2018 17:35:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAM93-0002hP-Br for emacs-devel@gnu.org; Wed, 10 Oct 2018 17:35:56 -0400 Original-Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]:54366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAM93-0002gP-4Q for emacs-devel@gnu.org; Wed, 10 Oct 2018 17:35:53 -0400 Original-Received: by mail-it1-x142.google.com with SMTP id l191-v6so10392968ita.4 for ; Wed, 10 Oct 2018 14:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=grnynDmV90xgLQ+qnqRNHeukpe+e7raoj4MOSjbniSk=; b=vEVB8HoJNmWe2r7k5nUGheW+xTneWckkgrLpxGKlwpYe3zsap55bVT52n6DIGx/1u9 KDNxEvbnCtuD+mD5CrqVWY2vp+LbAd0XP44At60OSvf8Lk/JM7i/oFMv3+PanjO0tlQK PJf9DmN23fBSVWCH/NtMqpN82QAp1StKyKy1Cpp9pZVZw8LRHqVb/n+ZxVghQ8DZlUIO F543fqZ5oxuCEUOA0wXa5N5Q+JpaMoe/WPIxpIjlZdv6wnf6EVvxwoqieSDM0u9hEWu9 Ovk3HNouZLUGaUT9p+krA1yxG85xYxHFvcsXubirGZWuK6hUytrARGP5n/rOxUWhs5FN kGsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:reply-to:date :in-reply-to:message-id:user-agent:mime-version; bh=grnynDmV90xgLQ+qnqRNHeukpe+e7raoj4MOSjbniSk=; b=UmKr0GD6D8JuYqJ6Cm3xVB1oaxyIDkml631j2Lxeh0mB6vzZf3febD3Dgp9F6MZyOe hU3oOxbyVIb30tmMGIhOq2eWraOpHKSTz1m064R6834dFShgYzXCyO1z0EiN4HGzDxIq aGTsH80D3jzpEnQkCF8mqQEQkzLMwwb6oBxSRFfjHFd+pYr3rYcC2WwqvhFZxfNRm95d M9wdOE+BkGzu24xRsPzkXfxL7gT9C0wfQVuTK8NzAykk8GaZPQfdnDnATc1QPKKJHiRB /jMWlGd2HEKjyyqsq8NOtc/cU5ysGPllXJqNHWi1tiBZbE/FtFogselelzzSEf3IwDh2 feUw== X-Gm-Message-State: ABuFfogsUqtZozMPq7y5wnvkp6KiIhdwfoG5Fu2ycx32D0tC8GWfz4zs 3l/rbVO5LnCNjJTL/Z08zqXgAFXI X-Google-Smtp-Source: ACcGV63zx27w3aWT6knHPqCEX49/qTcDYg+S+REyjuaoXVhjt7VlLI1lRsfvDs8FISP2Lid8tNRJAw== X-Received: by 2002:a24:16cb:: with SMTP id a194-v6mr2034313ita.40.1539207352035; Wed, 10 Oct 2018 14:35:52 -0700 (PDT) Original-Received: from kwork (74-92-190-114-Illinois.hfc.comcastbusiness.net. [74.92.190.114]) by smtp.gmail.com with ESMTPSA id e76-v6sm8287956iof.31.2018.10.10.14.35.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Oct 2018 14:35:51 -0700 (PDT) In-Reply-To: <87ftxd8smp.fsf@mbork.pl> (Marcin Borkowski's message of "Wed, 10 Oct 2018 22:16:14 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::142 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230328 Archived-At: Marcin Borkowski writes: >> people sometimes use several frames, so i would like to make opening >> bookmark one shot. Attached patch adds two funcs, >> "bookmark-jump-other-frame" and the equivalent from the bookmarks menu, >> "bookmark-bmenu-other-frame" > >Great idea! > >How about a default keybinding? I also like this patch. (Marcin, I think Pierre-Yves did include a keybinding: "F" in the bookmark-map -- unless you meant something else by "default keybinding"?) Pierre-Yves, have you read the CONTRIBUTE file at the top of the Emacs source tree (in particular the bit at the top, that points to https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html)? While a plain 'git diff' is fine, 'git format-patch ...' might make it easier to preserve attribution in the most git-like manner. However, we'll be able to merge it either way. Also, that way we get your commit message (log message). You can look at the existing commit history for examples of commit messages, and the CONTRIBUTE file has some guidance as well. Best regards, -Karl