From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#33263: 27.0.50; Tidying up Gnus modes Date: Tue, 06 Nov 2018 09:37:59 -0800 Message-ID: <87a7mmw1hk.fsf@ericabrahamsen.net> References: <875zxbipby.fsf@gmail.com> <87o9b3za3p.fsf@ericabrahamsen.net> <8736seibdv.fsf@gmail.com> <877ehs1bgq.fsf@ericabrahamsen.net> <87k1lqw510.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541525998 29005 195.159.176.226 (6 Nov 2018 17:39:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2018 17:39:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 33263@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 06 18:39:53 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK5KP-0007Nc-Lg for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 18:39:49 +0100 Original-Received: from localhost ([::1]:42353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK5MV-0007CL-Vu for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 12:42:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK5Km-0005sK-CB for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 12:40:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK5Ke-00088E-1f for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 12:40:11 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33372) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK5Kb-00082i-RJ for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 12:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gK5Kb-00006P-K8 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 12:40:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <877ehs1bgq.fsf@ericabrahamsen.net> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33263 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1541525996368 (code B ref -1); Tue, 06 Nov 2018 17:40:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Nov 2018 17:39:56 +0000 Original-Received: from localhost ([127.0.0.1]:37630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK5KW-00005s-Hv for submit@debbugs.gnu.org; Tue, 06 Nov 2018 12:39:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK5KS-00005d-Oc for submit@debbugs.gnu.org; Tue, 06 Nov 2018 12:39:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK5K4-000712-5l for submit@debbugs.gnu.org; Tue, 06 Nov 2018 12:39:37 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:56774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK5Jm-0006jD-6G for submit@debbugs.gnu.org; Tue, 06 Nov 2018 12:39:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK5Jh-00053E-O4 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 12:39:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK5JM-00066w-M3 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 12:38:57 -0500 Original-Received: from [195.159.176.226] (port=38937 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK5JK-0005aX-25 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 12:38:42 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1gK5Gh-0002pq-Ap for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 18:35:59 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:7wJeod5bkQFBVeMpsF04Jxo+UM8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152106 Archived-At: Noam Postavsky writes: > On Tue, 6 Nov 2018 at 11:22, Eric Abrahamsen wrote: > >> >>>> +(defvar gnus-browse-mode-map (make-keymap)) >> >>>> >> >>>> (unless gnus-browse-mode-map >> >>>> - (setq gnus-browse-mode-map (make-keymap)) >> >>>> + (defvar gnus-browse-mode-map (make-keymap)) > >> Right, I got that much, I was mostly wondering why the `unless' -- it's >> unlikely these files would be loaded multiple times, and even if they >> were, that wouldn't break anything, would it? > > Without the `unless', if the user had made changes to > gnus-browse-mode-map they would be lost upon reload (as you say, it's > not especially likely to happen, but I guess the original author > wanted to preserve the semantics of the single defvar form). Got it, thanks for the explanation. I'll fix this, and look more closely at the "group" argument to `gnus-summary-mode'. Eric