From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34852: 26.1; seq-intersection ignores nil as element Date: Thu, 14 Mar 2019 17:23:02 +0000 Message-ID: <87a7hxcqvd.fsf@tcd.ie> References: <87zhpxabn3.fsf@tcd.ie> <87va0lmwlg.fsf@web.de> <87va0lctwn.fsf@tcd.ie> <87tvg55s8z.fsf@web.de> <87o96dcrtt.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="239317"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Nicolas Petton , "Miguel V. S. Frasson" , 34852@debbugs.gnu.org, Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 14 18:24:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4U5w-00104K-Pt for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 18:24:40 +0100 Original-Received: from localhost ([127.0.0.1]:42323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4U5v-0000eK-QF for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2019 13:24:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4U5M-0000NF-77 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:24:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4U5L-0006dv-0m for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:24:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58677) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4U5K-0006dc-Ap for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h4U5K-0004XN-21 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2019 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2019 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34852 X-GNU-PR-Package: emacs Original-Received: via spool by 34852-submit@debbugs.gnu.org id=B34852.155258419217382 (code B ref 34852); Thu, 14 Mar 2019 17:24:02 +0000 Original-Received: (at 34852) by debbugs.gnu.org; 14 Mar 2019 17:23:12 +0000 Original-Received: from localhost ([127.0.0.1]:43988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4U4W-0004WI-2i for submit@debbugs.gnu.org; Thu, 14 Mar 2019 13:23:12 -0400 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:43015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4U4T-0004W5-UI for 34852@debbugs.gnu.org; Thu, 14 Mar 2019 13:23:10 -0400 Original-Received: by mail-ed1-f43.google.com with SMTP id m35so5308241ede.10 for <34852@debbugs.gnu.org>; Thu, 14 Mar 2019 10:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LZt/xZIL7ybOG4sxddHsNLDyAxYfuof08B2v18gOf7M=; b=lRS3FmvIjsQndIcfmiXC+5I4ZIepsMXcbbFOt9T+ANv88x2dAFJuBZ1ey8TystRqXJ o4dpmN6khF6ZwoHX15kQ2tHUueS6Y2MlpC1py6tsLjQeSHSXATgJr4hpF/4sstB35Kz6 1lr4u7G2df0QfwtwkKGNhWSKGibOwZR98GQhlZry5QTgJEXhW6hLCDcH2cVJLAY5ELLw NBfochAjNjpNent/QR9dmFdKoV1CSzxFEbTI4Uq/7R46NmNKdaYWm5SkvAQni65iyLcR 0v5tcZqiusXo3Xmt+aZk7XiHjdIIS4uo+ZuTy9wMw9LE+9yTz4w7nhvmtRd+Wfce+5yV Buxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LZt/xZIL7ybOG4sxddHsNLDyAxYfuof08B2v18gOf7M=; b=hj0fQLqSVeAprhcfcWrlmyOsuQTSo6AB2cEgcYMkAEQcujpVbwwt8dzR8FHFwG3UZD xZsTjZs1NfHSAoX55ABzF2B0TvrRBbgflD0Hzt2LzpLmZpa9ss26AiNa9lCgMtoPdfaZ fDm1CB+wPWCqWiXRfU0GVeX3wnpJ60yPnIr9t8RPQ1+aS1IA7rwF9wExV2bgIuxoJ/ga DaMPC8ZFEJWBR0X558ju7uneePNNqKqe26mMK3MSGoZ5H+OjBbrBLFd5u9g5lDBGGx2+ BfOwIV6otOqtDQjGcJxBCvCCggBlB0NJM0VMzDZO75QHVroHzcKm0AxuPV7KrTOZkM8m PyiQ== X-Gm-Message-State: APjAAAWbooX97c88z4ccnrGKY1Flv4ih5X/MYvBcqqdAdX/kqVJrOJaT mJ3CrkSYR+J5iJcVmNxdLUz0Ug== X-Google-Smtp-Source: APXvYqx3L9mkwI2A40ULyjUfQnaIG7avnbaxeCiHyncA7YWcz4LRllGIG8Tgk/C59nY2incqHkJdfw== X-Received: by 2002:a17:906:1b05:: with SMTP id o5mr16438418ejg.30.1552584183988; Thu, 14 Mar 2019 10:23:03 -0700 (PDT) Original-Received: from localhost ([134.226.214.253]) by smtp.gmail.com with ESMTPSA id z9sm1190160ejg.36.2019.03.14.10.23.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 14 Mar 2019 10:23:03 -0700 (PDT) In-Reply-To: <87o96dcrtt.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 14 Mar 2019 17:02:22 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156349 Archived-At: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=bench.el Content-Transfer-Encoding: quoted-printable ;; -*- lexical-binding: t -*- (require 'seq) (defun my-contains-some (sequence elt &optional testfn) (or testfn (setq testfn #'equal)) (seq-some (lambda (e) (funcall testfn elt e)) sequence)) (defun my-contains-posn (sequence elt &optional testfn) (seq-position sequence elt testfn)) (let* ((reps 10000) (needle 50) (haystack (number-sequence 1 needle))) (dolist (fn '(my-contains-posn my-contains-some)) (garbage-collect) (message "%s: %s" fn (benchmark-run reps (funcall fn haystack needle))))) --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Michael Heerdegen writes: > >> "Basil L. Contovounesios" writes: >> >>> My first patch makes an analogous backward-compatible change using the >>> more efficient seq-position in place of seq-some. >> >> Why is it more efficient? The implementations are more or less >> analogue, with the exception that seq-position additionally increments a >> counter. > > Because seq-some involves an additional level of function indirection. > This is confirmed by profiling and the attached mini-benchmark, when run > as follows: > > emacs -batch -f batch-byte-compile bench.el > emacs -script bench.elc Oops, forgot to attach. -- Basil --=-=-=--