From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 23 Mar 2019 12:55:26 -0600 Message-ID: <87a7hl4e01.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <87imw94hi2.fsf@gmail.com> <831s2xpiba.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="81550"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 23 19:56:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7loX-000L8A-Fb for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 19:56:17 +0100 Original-Received: from localhost ([127.0.0.1]:46746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7loW-00018R-DX for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 14:56:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7lno-00018K-4s for emacs-devel@gnu.org; Sat, 23 Mar 2019 14:55:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7lnm-0003gL-CJ for emacs-devel@gnu.org; Sat, 23 Mar 2019 14:55:32 -0400 Original-Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:40293) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7lnk-0003eI-He; Sat, 23 Mar 2019 14:55:30 -0400 Original-Received: by mail-pg1-x52d.google.com with SMTP id u9so3683387pgo.7; Sat, 23 Mar 2019 11:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1MsixbufmmbPQaWiFdvnfnTjwEXi0j1nM7b0jFam714=; b=valJHiM4j2zfjlE7KQlBK0lFPmTZzRQWCAmY/gtHyECSsXRAh6sTplxFAdMYziUesS rSlbZFlx/iDeF4E+IxkwckjHNXTLX7qbl+AdjQLQU2sZa0zfdI1dy2I4r1JDiuKzcmqT uhjBg9/KMmvmbzFC5xtW05MxeIz8nMZIyGE4eUQ7JVJ0BWM8osTXPUOZhwZRqAbGFOyT Qb/Kl5atnQoZ+6uWetZWKpezi8v2HojCmF0bdEvOJBrHOWreMTVBVnUp328kneav/EIU VrXApkuhAFzq+WFpoucmQ2vaxGV8+g3V4dcxvXeMedi36hcCsT3+leeUP3pKxD3Hky0m mreQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1MsixbufmmbPQaWiFdvnfnTjwEXi0j1nM7b0jFam714=; b=RGYciQp5UCyoJgoXUB0p2AKift3Kz2RZqOXSSBDw3i+bd+FHnAdLJahxvdxwuPf28v vYR3ILOAOTTJAUoDDsnGRclJ+oYBNG/erv7LMo4CPD3t+GK47uvrK0Bmo813YWZJCs5F pRyO+x8ME3Zdbj4TvFc2eyhL4eCZ9v9bocvEtj0P9R85m8iCVt/0CUYgy8cSBRt1WaUH SH94CwPeIp+/1qxqxxZ9iI+InGElC4hgmYuFPN4LefZMVyFxrAx6Hy/WD77aueK+gUXu dMQY28S3EA91s8+mohin9QBCo27ScIvJEVd9qpyTVC0LKB9BSAJ+pR8I173T5OXzEZ1g ZzKA== X-Gm-Message-State: APjAAAUDNzZS4FbPYuYOOD/BmHO10zupdZp1yLQ46d4ukKucxN+s5kpl 3Y1hlNelFi9ENY7SZ5jYW8MZ52WH X-Google-Smtp-Source: APXvYqwMAQWbsZVbVdhk616/1alrClsgL3qRsu7eGjRyd3rLtznirNUl1mJ9lWmozGU6PKv9LR32dQ== X-Received: by 2002:a17:902:2ac3:: with SMTP id j61mr16294812plb.112.1553367327224; Sat, 23 Mar 2019 11:55:27 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e380:2255:962f:b96:2aaf:c3d5]) by smtp.gmail.com with ESMTPSA id j4sm16730997pfn.132.2019.03.23.11.55.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Mar 2019 11:55:26 -0700 (PDT) In-Reply-To: <831s2xpiba.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Mar 2019 20:16:41 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234662 Archived-At: Eli Zaretskii writes: >> From: Alex >> Cc: Paul Eggert , emacs-devel@gnu.org >> Date: Sat, 23 Mar 2019 11:39:49 -0600 >> >> > As a rule of thumb that is 99% true, everything in xdisp.c is generic, >> > i.e. independent of the terminal-specific implementation. The >> > terminal-dependent stuff is in xterm.c/xfns.c (for X), >> > w32term.c/w32fns.c (for w32), nsterm.m/nsfns.m (for NS), and term.c >> > (for TTY). >> >> Which the naming scheme should reflect, IMO. This includes the presence >> of x_* procedures in the NS/W32 code that Stefan mentioned. > > But what you propose in the patch stops short of that goal, it just > renames the functions that are explicitly called from xdisp.c. It > doesn't rename x_* functions in files unrelated to X. I'm not sure > this partial renaming is worth the trouble. It can be considered as just a step towards that goal. As I mentioned, I don't see why all the work has to happen at the same time. IMO the RIF x_* and the multiply-defined x_* are separate, even if related, issues; the RIF x_* being much easier to solve (as demonstrated). If you're referring to another class of x_* procedures to be renamed, then those can be done in a later commit. >> P.S. Should x_clear_window_mouse_face instead be renamed to >> clear_window_mouse_face since it doesn't depend on HAVE_WINDOW_SYSTEM >> like the others do? > > It does depend on the window-system, albeit somewhat subtly: it is > only invoked for some terminal types. If it's not invoked for non-GUI Emacs, then the gui_* prefix would indeed be appropriate.