From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#34981: 27.0.50; gnus-group-select-group errors with wrong type argument Date: Sun, 24 Mar 2019 17:20:21 -0700 Message-ID: <87a7hjkdoa.fsf@ericabrahamsen.net> References: <87d0mgastf.fsf@gmail.com> <87muljkf7y.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40125"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34981@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 25 01:21:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8DMd-000AG1-Lr for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Mar 2019 01:21:19 +0100 Original-Received: from localhost ([127.0.0.1]:34249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8DMX-0002WA-8s for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 20:21:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8DMN-0002Vq-FT for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 20:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8DMM-0000to-IV for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 20:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43746) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8DMM-0000sb-1q for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 20:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h8DML-000088-NA for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 20:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Mar 2019 00:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34981 X-GNU-PR-Package: emacs Original-Received: via spool by 34981-submit@debbugs.gnu.org id=B34981.1553473231456 (code B ref 34981); Mon, 25 Mar 2019 00:21:01 +0000 Original-Received: (at 34981) by debbugs.gnu.org; 25 Mar 2019 00:20:31 +0000 Original-Received: from localhost ([127.0.0.1]:57290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8DLr-00007I-53 for submit@debbugs.gnu.org; Sun, 24 Mar 2019 20:20:31 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:39344 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8DLo-000074-Pm for 34981@debbugs.gnu.org; Sun, 24 Mar 2019 20:20:29 -0400 Original-Received: from localhost (97-113-60-14.tukw.qwest.net [97.113.60.14]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 001F6FA02A; Mon, 25 Mar 2019 00:20:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553473223; bh=zUjkqKbxSaTSF/KMcnUq9Sv5XJZN6R4Ud621JpWdilM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=glJT2FyfTSqhG6r6Y8Od9qJqsowFfjiB5cs7iKZnKjzqG9GsLpVTMMRtg/xRQt6Ak LvJq8VT3oYslHqCjRRhDTYtb6VtIkXq+wxVzNGrFIpom3rMkjdu50K5wOMtbjW7e10 pTBZ6g67Tr4Sq1c15oAiJAZgNyCZrXnTDtEzIrhE= In-Reply-To: <87muljkf7y.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 24 Mar 2019 16:46:57 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156729 Archived-At: --=-=-= Content-Type: text/plain Eric Abrahamsen writes: > Alex Branham writes: > >> I'm trying to start using gnus and perhaps ran into a bug. I'm trying to >> view the emacs-devel mailing list through gnus, for starters. >> >> From emacs -q, built from the latest git master (commit >> 03e916beb0186f3707cd238650298870bf471575): >> >> (setq gnus-select-method >> '(nntp "gnus.user" (nntp-address "news.gmane.org"))) >> >> M-x gnus >> >> A A (gnus-group-list-active) > > Thanks for this report, I messed with Gnus recently and am now putting > out fires. This is a new error for me, and I'll try to fix it tonight. Actually, here's a patch -- will you please try this out? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=gnus-active-fix.patch diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index f1202e176e..8c2411f4d9 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -4029,7 +4029,7 @@ gnus-group-list-active (insert " *: " (gnus-group-decoded-name group) "\n")) - (list 'gnus-group (gethash group gnus-active-hashtb) + (list 'gnus-group group 'gnus-unread t 'gnus-level (inline (gnus-group-level group))))) (goto-char (point-min)))) diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el index 82141e0221..5a78df9fe4 100644 --- a/lisp/gnus/gnus-start.el +++ b/lisp/gnus/gnus-start.el @@ -2145,9 +2145,12 @@ gnus-active-to-gnus-format (condition-case () (if (and (stringp (progn (setq group (read cur) - group (if (numberp group) - (number-to-string group) - (symbol-name group))))) + group (cond ((numberp group) + (number-to-string group)) + ((symbolp group) + (symbol-name group)) + ((stringp group) + group))))) (numberp (setq max (read cur))) (numberp (setq min (read cur))) (null (progn --=-=-=--