From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 30 Mar 2019 17:27:11 -0600 Message-ID: <87a7hcndtc.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <871s2w510a.fsf@gmail.com> <922F9B91-2E9E-45F6-BB96-66CAE5E9FB81@gnu.org> <87k1goqpnn.fsf@gmail.com> <83imw8nspc.fsf@gnu.org> <87ftrcqg5j.fsf@gmail.com> <83bm20nm62.fsf@gnu.org> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="119251"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 31 00:28:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hANOe-000Uss-R6 for ged-emacs-devel@m.gmane.org; Sun, 31 Mar 2019 00:28:20 +0100 Original-Received: from localhost ([127.0.0.1]:39195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hANOd-0005az-LJ for ged-emacs-devel@m.gmane.org; Sat, 30 Mar 2019 19:28:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hANNy-0005ar-TG for emacs-devel@gnu.org; Sat, 30 Mar 2019 19:27:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hANNy-0002h3-0s for emacs-devel@gnu.org; Sat, 30 Mar 2019 19:27:38 -0400 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:42918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hANNx-0002gr-Qh; Sat, 30 Mar 2019 19:27:37 -0400 Original-Received: by mail-pf1-x433.google.com with SMTP id r15so2726189pfn.9; Sat, 30 Mar 2019 16:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=a5LC6jhyllP8QTAZx4Ub0U6ScbvoG1ZPNLTZbjoEtJY=; b=rGSlTwmgjQPm1p8RmARqt8pLCBubmqr6tDpv+8n3XLBjxJjeIrIkQ/oIJVBnzYnlfG s87GxrY1NwBBmLglqV7etFbxuex712lmoMsnfyhFHGzb2oTPF9Mvi8FO5ofoVwR9h/9N 68BAk2er9ShzIHLhFLvfBxVvAV6LHtEd7PjXtx9wVGPhb3JxOf9rqBcSunPXGd3//dpx OPomPqkICsmdmAyAiCpsl5mwQdNorNjJpAllJRtdNLBvCpliUKlpIkw/j8HyjGtKa6pw 3ior8MHsRzfcDAiufmCiEj/6ReK+AturlCCKTs7qXtjKjXx8pqjPV48pCw7ZhZFPt1iD GjJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=a5LC6jhyllP8QTAZx4Ub0U6ScbvoG1ZPNLTZbjoEtJY=; b=hPqQ9iWvE2aUUbDZqSYvycD8f7cdpb68O58m1NJ2pJUGVYihU8hlEzoGKBOh3ItTY8 Y9ASHDwRQ3IXGMVcxOr0HhpR6s7SE012DHoY9U0ZiTX54PeCWpcPJ5GIEMTYSBJX1e+A y/FRHtEdlY3l6fbWByeZiVq1JnxhQqCazQwep1xfg5u0I+FAIYxMk4D2i309npSaLris ER/HOOREr4p+C5Eu/SQxoe83gCkmQ9dnO/bMCRcfUtrN8h5TADYtBmuh/6C4kG7LkB5u qI2jhbUMXD0FRi2WH8DYV4JX4dMmuElLjWl+CbNNsKC01em+Q2y4lKh/5VsgOh5QBhuM tPYA== X-Gm-Message-State: APjAAAXjHdPMvbKeRit9r//fL3vGlsJko3dCvIgfGkaEh1mgD0Msz9oU msE4bVHUOoWRtHF0otjQ7Z61mxvf X-Google-Smtp-Source: APXvYqygV8US3w6W62sjuYWYpnrskz+1cYjz4Ls8tklWJ8M0+9q3of4bmOANgWWqzAVG6vvD7/BFlQ== X-Received: by 2002:a65:63d7:: with SMTP id n23mr24961578pgv.26.1553988456221; Sat, 30 Mar 2019 16:27:36 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id j71sm12863576pfc.6.2019.03.30.16.27.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 30 Mar 2019 16:27:35 -0700 (PDT) In-Reply-To: <83a7hci44l.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Mar 2019 21:55:22 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::433 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234831 Archived-At: Eli Zaretskii writes: >> From: Alex >> Cc: emacs-devel@gnu.org >> Date: Sat, 30 Mar 2019 11:59:08 -0600 >> >> >> Probably not. I was thinking about the rest being terminal hooks, >> >> though. WDYT? >> > >> > Not sure what you mean by "terminal hooks". They all accept a pointer >> > to a frame, no? >> >> I meant being used through a function pointer in the terminal struct >> rather than in the redisplay_interface struct. > > Are you talking about the arguments these functions receive now? If > so, which ones specifically get terminal struct pointers? Sorry for not being clear -- by "being terminal hooks" I meant being put in the definition of the terminal struct (in termhooks.h), rather than the redisplay_interface struct in dispextern.h. That is, being used like FRAME_TERMINAL (f)->some_hook rather than FRAME_RIF (f)->procedure. It's not a practical difference -- I'd rather not put the procedures in a counterintuitive place if there's an alternative.