From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Nicolas Goaziou Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs Date: Tue, 23 Apr 2019 10:20:15 +0200 Message-ID: <87a7ghw2tc.fsf@nicolasgoaziou.fr> References: <87k1gdptsn.fsf@len.workgroup> <87ef6l9x13.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="253644"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-orgmode@gnu.org, Stefan Monnier , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 23 10:22:04 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIqgl-0013k5-Rl for ged-emacs-devel@m.gmane.org; Tue, 23 Apr 2019 10:22:03 +0200 Original-Received: from localhost ([127.0.0.1]:49896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIqgk-0004de-KD for ged-emacs-devel@m.gmane.org; Tue, 23 Apr 2019 04:22:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIqgY-0004cN-GA for emacs-devel@gnu.org; Tue, 23 Apr 2019 04:21:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIqf8-0003xy-6X for emacs-devel@gnu.org; Tue, 23 Apr 2019 04:20:23 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:59325) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIqf8-0003v2-0w; Tue, 23 Apr 2019 04:20:22 -0400 X-Originating-IP: 185.131.40.67 Original-Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E9085FF806; Tue, 23 Apr 2019 08:20:17 +0000 (UTC) Mail-Followup-To: "Basil L. Contovounesios" , emacs-orgmode@gnu.org, Stefan Monnier , emacs-devel@gnu.org In-Reply-To: <87ef6l9x13.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Apr 2019 23:32:40 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.183.199 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235802 gmane.emacs.orgmode:124235 Archived-At: Hello, "Basil L. Contovounesios" writes: > The first is whether orgalist-mode couldn't use a custom > indent-line-function instead of advising what may or may not be set to > indent-relative by the user. I don't know how that would work in practice. But a minor mode taking control over `indent-line-function' sounds wrong. > The second is why advice--buffer-local does what it does. Stefan, why > does it behave differently depending on local-variable-p? Why can't it > simply call make-local-variable before returning the symbol-value? > > The third is why indent-according-to-mode hard-codes the check for > indent-relative and indent-relative-first-indent-point. Wouldn't it be > nice if this check instead looked up some variable akin to > electric-indent-functions-without-reindent, that can be more easily > customised? So what is the current status of this? Do I still need to add a workaround around a workaround around a genuine Emacs bug? :) Regards, -- Nicolas Goaziou