From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Mon, 29 Apr 2019 22:17:23 +0200 Message-ID: <87a7g8zhv0.fsf@gmx.de> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181563"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 22:18:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLCj8-000l4B-KQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 22:18:14 +0200 Original-Received: from localhost ([127.0.0.1]:34751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLCj7-00019m-Ih for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 16:18:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLCix-00018J-Md for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 16:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLCiw-0002Lr-U3 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 16:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54557) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLCiw-0002Lm-R5 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 16:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLCiw-0000f3-8H for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 16:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 20:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15565690582505 (code B ref 35418); Mon, 29 Apr 2019 20:18:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 20:17:38 +0000 Original-Received: from localhost ([127.0.0.1]:39868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCiX-0000eL-T8 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 16:17:38 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:45145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCiW-0000Yx-2m for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 16:17:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556569044; bh=VbmpX/k3V+AAG/mKYLnp/NGxHEGbg9v+RAEVcP6faaU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GC+orUCkI96qjGpz1rH6r2SSEii9eMc+ej3fuohD41MUpZt8LECn4GwAfWfVmwDuN 3aNqMQrJYcBS/pgX9d8VUJyZVWU8dwQ8/LUNa65aHmJ9YnzTKM1XYCgYHnNXlD155b KFui1TY0UDUcmv2UmQii8gge25C2lpjoK2tjubMQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWRVb-1hI7El0qJH-00XssA; Mon, 29 Apr 2019 22:17:24 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 29 Apr 2019 20:29:07 +0200") X-Provags-ID: V03:K1:XwLEBdvkvk0Vgmi+Eo4/l80C/fLLK+xjiEHICEw6lnxnG2xoZPx cIq28e+2zQAMtmr+3n9ILW0XR/Mb5C7RT57A3n0ADlVIDtBMhiUZlD7aReUOVT6xAgKjK5e d3D/bHvwfbsHmq2Np36m7filjiTA+X75sqT45LPSVVmijvA0vEF6Nat/nOvdDJvmwfOrVEV olqRd4XrtH5ycTrJ098mg== X-UI-Out-Filterresults: notjunk:1;V03:K0:CjDH4N1JSTA=:EvKgmLWWVg4UHTl1vvIscn Q5nHd55BO7LaRatk6avDvO6G1g7xMghvklQLlNLX07dS86ZBHHAt4nSMoDzBs/DPXV0i8VVmj 7C5rjBt5WTscR5CXdLMHlKrr8beHSPZ3bcK/qMsYpZGjP6wrOULuz1FpEXbPyFY2UmdGhhSYi aMPB65aqlA/NLmwAyll7J51QVcin5/QNqUxNBZa3tW9RivNTIaE1uPd1yGldLeQqqGHFIu+bq TvfoC20XGsG4/JxrZJKCRhC6iV8s7mStJ/9O/rTlNgF3T8KGOGNg1dRoWfG+F7dZEbS9xLUpJ XKwc+3N//v5yZlXhNj61EbFIHcqjjdeaO3FSoi7Uht6bwXueV0M2ZSAccCuPUjJk3gbj1W8kA jIshjCIgasuwZPDB20J9yAPG6bFJE8IBr0FxbLbl6nltfXlJTLKbHen+qA8L7qD49WTowTiUI 1GhNLs6/PBDFQFoTYBIQX25Fmt2/RJ0E8BI30l9Qn9hzl1BXGQDCGaQAkE1N9wgb+ZkYCbwqn hebcrU3TqiQ0Ia++9diagNGfZZlAiNEFdgyy3+AVP652Nx5Zk2E4Kvx9ElcEulK2bQNlZPOEO lh+qxmRuAYM0M73hW/VZ669EjCd/uzlncXbnKVvSlzMabSLsv8mgmx6yEVDemiE8aJ4Hyi/wq EhSIZhP4npKxtR1o67dqrsi/QoL6JyyjU2JS5Paezvg3oXROHXePxyEj+LmdmGODGex4RKY/E 0n8YWnZt59u3tnybe7xcxCS59+o1VhQt76zF5SHgybct+DM1/bwzrPTMcYykyYIzMmFalmtD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158451 Archived-At: Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Very well; here is an incremental patch (to make the differences > clear). It's a compromise: the derived state is gone, but there are > two functions: one for the list of buffers that need to be polled, and > one for whether that list would be non-empty. Thanks, this goes to the right direction. > By the way, the patch now uses functions from cl-lib, not just > macros. Is there any reason not to? No problem. >From my POV you could push it (with the final decision for the name from Eli). If there are problems, people will react soon - that's my experience with autorevert changes. But we have autorevert-tests.el, so at least the important cases are covered. I'm wondering if there are some tests which need to be added. Best regards, Michael.