From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: 35476@debbugs.gnu.org
Subject: bug#35476: Test suite
Date: Tue, 30 Apr 2019 08:08:33 +0200 [thread overview]
Message-ID: <87a7g8owim.fsf@gmail.com> (raw)
In-Reply-To: <87lfzu9hsl.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
As part of the discussion on help-gnu-emacs[1], Stefan applied a simpler
patch in commit f478082f9f, only for font-lock-prepend-text-property
though. Does it make sense to do the same in
font-lock-append-text-property?
As a learning experience with ERT, I wrote the attached test suite; with
the current master branch, only the prepend test passes, the other
fails. Applying the same change in font-lock-append-text-property lets
both tests pass.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-a-test-suite-for-anonymous-face-handling-in-text.patch --]
[-- Type: text/x-patch, Size: 2480 bytes --]
From 7bd1a551de8cef452a7ade7eaa055d38bf3a0800 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?K=C3=A9vin=20Le=20Gouguec?= <kevin.legouguec@gmail.com>
Date: Tue, 30 Apr 2019 08:00:34 +0200
Subject: [PATCH] Add a test suite for anonymous face handling in text
properties
* test/lisp/font-lock-tests.el: New test suite. Only
font-lock-test-prepend-anonymous-face passes as of f478082f9f.
---
test/lisp/font-lock-tests.el | 43 ++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 test/lisp/font-lock-tests.el
diff --git a/test/lisp/font-lock-tests.el b/test/lisp/font-lock-tests.el
new file mode 100644
index 0000000000..ad282f6cad
--- /dev/null
+++ b/test/lisp/font-lock-tests.el
@@ -0,0 +1,43 @@
+;;; font-lock-tests.el --- Test suite for font-lock. -*- lexical-binding: t -*-
+
+;; Copyright (C) 2019 Free Software Foundation, Inc.
+
+;; This file is part of GNU Emacs.
+
+;; GNU Emacs is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; GNU Emacs is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Code:
+(require 'ert)
+
+(ert-deftest font-lock-test-append-anonymous-face ()
+ "Ensure `font-lock-append-text-property' does not splice anonymous faces."
+ (with-temp-buffer
+ (insert "foo")
+ (add-text-properties 1 3 '(face italic))
+ (font-lock-append-text-property 1 3 'face '(:strike-through t))
+ (should (equal (get-text-property 1 'face (current-buffer))
+ '(italic (:strike-through t))))))
+
+(ert-deftest font-lock-test-prepend-anonymous-face ()
+ "Ensure `font-lock-prepend-text-property' does not splice anonymous faces."
+ (with-temp-buffer
+ (insert "foo")
+ (add-text-properties 1 3 '(face italic))
+ (font-lock-prepend-text-property 1 3 'face '(:strike-through t))
+ (should (equal (get-text-property 1 'face (current-buffer))
+ '((:strike-through t) italic)))))
+
+(provide 'font-lock-tests)
+
+;; font-lock-tests.el ends here
--
2.21.0
[-- Attachment #3: Type: text/plain, Size: 121 bytes --]
Apologies for posting all over the place.
[1]: http://lists.gnu.org/archive/html/help-gnu-emacs/2019-04/msg00289.html
next prev parent reply other threads:[~2019-04-30 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 17:11 bug#35476: [PATCH] 27.0.50; font-lock-{append,prepend}-text-property and anonymous faces Kévin Le Gouguec
2019-04-30 6:08 ` Kévin Le Gouguec [this message]
2019-05-07 5:24 ` bug#35476: [BUMP] Some questions before closing Kévin Le Gouguec
2019-05-12 12:28 ` bug#35476: font-lock-{append, prepend}-text-property and anonymous faces Noam Postavsky
2019-05-12 17:34 ` Kévin Le Gouguec
2019-05-12 19:09 ` Noam Postavsky
2019-05-12 21:51 ` Kévin Le Gouguec
2019-05-14 1:01 ` Noam Postavsky
2019-05-14 6:01 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7g8owim.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=35476@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.