From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/gnus-decoded 548c778: Don't add encoding cookie in Gnus' active files
Date: Wed, 01 May 2019 09:27:06 -0700 [thread overview]
Message-ID: <87a7g6gmxx.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <jwvzho6maz5.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Wed, 01 May 2019 11:50:17 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * lisp/gnus/gnus-util.el (gnus-write-active-file): This doesn't do
>> what I thought it would do.
> [...]
>> - (insert (format ";; -*- encoding: %s; -*-\n\n" coding-system-for-write))
>
> Not sure what you expect it to do, but the above cookie indeed likely
> doesn't do anything at all. If you change `encoding` to `coding` then
> it should have the effect of telling Emacs which encoding to use when
> reading the file.
Well that's embarrassing! I was wrong on two levels. It was later
pointed out to me (this is in the later discussion on #35383) that the
cookie wouldn't even influence how Emacs read the file in this case, so
there wasn't much point. Right now the code assumes that it will be able
to read files written as 'raw-text using 'utf-8-emacs.
prev parent reply other threads:[~2019-05-01 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190501152057.8555.99227@vcs0.savannah.gnu.org>
[not found] ` <20190501152059.0E9D9209A5@vcs0.savannah.gnu.org>
2019-05-01 15:50 ` [Emacs-diffs] scratch/gnus-decoded 548c778: Don't add encoding cookie in Gnus' active files Stefan Monnier
2019-05-01 16:27 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7g6gmxx.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.