From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Fri, 10 May 2019 14:43:23 +0200 Message-ID: <87a7fu1nv8.fsf@gmx.de> References: <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157594"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 10 14:44:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hP4sl-000erH-BG for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2019 14:44:11 +0200 Original-Received: from localhost ([127.0.0.1]:42716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP4sk-0006ia-7K for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2019 08:44:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP4sd-0006iI-Mk for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 08:44:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP4sc-000338-ME for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 08:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52094) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hP4sc-00032w-IH for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hP4sc-00071y-Ew for bug-gnu-emacs@gnu.org; Fri, 10 May 2019 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155749221826987 (code B ref 35418); Fri, 10 May 2019 12:44:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 10 May 2019 12:43:38 +0000 Original-Received: from localhost ([127.0.0.1]:37405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP4sE-00071C-JQ for submit@debbugs.gnu.org; Fri, 10 May 2019 08:43:38 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:34061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP4sC-00070y-UF for 35418@debbugs.gnu.org; Fri, 10 May 2019 08:43:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557492205; bh=3hG3EantjWcZHqhSKSjwJjmGKBPSch69HTvjthiV6CQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=PuhvjGhaB4Dq1qMM6FGjGbnjlIDvWogoYb2GmG72vyLsYJRTHbI058vxpqKwOY7lw k3Ep4Jj+EJBZ2cy3J69nEap25SqQ5JyVYIB+3XNDmxS3KNyvuF83rC1jSc0SSbLldt KexCH1mmPY6rVB/05M3ufCREuOsrNaHwLKq/Whts= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N33Ed-1ghwzg1iwv-013Og6; Fri, 10 May 2019 14:43:25 +0200 In-Reply-To: <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Fri, 10 May 2019 14:27:14 +0200") X-Provags-ID: V03:K1:MS5xF5Dsrw99x46eXsB5AQXgHojMCA/ac4Ppn9ihCYVhGESU4Yh 5jwYQ3W7pdzbTEG5g7tnqoLz6wlo89D+FxU2nfWN7uMgC3/0oFmd8QmZeGY8XPcB/GiXSt9 phPUlIfEGwBY6h+e8MY/f/iCfQac5rmjRHdaRtyFmyEXeQcksNggkIhKcT62dSfmedt31n0 mfNCWo8D9yRevW5ZTWSWQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:XHSpVtU4vC4=:oyoX331jUoeTXvyfpfnm8d eRYhwiqYOes0EuSXnbb8RG5z9wSH+zNr/SpiFZA0qwL3cYAcSMIJ0IkqtWMkgLKD1skMO0AFM gVx39K+qdKozmxx+EQg7mexXNOInMRfev4GHl4W7t2HFmj3gGrXSe6Iza3URxEA2j66lMBD5P 0flxtEaVvCUElS+Zh6v/qUkAIlvMnxRtEaJU+QvRTc0Vui5WN25/14f35O2NrEJPLwWkQNnN0 4sgZBHeYyAAsdHTR76SHhlknoIO1qwon3M/mYklfuE/m5BXqgeIoSqx23KAbsUzNsjwodYD08 HZMJncQ/UDPcEKiDVbYgBZehHQigCwiZoX8n7oqxV5f8inXTK8BYjJgZwFYSkVfD31cDT/6of 5eUo7rpOWV3clCO1sVr4LBOvZi9mvQHoC4gy611d54WOGB7x3SFJLchfijJBjIpXhQEvgwEZi Vwhe7XFqfHMgwH4RUYoX/avQNEmtIXs8K2OQ0iiEoLG7CW0bm9iQEMInQ1Ya+8gxtQCta9+Qw /HywGKObZYUet72JlJVrFKu7tNN/Q98s69ymHk9GGwOiUQEpcHBHoNhM8Xa9XZRfyLArK5DQ+ DAHazcc3ZdABvQFhBuYF0/gn61Me/qLhvnYKD1qwk2BEOA2Z/kw9YIBjsIy2zhLLhKfWwcGM7 fMqZwh+IqNXO7/HUw5U0mTLvHKVabGTZAv6ZPLOia13EJqz8xom65RGaUxF4bVlkj4bbibCsT xuR5U/64mZ6A/7staGZ3AjVBm2hTYAGTZzMGrjJkM91ZL5GQYAaLcDaFSIvg5x4xyMghOdiu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159039 Archived-At: Mattias Engdeg=C3=A5rd writes: > That would suffice for this particular need, but we may contemplate > some variations for general utility, such as passing the old value of > buffer-file-name to the hook. It also wouldn't catch direct > modifications of buffer-file-name, but that mostly happens in special > buffers that we don't want to autorevert anyway (?). So we must document in the Elisp manual, that buffers, which want to participate in global-auto-revert-mode after a renaming, shall change the name via set-visited-file-name. > Perhaps we should exclude all buffers whose name start with a space > from any kind of auto-revert, just in case. Agreed. Those buffers are special (internal) anyway, it's already tricky to show them. Nobody needs auto-revert for invisible buffers :-) > Agreed, and I never liked that variable name much myself. What about > `auto-revert--global-mode'? (More names in autorevert.el should have > double dashes, but I suppose it was written before that convention > came along.) D'accord. >>> +(defun auto-revert--find-file-noselect-advice (buffer) > [..] >>> +(defun auto-revert--after-change-major-mode () >>=20 >> These are almost identical. Make argument buffer optional, and it is >> just one function. > > Good point, but the advice functions will probably be replaced anyway > per your request; let's see what it looks like when that is done. But they will convert to hook functions then ... Best regards, Michael.