all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Sven Willner <sven.willner@gmail.com>
Cc: Robert Pluim <rpluim@gmail.com>,
	32214@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#32214: [PATCH] 'message-kill-buffer': fix backup delete question
Date: Mon, 13 May 2019 17:03:28 -0400	[thread overview]
Message-ID: <87a7fqqd7j.fsf@mouse.gnus.org> (raw)
In-Reply-To: <877elkbsu4.fsf@gmail.com> (Sven Willner's message of "Tue, 24 Jul 2018 16:40:03 +0200")

Sven Willner <sven.willner@gmail.com> writes:

> hmm, having a second look into message-disassociate-draft, I am still
> not sure what is supposed to happen there.
>
> anyway, my motivation for the patch was to eliminate a rather annoying
> (since unnecessary) question to remove a non-existing backup/auto save
> file. here is the minimal patch (without any further changes to the
> code) doing so.
>
> I think, it makes sense to also check for the existing file-name to
> only remove a backup file if there is a properly saved message, too.

I'm not sure this patch is correct -- it's supposed to query if either
the automatic backup file exists, or a Gnus draft message exists, I
think?

If you're being queried, Message thinks that one of the two exists.
Both of them don't have to exist for the query to be relevant.

So I'm not sure quite what you're seeing here, and I'm never asked about
deleting non-existent draft files.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-05-13 21:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 11:39 bug#32214: [PATCH] 'message-kill-buffer': fix backup delete question Sven Willner
2018-07-19 11:54 ` Sven Willner
2018-07-19 16:15   ` Robert Pluim
2018-07-19 17:16     ` Sven Willner
2018-07-20 23:26       ` Noam Postavsky
2018-07-24 14:40         ` Sven Willner
2019-05-13 21:03           ` Lars Ingebrigtsen [this message]
2019-06-23 23:00             ` Lars Ingebrigtsen
2018-07-19 15:24 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7fqqd7j.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=32214@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    --cc=rpluim@gmail.com \
    --cc=sven.willner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.