From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#35675: 27.0.50; Is line-number-at-pos unnecessarily slow? Date: Tue, 14 May 2019 07:34:24 -0500 Message-ID: <87a7fp8ban.fsf@gmail.com> References: <87zhnuuj0y.fsf@gmail.com> <878svcwwwk.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="219015"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 27.0.50 Cc: 35675-done@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 14 14:35:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQWea-000ukQ-B8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 14:35:32 +0200 Original-Received: from localhost ([127.0.0.1]:47630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQWeZ-0008P9-Ak for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 08:35:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQWe7-0008AO-Ve for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 08:35:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQWe7-0004ze-0Y for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 08:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQWe6-0004za-TW for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 08:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQWe6-0005L5-Mr for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 08:35:02 -0400 Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35675 X-GNU-PR-Package: emacs Mail-Followup-To: 35675@debbugs.gnu.org, alex.branham@gmail.com, alex.branham@gmail.com Original-Received: via spool by 35675-done@debbugs.gnu.org id=D35675.155783727620482 (code D ref 35675); Tue, 14 May 2019 12:35:02 +0000 Original-Received: (at 35675-done) by debbugs.gnu.org; 14 May 2019 12:34:36 +0000 Original-Received: from localhost ([127.0.0.1]:47633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQWdg-0005KI-5m for submit@debbugs.gnu.org; Tue, 14 May 2019 08:34:36 -0400 Original-Received: from mail-ot1-f51.google.com ([209.85.210.51]:36776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQWde-0005K6-Ne for 35675-done@debbugs.gnu.org; Tue, 14 May 2019 08:34:35 -0400 Original-Received: by mail-ot1-f51.google.com with SMTP id c3so15031137otr.3 for <35675-done@debbugs.gnu.org>; Tue, 14 May 2019 05:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=S3d0WOarsprbUkdxL4uVnsLAcmAUbAN4ND+3dViWq48=; b=dMlDAI3fx0q8dtkzvsDJNmu4LxMq9sMteF7jCe2DmF4h5rDJnUKVpDeXHGCTu/EGx/ XOILM3y9IKLLlW0jHZsGx841A8Zc72e1shQK8O8jEGFyvVadXeVIhGKiXkjndjFTCkVx sAArR+q4L1FPr7aKxrjSxSuuJJDRD1OHPXbINHiUjsuPNKm9wR3FthDa6jvsHT/8CJp8 Mrz2vcHXt2FM+8RFdZ3XpoGKVn49Xg3GJkgqh+KikSevglU5YDsS0xmVUykgQnRCaUdg N77RfjEkADSuAWA3cm9dP0rWCw+9Grsv2RLwJ2hIhN/Xzrg6otJGyIrG0HXXtbdlm02A NVOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=S3d0WOarsprbUkdxL4uVnsLAcmAUbAN4ND+3dViWq48=; b=A/IW6dev5+tn79d35vhA+Su4qIYSCya7ZWDKd1KO3wJz04QpBb4wYSfO6J/SOpLB+O TqJ3ZFoW6v+F9J+R+d1axf7VWQsPxG4UUjCjJ+CLYkWUBncTagbHa7UyFwsrfq+BSCUq AajGcEysAIC2NMarp0Od+dcFcIhogjQAzw7iufW6gkafqq7jxBwhWzx58DMnicMRORmg yCz0hNeTH6T68VK1oDUttoWGL1dv6ELs5TnzaX70QH7n28FSNvO//vGuGgRnAPJ8Rk5I VfzYdJ55ZV9j8ln981sdGWorFMSPCMEX9RZctwJGpOYWZnLnkaDeXeG6qBCFmfS6K1yX s/tw== X-Gm-Message-State: APjAAAUcXdQpcZCBLI03BAMKJaeV1BdlHvD/TZhET3ISecZVpnJgGpOo zQJCAWkpPxZOaluClM8xWbFv5Yf3 X-Google-Smtp-Source: APXvYqwVgwcqEIkSaf0DL7o1wSbF9EC+yYvIreVCgT8+e/ddXRaNES4YbVqw87fNjIl9KCoI0sA4iw== X-Received: by 2002:a9d:5f13:: with SMTP id f19mr2825263oti.219.1557837266615; Tue, 14 May 2019 05:34:26 -0700 (PDT) Original-Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id r15sm3028891oie.5.2019.05.14.05.34.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 05:34:24 -0700 (PDT) In-reply-to: <878svcwwwk.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159271 Archived-At: On Sat 11 May 2019 at 15:36, Basil L. Contovounesios wrote: > Alex Branham writes: > >> line-number-at-pos basically regex searches forward for \n's and >> counts them up. > > It only does this (via count-lines) if selective-display is t, which is > deprecated and seldom used. Otherwise it uses the value returned by > forward-line (defined in C), which calls find_newline, which AFAIK uses > the buffer's newline cache to some extent (I'm not familiar with its > implementation). Thanks, I missed/misunderstood that part. > Either way, as Eli says, there's often an algorithmic solution to > slowness in uses of count-lines. I'll take that advice and see if there's a more clever way to go about it. Thanks again, Alex