From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35940: [PATCH] bookmark.el: Remove support for renaming ancient "~/.emacs-bkmrks" file Date: Thu, 30 May 2019 13:50:43 +0100 Message-ID: <87a7f4t8bg.fsf@tcd.ie> References: <87h89cuoum.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180442"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35940@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 30 14:51:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWKWf-000kIQ-Fs for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 14:51:21 +0200 Original-Received: from localhost ([127.0.0.1]:53653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWKWZ-000319-1J for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 08:51:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWKWQ-0002zw-2e for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWKWP-0000oo-1y for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:51:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47412) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWKWO-0000oV-Ut for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:51:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWKWM-0001yN-Bx for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 08:51:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 12:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35940-submit@debbugs.gnu.org id=B35940.15592206557569 (code B ref 35940); Thu, 30 May 2019 12:51:02 +0000 Original-Received: (at 35940) by debbugs.gnu.org; 30 May 2019 12:50:55 +0000 Original-Received: from localhost ([127.0.0.1]:60956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWKWE-0001y1-Eo for submit@debbugs.gnu.org; Thu, 30 May 2019 08:50:54 -0400 Original-Received: from mail-ed1-f67.google.com ([209.85.208.67]:39673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWKWA-0001xe-QV for 35940@debbugs.gnu.org; Thu, 30 May 2019 08:50:51 -0400 Original-Received: by mail-ed1-f67.google.com with SMTP id e24so8973675edq.6 for <35940@debbugs.gnu.org>; Thu, 30 May 2019 05:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oceIiV3SRHT7kAq3PnIh1NbV4RxWbAr1YatmHB1h1PQ=; b=LsT0Dxo2TnTeUC+CCgKBu0ru1KKWmzImUv7b3Qej3510QpdDP3pV0oRt2sJS61QAdf mBIyckpl4baVpz67yjbX8JLdrY8ZWuoDvx1cQEBaPeJi7aoWILpDoy+nL9R86dchhhLD Tnzlm6smTJ/R31N2HqwEWfQb2aKicnIJlxzz/SSfSxMWW10/gJt2xaM5VGXssHf2X4yu /hQPY4e4WCatbjxGGnMsAqHVpibJgUK56c/44azKY4MnOdDnprZRqsNDDfrovhVarP9D +OCMplLs00HhatI7VLLTpjRvTe4L04/z888HdxBq7ELFMBM3+vQphYLFUt4Lz/vc9hxu Cltg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oceIiV3SRHT7kAq3PnIh1NbV4RxWbAr1YatmHB1h1PQ=; b=QvUXbaF1Dpj3qERyzmlH8m2dae9HqJiGqQMsByUlkiShLeuQnPcISz0afocIH/7o/b zwt8J17Zh3IWvygKbzGULG3M+NAlmyI0CJyzKQaUpmtR/RlGbjPdb2SPGLzVWYAinpk/ 1Qb7pKKR7Kqhbt/QJB+W9UI6pGiHTs+E1HOqxKAFDw+XjQ8E4pfr7dLBvMtt2m3gGJ7R GWc2JrNnZOEmJkKF527xahacw+Wk52/rtPMUur6ska4BSyb9kgm9Sot/pG5mpZrTF4GO L+9GTjylmSZi7bcRQSjVNbKDgSMtdMidTjZeC50bid4hNkh/Vjv6ppQeBs2rMaeCx7d8 8PCg== X-Gm-Message-State: APjAAAXr32Nd4UaP2XA8D5EzcfxSOY65YQouELWouYwg4woJ9kD069/X durmbIH+w47/ZxHD602U737Kw6N12Asc1g== X-Google-Smtp-Source: APXvYqxLEtfUgc1UxLjc9xKo1CMn7aWqBcMN+pMAcvbm/CbnnXdsdZjXByZqQ/DZc68gftBysDEmiw== X-Received: by 2002:a50:9738:: with SMTP id c53mr4386351edb.156.1559220644933; Thu, 30 May 2019 05:50:44 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id c2sm707666edb.23.2019.05.30.05.50.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 30 May 2019 05:50:44 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 30 May 2019 14:23:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159917 Archived-At: Stefan Kangas writes: > Thank you for having a look. Thank you for working on this. > Basil L. Contovounesios writes: >> Looks fine to me, but I suggest simultaneously making bookmark-file >> (the old name of bookmark-default-file[1]) an obsolete varalias of >> bookmark-default-file. > > Agreed, I've actually already submitted a separate patch for that: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35917 Right, I saw that just after I sent my previous message. Both changes LGTM, so I'll push them in the coming week if there are no other comments before then and no-one beats me to it. But could you please first amend the commit messages to mention their bug#numbers and list file names relative to the project root, i.e. lisp/bookmark.el instead of bookmark.el? Thanks, -- Basil