From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#18241: 24.4.50; [PATCH] I can now highlight-lines-matching-regexp from isearch Date: Tue, 25 Jun 2019 15:58:00 -0700 Message-ID: <87a7e55l3b.fsf@shorty.i-did-not-set--mail-host-address--so-tickle-me> References: <87sil4uhlw.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51558"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.0; emacs 27.0.50 Cc: 18241@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 00:59:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfuPH-000DGS-Fx for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 00:59:20 +0200 Original-Received: from localhost ([::1]:35660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuPG-0003yn-Gy for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 18:59:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54124) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuP1-0003yg-O0 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfuP0-0005Oe-MT for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfuP0-0005Nt-Cp for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfuP0-0000Dv-9o for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 18:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18241-submit@debbugs.gnu.org id=B18241.1561503492779 (code B ref 18241); Tue, 25 Jun 2019 22:59:02 +0000 Original-Received: (at 18241) by debbugs.gnu.org; 25 Jun 2019 22:58:12 +0000 Original-Received: from localhost ([127.0.0.1]:33808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuOC-0000CV-5h for submit@debbugs.gnu.org; Tue, 25 Jun 2019 18:58:12 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuO8-0000CC-F6 for 18241@debbugs.gnu.org; Tue, 25 Jun 2019 18:58:11 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 003F6218BB; Tue, 25 Jun 2019 18:58:02 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 25 Jun 2019 18:58:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=fm3; bh=5gR5cOCJq9l8OpfWATZUWATFqr PDeuOhjWFKg6QOwIo=; b=nWRwQdt2y6GCZkacbZN8E0zprlQbdoc2NieeqKyWZL 9NRasod0XPaJYX85IosPqN/DQR/ISMKsKPqD1a/tIiqs6Y026qDPIJS7azKTx3DB G9GjOh7sWXsrZJQGeAR1gBRVX7TsY1WsEkZVtQle6LLv0q+36rgJJYRmNPrE6Bal IfFl0lr70RQvqiiBo9leZ64noXiGOAdIE4B8m9gxYfW1LzCOJVCSKyffbSMb6KuH wglLe0iC7uKWJRRCIE1DqrA8FgB0gaOgCPBbfzcxffOuXIty5TfmJmWZSTPHwGnB wlZs2Gpu32Zk1gh6Q4uSnakm8v+d0cisfsxGcnYg0eoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5gR5cO CJq9l8OpfWATZUWATFqrPDeuOhjWFKg6QOwIo=; b=sMRaY8Q+WGNAoULdVIy5jW t4Wk3iJ1oXmmRtcjMV2UYjh2emZrRT9fe70Ab7QbW8abtFHCGVHXxXNcMoPSv9xh oOZ1+6csECw4rcUcSSfVXx6HVNddFTtVgJx7DwiXF+i0DuEKnkkhhe9YXuEddORu uhdE3mJNr8WZZE1vpTqJHyK3SP0j4GEYK90hqU5b/8/PdFKDJjutVhznQLBEz0Bu BEXmeKtlHigHp0vXcKp5MSL8B6YiiA1wH7Uv5wXiuNXn4fLQYIasgd4SoUUtlkmy m8ngkWiqK8GOx/O5BWvJLeUU0bWlSiBJoLm83mjlRwMgIi423GbSvtLgzZPd1wCw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvffujgffkfggtgesthdtredttdertdenucfhrhhomhepffhimhgrucfm ohhgrghnuceoughimhgrsehsvggtrhgvthhsrghutggvrdhnvghtqeenucfkphepvddtje drudehuddrvddvfedrudekleenucfrrghrrghmpehmrghilhhfrhhomhepughimhgrsehs vggtrhgvthhsrghutggvrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Original-Received: from shorty.local (nat-guest-189.vonkarman.net [207.151.223.189]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D0BB80059; Tue, 25 Jun 2019 18:58:02 -0400 (EDT) Original-Received: from dima by shorty.local with local (Exim 4.90) (envelope-from ) id 1hfuO0-0001YZ-No; Tue, 25 Jun 2019 15:58:00 -0700 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161440 Archived-At: Lars Ingebrigtsen writes: > Dima Kogan writes: > >> Before this patch it was possible to 'M-s h r' during an isearch to >> highlight the regexp being sought. This patch adds similar functionality >> for matching lines with 'M-s h l'. This patch moves the previous 'M-s h >> r' isearch functionality into a macro, and then calls this macro >> separately for the regex and line cases. > > Hm... Is that a feature that would be used a lot? It's a somewhat > awkward interface and keystroke, I think. I'd use it. If this is already available for "M-s h r", there's a reasonable expectation that "M-s h l" would work too. I don't disagree that the keystroke is awkward, but that's what we've had for a long time, and I'd rather not change it. > I think this should be a function that should just take a function to > call that takes the parameters required. OK > And if this is something we want, it needs a NEWS entry and > documentation updates. I can write them if this is something we want. Is this something we want?