From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Question about dired-do-find-regexp and xref-collect-matches Date: Tue, 09 Jul 2019 16:18:22 -0700 Message-ID: <87a7dm6blt.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="100884"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 10 01:19:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkzOs-000Q79-22 for ged-emacs-devel@m.gmane.org; Wed, 10 Jul 2019 01:19:54 +0200 Original-Received: from localhost ([::1]:56746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkzOq-0005UZ-Jv for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2019 19:19:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41384) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkzNk-0005UR-DA for emacs-devel@gnu.org; Tue, 09 Jul 2019 19:18:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkzNj-0002Mp-7E for emacs-devel@gnu.org; Tue, 09 Jul 2019 19:18:44 -0400 Original-Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:54830 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkzNi-0002I9-G4 for emacs-devel@gnu.org; Tue, 09 Jul 2019 19:18:43 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hkzNY-000OWv-3e for emacs-devel@gnu.org; Wed, 10 Jul 2019 01:18:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:20mJ8nZ8E0eyE+AGDTHMclHCB3U= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238489 Archived-At: A while ago I switched to the fish shell, which I generally like better than bash. A bit after that I noticed that marking files in Dired and using "A" (dired-do-find-regexp) to search them was extraordinarily slow. Going up a level to the parent directory and only marking the child directory, the search was nearly instantaneous. But that meant I had to search all the files in the child directory. I suspected it was something to do with fish, and indeed setting shell-file-name to "/usr/bin/bash" sped it up a little -- but that's a bug report for another day. While poking around I also noticed that dired-do-find-regexp calls xref-collect-matches once per marked file. That means a full find+grep call for each file, when a single find+grep call (or even just a single grep call!) would do the trick. The search hits are collected as: (mapcan (lambda (file) (xref-collect-matches regexp "*" file (and (file-directory-p file) ignores))) files) But the second argument to `xref-collect-matches' can be a space-separated string of file names -- wouldn't it be easier just to call `xref-collect-matches' once? Eric