From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Question about dired-do-find-regexp and xref-collect-matches
Date: Tue, 09 Jul 2019 16:18:22 -0700 [thread overview]
Message-ID: <87a7dm6blt.fsf@ericabrahamsen.net> (raw)
A while ago I switched to the fish shell, which I generally like better
than bash.
A bit after that I noticed that marking files in Dired and using "A"
(dired-do-find-regexp) to search them was extraordinarily slow. Going up
a level to the parent directory and only marking the child directory,
the search was nearly instantaneous. But that meant I had to search all
the files in the child directory.
I suspected it was something to do with fish, and indeed setting
shell-file-name to "/usr/bin/bash" sped it up a little -- but that's a
bug report for another day.
While poking around I also noticed that dired-do-find-regexp calls
xref-collect-matches once per marked file. That means a full find+grep
call for each file, when a single find+grep call (or even just a single
grep call!) would do the trick.
The search hits are collected as:
(mapcan
(lambda (file)
(xref-collect-matches regexp "*" file
(and (file-directory-p file)
ignores)))
files)
But the second argument to `xref-collect-matches' can be a
space-separated string of file names -- wouldn't it be easier just to
call `xref-collect-matches' once?
Eric
next reply other threads:[~2019-07-09 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 23:18 Eric Abrahamsen [this message]
2019-07-09 23:33 ` Question about dired-do-find-regexp and xref-collect-matches Drew Adams
2019-07-10 0:30 ` Eric Abrahamsen
2019-07-30 14:50 ` Dmitry Gutov
2019-07-30 17:22 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7dm6blt.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.