From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Wed, 31 Jul 2019 20:41:32 +0200 Message-ID: <87a7cuvyg3.fsf@mouse.gnus.org> References: <87ef26ac17.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207990"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 31 20:42:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hstXy-000rzb-Ed for ged-emacs-devel@m.gmane.org; Wed, 31 Jul 2019 20:41:58 +0200 Original-Received: from localhost ([::1]:43682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hstXx-0003gO-E5 for ged-emacs-devel@m.gmane.org; Wed, 31 Jul 2019 14:41:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55104) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hstXg-0003dX-2p for emacs-devel@gnu.org; Wed, 31 Jul 2019 14:41:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hstXe-0002Mh-NW for emacs-devel@gnu.org; Wed, 31 Jul 2019 14:41:39 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:48244) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hstXe-0002Lk-H1; Wed, 31 Jul 2019 14:41:38 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hstXZ-0007ss-Id; Wed, 31 Jul 2019 20:41:36 +0200 In-Reply-To: <87ef26ac17.fsf@gnu.org> (Tassilo Horn's message of "Wed, 31 Jul 2019 09:39:00 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239054 Archived-At: Tassilo Horn writes: > when fixing bug#34160 you've reverted my changes that made json pretty > printing use replace-region-contents. That had the major benefit that > pretty printing the JSON object at point didn't move point. I use that > many times a week on large JSON objects using the following command. [...] > AFAICS, the problem in bug#34160 was not caused by my changes (the user > used Emacs 24 and not a 27 snapshot) so I see no justification for > removing my feature. The user referred to "http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/json.el#n740", which doesn't look like Emacs 24? > Could you please reinstall the feature or describe why it is not > feasible to keep it? As the bug in question described -- pretty-printing a JSON region would silently delete everything but the first JSON object, which doesn't seem like optimal behaviour for a pretty-printing function. If there's a problem where point is moved unnecessarily, then that should be fixed, of course. Do you have a test case? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no