From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#19892: 25.0.50; hideshow: hs-hide-all-non-comment-function example infloop Date: Fri, 02 Aug 2019 21:17:00 +0200 Message-ID: <87a7crnzrn.fsf@mouse.gnus.org> References: <87r3tonon8.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="94997"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: ttn@gnu.org, dann@ics.uci.edu, 19892@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 02 21:18:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htd45-000OYg-OY for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Aug 2019 21:18:09 +0200 Original-Received: from localhost ([::1]:37100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htd44-0000aP-4O for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Aug 2019 15:18:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45536) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htd3z-0000aI-Nl for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htd3y-0001wC-Hd for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htd3y-0001w4-Em for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1htd3y-0007Ri-7M for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Aug 2019 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19892 X-GNU-PR-Package: emacs Original-Received: via spool by 19892-submit@debbugs.gnu.org id=B19892.156477342928556 (code B ref 19892); Fri, 02 Aug 2019 19:18:02 +0000 Original-Received: (at 19892) by debbugs.gnu.org; 2 Aug 2019 19:17:09 +0000 Original-Received: from localhost ([127.0.0.1]:57732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htd37-0007QV-E9 for submit@debbugs.gnu.org; Fri, 02 Aug 2019 15:17:09 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:34484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htd35-0007QN-6r for 19892@debbugs.gnu.org; Fri, 02 Aug 2019 15:17:07 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htd2z-00059i-F5; Fri, 02 Aug 2019 21:17:03 +0200 In-Reply-To: <87r3tonon8.fsf@web.de> (Michael Heerdegen's message of "Tue, 17 Feb 2015 23:45:15 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164382 Archived-At: This was introduced (by me applying the following patch) seven years ago. Hm... Oh, I see what the brittle logic here really is. The code (by default) calls this function: (defun hs-hide-block-at-point (&optional end comment-reg) [...] (when (hs-looking-at-block-start-p) And: (defun hs-looking-at-block-start-p () "Return non-nil if the point is at the block start." (and (looking-at hs-block-start-regexp) (save-match-data (not (nth 8 (syntax-ppss)))))) So if the match is successful, but whatever (nth 8 (syntax-ppss)) means doesn't, then we go to the end of that match data. So it kinda works... But not if `hs-hide-all-non-comment-function' is set. I'll try to rework this in a more logical fashion. commit 43956923c00921499e0582f5da4cd739bc005240 Author: S=C3=A9bastien Gross Date: Wed Apr 11 01:34:25 2012 +0200 (hs-hide-all): Don't infloop on comments that start in the middle of th= e line. =20=20=20=20 Fixes: debbugs:10496 diff --git a/lisp/progmodes/hideshow.el b/lisp/progmodes/hideshow.el --- a/lisp/progmodes/hideshow.el +++ b/lisp/progmodes/hideshow.el @@ -804,7 +804,10 @@ (if (match-beginning 1) - ;; we have found a block beginning + ;; We have found a block beginning. (progn (goto-char (match-beginning 1)) - (if hs-hide-all-non-comment-function - (funcall hs-hide-all-non-comment-function) - (hs-hide-block-at-point t))) + (unless (if hs-hide-all-non-comment-function + (funcall hs-hide-all-non-comment-function) + (hs-hide-block-at-point t)) + ;; Go to end of matched data to prevent from getting stuck + ;; with an endless loop. + (goto-char (match-end 0)))) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no