From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36886: 26.2; (global-eldoc-mode -1) should disable eldoc completely Date: Sun, 04 Aug 2019 10:34:38 -0400 Message-ID: <87a7cproch.fsf@gmail.com> References: <87h8719nzl.fsf@example.com> <83imrggjmo.fsf@gnu.org> <8736ijap0e.fsf@example.com> <87d0hn23mm.fsf@tcd.ie> <83mugrg4kv.fsf@gnu.org> <87k1bvzovi.fsf@tcd.ie> <83ftmjfxq7.fsf@gnu.org> <87k1btsr78.fsf@gmail.com> <87ftmhs70z.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238476"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: 36886@debbugs.gnu.org, sanelz@gmail.com To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 16:35:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huHbP-000zwG-ED for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 16:35:15 +0200 Original-Received: from localhost ([::1]:44748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huHbN-0004z6-Re for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 10:35:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57888) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huHbG-0004ys-Fe for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 10:35:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huHbF-0006xR-8T for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 10:35:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53487) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huHbC-0006vp-Cj for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 10:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huHbC-0004iL-80 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36886 X-GNU-PR-Package: emacs Original-Received: via spool by 36886-submit@debbugs.gnu.org id=B36886.156492928818099 (code B ref 36886); Sun, 04 Aug 2019 14:35:02 +0000 Original-Received: (at 36886) by debbugs.gnu.org; 4 Aug 2019 14:34:48 +0000 Original-Received: from localhost ([127.0.0.1]:34075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huHay-0004hq-FO for submit@debbugs.gnu.org; Sun, 04 Aug 2019 10:34:48 -0400 Original-Received: from mail-io1-f50.google.com ([209.85.166.50]:35396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huHaw-0004hc-6l for 36886@debbugs.gnu.org; Sun, 04 Aug 2019 10:34:46 -0400 Original-Received: by mail-io1-f50.google.com with SMTP id m24so162254449ioo.2 for <36886@debbugs.gnu.org>; Sun, 04 Aug 2019 07:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+MdOMh0TnYkWyB6J0LhPMb6H9KVJ1rxann8xO+hYNAk=; b=Yeq1LVtJlrilsBEAF96B4el/y9110BGPEyXNMowGlfxBYkCNbBxSqHz6UAAgHuwJx+ 7f113vtTVKw6cjvG+V6Gj8skQt8GAtbZEiYo/YGbwL1hAWuRgGhLG9JNc9w4zpAfBfKV XaUxUhmxm04HBdbDMCWFon8gfhgkDQLyqUv/OfZWbep4xU6wSSpC6+J651FQnYflbStI j5bOENFCZ0xYJdhhH+HajrwYvcDzYHdRq8tZIAQkxwLDMN13z575AdFClDNBdwYyeu+5 JGs5wMnxKd3JNj12cMFJQPjUXVRpoCX+LtDBuhxczxorO5izjGjMHIEC+wCh/bMizIpq 9O3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+MdOMh0TnYkWyB6J0LhPMb6H9KVJ1rxann8xO+hYNAk=; b=HIopkkzEBSIOwHS9wTqTbdlO1KbWnlpRC/BrrYoxtBuQf71Yb/+iDWFOd9pX9qaP5C Lq5YfcNbBETVRu61lU/1oMLpfv77HmQUILO08RsCw0CdqvO0pifnKVaBnjduuc9xl39f +LyHSTeqQrs3pok2eOT5MfecebUXCm+1Ey+FVDQdfCg/ZETiKaM6sqzP5oAQGcCCdjuf 85wjIPE+8oC2zykHKqhwjkvbSnIr7rZ6g8ujbq+Xr8yqooyqwyqWRUS9evNUWNoE6WI6 iVG+MuuegERH9Pw9XxT/DqDqHz2CBiIwMa2Oj+VtbKipnaZJA61nwO2IPAIaH3R9pfua MHhA== X-Gm-Message-State: APjAAAXS/F0R0zhqSgX8FMNBrBXSwRdJdimexf+hGlgQ4RJbDx/pd3XK rtmiGeoDuF+dZ68XU240ibE= X-Google-Smtp-Source: APXvYqz3s8uFaluvAcJG3CNGoGBo0FZNr8nk2LssBPkMFRn3ZqDNa6SzfotXYFx6p7GpTgEcwUc9Hg== X-Received: by 2002:a6b:5103:: with SMTP id f3mr648551iob.142.1564929280468; Sun, 04 Aug 2019 07:34:40 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id p3sm124065227iom.7.2019.08.04.07.34.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Aug 2019 07:34:39 -0700 (PDT) In-Reply-To: <87ftmhs70z.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 04 Aug 2019 10:51:08 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164572 Archived-At: "Basil L. Contovounesios" writes: > The problem is that minibuffer-setup-hook, which sets > eldoc-documentation-function, has not yet run at this stage, so the > minibuffer is not yet considered suitable for enabling eldoc-mode. Ah, tricky, we should probably put this in a comment somewhere. >> Subject: [PATCH] Respect global-eldoc-mode in minibuffers (Bug#36886) > Should this log entry mention bug#27202 as well? Sure, can't hurt. > shouldn't this call to eldoc-mode be bundled in the same hook function > with... >> @@ -1583,7 +1583,6 @@ read--expression >> ;; FIXME: call emacs-lisp-mode? >> (add-function :before-until (local 'eldoc-documentation-funct= ion) >> #'elisp-eldoc-documentation-function) > > ...this advice? Oh yeah, that would make sense. =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec writes: > On Sun, 04 Aug 2019 10:51:08 +0300 > Basil L. Contovounesios wrote: > >> This looks fine to me (the only alternative I can think of is creating a >> new major mode specifically for read--expression) [...] > > ...which actually sounds like it could be a real improvement in other > respects, too: many users seem to be trying to make M-: more convenient > (better completion, possibly syntax highlighting, paredit etc.); this > looks like a good way to make that easier or even unnecessary by default > (deriving from emacs-lisp-mode). I tried calling emacs-lisp-mode as the FIXME suggests, but it results in a minibuffer that can't be C-g'd out of. I guess it destroys or misses some minibuffer-specific setup? So if someone can figure out how to do that properly it does sound like a good solution.