From: Noam Postavsky <npostavs@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 36886@debbugs.gnu.org, sanelz@gmail.com
Subject: bug#36886: 26.2; (global-eldoc-mode -1) should disable eldoc completely
Date: Sun, 04 Aug 2019 10:34:38 -0400 [thread overview]
Message-ID: <87a7cproch.fsf@gmail.com> (raw)
In-Reply-To: <87ftmhs70z.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 04 Aug 2019 10:51:08 +0300")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> The problem is that minibuffer-setup-hook, which sets
> eldoc-documentation-function, has not yet run at this stage, so the
> minibuffer is not yet considered suitable for enabling eldoc-mode.
Ah, tricky, we should probably put this in a comment somewhere.
>> Subject: [PATCH] Respect global-eldoc-mode in minibuffers (Bug#36886)
> Should this log entry mention bug#27202 as well?
Sure, can't hurt.
> shouldn't this call to eldoc-mode be bundled in the same hook function
> with...
>> @@ -1583,7 +1583,6 @@ read--expression
>> ;; FIXME: call emacs-lisp-mode?
>> (add-function :before-until (local 'eldoc-documentation-function)
>> #'elisp-eldoc-documentation-function)
>
> ...this advice?
Oh yeah, that would make sense.
Štěpán Němec <stepnem@gmail.com> writes:
> On Sun, 04 Aug 2019 10:51:08 +0300
> Basil L. Contovounesios wrote:
>
>> This looks fine to me (the only alternative I can think of is creating a
>> new major mode specifically for read--expression) [...]
>
> ...which actually sounds like it could be a real improvement in other
> respects, too: many users seem to be trying to make M-: more convenient
> (better completion, possibly syntax highlighting, paredit etc.); this
> looks like a good way to make that easier or even unnecessary by default
> (deriving from emacs-lisp-mode).
I tried calling emacs-lisp-mode as the FIXME suggests, but it results in
a minibuffer that can't be C-g'd out of. I guess it destroys or misses
some minibuffer-specific setup? So if someone can figure out how to do
that properly it does sound like a good solution.
next prev parent reply other threads:[~2019-08-04 14:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 10:30 bug#36886: 26.2; (global-eldoc-mode -1) should disable eldoc completely Sanel Zukan
2019-08-01 11:37 ` Basil L. Contovounesios
2019-08-01 12:29 ` Sanel Zukan
2019-08-01 13:38 ` Dmitry Gutov
2019-08-02 6:35 ` Eli Zaretskii
2019-08-02 9:35 ` Sanel Zukan
2019-08-02 11:44 ` Basil L. Contovounesios
2019-08-02 12:00 ` Eli Zaretskii
2019-08-02 13:19 ` Basil L. Contovounesios
2019-08-02 14:28 ` Eli Zaretskii
2019-08-04 0:35 ` Noam Postavsky
2019-08-04 7:51 ` Basil L. Contovounesios
2019-08-04 9:00 ` Štěpán Němec
2019-08-04 14:34 ` Noam Postavsky [this message]
2019-08-15 0:58 ` Noam Postavsky
2019-08-15 8:31 ` Štěpán Němec
2019-08-21 0:24 ` Noam Postavsky
2019-08-04 16:27 ` Eli Zaretskii
2019-08-02 12:36 ` Sanel Zukan
2019-08-02 11:50 ` Eli Zaretskii
2019-08-02 12:51 ` Sanel Zukan
2019-08-02 14:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7cproch.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36886@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=sanelz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.