From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#16074: 24.3.50; enhancement request: Remove "pop" from command names & doc for `C-(u|x) C-SPC' Date: Sun, 25 Aug 2019 23:09:45 +0300 Organization: LINKOV.NET Message-ID: <87a7bxm12m.fsf@mail.linkov.net> References: <87y2zh94nz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="84175"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Stefan Kangas , 16074@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 22:47:06 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1zPl-000Ll1-Aj for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 22:47:05 +0200 Original-Received: from localhost ([::1]:47878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1zPj-00028b-R3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 16:47:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51443) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1zOw-0001tc-K7 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 16:46:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1zOm-00077O-0s for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 16:46:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1zOk-00075K-8c for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 16:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1zOk-0002nJ-5V for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 16:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 20:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16074 X-GNU-PR-Package: emacs Original-Received: via spool by 16074-submit@debbugs.gnu.org id=B16074.156676594210698 (code B ref 16074); Sun, 25 Aug 2019 20:46:02 +0000 Original-Received: (at 16074) by debbugs.gnu.org; 25 Aug 2019 20:45:42 +0000 Original-Received: from localhost ([127.0.0.1]:45151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1zOP-0002mU-EQ for submit@debbugs.gnu.org; Sun, 25 Aug 2019 16:45:41 -0400 Original-Received: from brown.elm.relay.mailchannels.net ([23.83.212.23]:46665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1zON-0002mM-TS for 16074@debbugs.gnu.org; Sun, 25 Aug 2019 16:45:40 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CC36C341BE5; Sun, 25 Aug 2019 20:45:38 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a15.g.dreamhost.com (100-96-4-105.trex.outbound.svc.cluster.local [100.96.4.105]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0E6CC340A50; Sun, 25 Aug 2019 20:45:38 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a15.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sun, 25 Aug 2019 20:45:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Drop-Befitting: 3ae3f228104036ba_1566765938307_4221464089 X-MC-Loop-Signature: 1566765938307:3314582875 X-MC-Ingress-Time: 1566765938306 Original-Received: from pdx1-sub0-mail-a15.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a15.g.dreamhost.com (Postfix) with ESMTP id C9D07831F8; Sun, 25 Aug 2019 13:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=pRKhv0PhNNX5l7roZQmxmyW1P0s=; b= bDeNFRAZ4tPl0hPTaLfJhB/fok1KBNvPPUVs9fKt+HTLr6UKnqg3MJ129vzfWN22 LR+OKAQTiRuNn3en/6d/Xq7atnO2dhyRlGVDNqnQNjBBr1+Lp/AJXXiMfJV2Le0V zLu9ZbOZnJcUaRArPKclUw9HsYbfpG+hD3pKsYoogXA= Original-Received: from mail.jurta.org (m91-129-109-163.cust.tele2.ee [91.129.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a15.g.dreamhost.com (Postfix) with ESMTPSA id 983A4831F6; Sun, 25 Aug 2019 13:45:28 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a15 In-Reply-To: (Drew Adams's message of "Sun, 25 Aug 2019 09:14:55 -0700 (PDT)") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudehvddgudehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledrudeifeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrdduieefpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughrvgifrdgruggrmhhssehorhgrtghlvgdrtghomhenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165856 Archived-At: >> >> Yes, renaming here seems like a good idea. >> > >> > How about the attached patch? >> >> I think that looks like the correct solution. > > It doesn't address the problem for the `mark-ring', > does it? My impression was that it addresses it > only for `global-mark-ring'. The local `mark-ring' > is used much more often than the `global-mark-ring', > and its doc is probably accessed much more often. > > For example - > > This part of `C-h k C-SPC' is wrong: > > With prefix argument (e.g., C-u C-SPC), jump to the mark, > and set the mark from position popped off the local mark > ^^^^^^^^^^ > ring (this does not affect the global mark ring). > ... > > If 'set-mark-command-repeat-pop' is non-nil, repeating > the C-SPC command with no prefix argument pops the next > position off the local (or global) mark ring and jumps there. > > With C-u C-u as prefix argument, unconditionally set > mark where point is, even if 'set-mark-command-repeat-pop' > is non-nil. > > And the doc & name of option `set-mark-command-repeat-pop' > are wrong (plus, the line lengths are screwy): > > Non-nil means repeating C-SPC after popping mark > pops it again. > That means that C-u C-SPC C-SPC > will pop the mark twice, and > C-u C-SPC C-SPC C-SPC > will pop the mark three times. > > And the doc & name of function `pop-to-mark-command' > are wrong: > > Jump to mark, and pop a new position for mark off the ring. > > A position is NOT popped off the ring. That's what's > wrong with all of these. Likewise, the doc in the > manuals. > > The enhancement request is to fix this wrong > terminology wrt BOTH `global-mark-ring' and > `mark-ring'. And `yank' doesn't yank, and `kill' doesn't kill literally. What is the most important is that docstrings should describe the behavior in all details. The name is more a matter of taste.