From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37916: GNUS: wrong item selected in gnus-thread-hide-subtree customization Date: Fri, 25 Oct 2019 12:39:56 +0200 Message-ID: <87a79pds77.fsf@gnus.org> References: <87mudp9u1k.fsf@osv.gnss.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60314"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37916@debbugs.gnu.org To: Sergey Organov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 25 12:42:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNx2q-000FZa-TJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Oct 2019 12:42:13 +0200 Original-Received: from localhost ([::1]:58446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNx2p-0005RV-Em for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Oct 2019 06:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37821) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNx1m-0002H8-6h for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 06:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNx1j-0001Ut-J1 for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 06:41:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56772) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNx1h-0001TV-RX for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 06:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNx1h-00050G-OC for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 06:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Oct 2019 10:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37916 X-GNU-PR-Package: emacs Original-Received: via spool by 37916-submit@debbugs.gnu.org id=B37916.157200000519140 (code B ref 37916); Fri, 25 Oct 2019 10:41:01 +0000 Original-Received: (at 37916) by debbugs.gnu.org; 25 Oct 2019 10:40:05 +0000 Original-Received: from localhost ([127.0.0.1]:37357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNx0n-0004yd-2t for submit@debbugs.gnu.org; Fri, 25 Oct 2019 06:40:05 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNx0i-0004y4-Sr for 37916@debbugs.gnu.org; Fri, 25 Oct 2019 06:40:03 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNx0e-0007mG-OG; Fri, 25 Oct 2019 12:39:59 +0200 In-Reply-To: <87mudp9u1k.fsf@osv.gnss.ru> (Sergey Organov's message of "Fri, 25 Oct 2019 10:13:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170157 Archived-At: Sergey Organov writes: > The "Non-nil" defcustom item is selected in customization buffer when > actual value of the gnus-thread-hide-subtree is 'nil. Hm... 'nil and nil are the same. [...] > - :type '(radio (sexp :format "Non-nil\n" > + :type '(radio (const nil) > + (sexp :format "Non-nil\n" > :match (lambda (widget value) > (not (or (consp value) (functionp value)))) > :value t) > - (const nil) Oh, I see. I think the problem is that that :match is just wrong. Changing the order of the values (as this patch does) also makes the problem go away, but I think the right fix here is to fix the :match. So I've installed the following patch instead: diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index b5d744843f..f21bc7584e 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -334,7 +334,7 @@ gnus-thread-hide-subtree :group 'gnus-thread :type '(radio (sexp :format "Non-nil\n" :match (lambda (widget value) - (not (or (consp value) (functionp value)))) + (and value (not (functionp value)))) :value t) (const nil) (sexp :tag "Predicate specifier"))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no