From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master e21a1da: Allow completion styles to adjust completion metadata Date: Sun, 27 Oct 2019 12:20:08 +0000 Message-ID: <87a79m9y87.fsf@gmail.com> References: <20191026132223.21074.15227@vcs0.savannah.gnu.org> <20191026132224.B05E120664@vcs0.savannah.gnu.org> <87imobxiyu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188641"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 13:21:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOhXt-000mu4-48 for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 13:21:21 +0100 Original-Received: from localhost ([::1]:45060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOhXr-0006yN-78 for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 08:21:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53454) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOhWq-0006yC-Vo for emacs-devel@gnu.org; Sun, 27 Oct 2019 08:20:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOhWp-0004XY-Us for emacs-devel@gnu.org; Sun, 27 Oct 2019 08:20:16 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:33950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOhWp-0004XK-NL for emacs-devel@gnu.org; Sun, 27 Oct 2019 08:20:15 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id v3so7552058wmh.1 for ; Sun, 27 Oct 2019 05:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=GubUpl0sMX1gSg3Dc99AEQQxsvgi0TRWYDZDfOCIEnU=; b=mC2uHIHGYU/mJIY3AaVg2PqH0JBVIjtSAz+VD41m9ief1uzXUccWFGh9FeL84w7V2B Wq3qnufRtO7sfhiMR6kKCYsQE20BaZFyfs/RzEAzo6QXNWeV6WbTfGb+uRmVAszoIZeN 9m31VBhQuyE+Y3KJGFZoaVg+dEZEurhQPcQ5s5btOJm+zIR9YDwgBqfFF6bzIIzwskQH 9XZIj8ahocZAzUZ+jY3KFVRCGF8j52Mr+vMVpwhxt2zo8/TofHeCn6J93bm2HPIDP34C TXeDdd5rEpSq0Q/iQyD4pRG5dUwPoc9sAkzbejlbl1CmzVb8ZHN/LK+WBCNyfoAba350 //pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=GubUpl0sMX1gSg3Dc99AEQQxsvgi0TRWYDZDfOCIEnU=; b=hmOn0Lw2KYAThH91TNVM59BrXN+4Z3B9Pg8kmtvOEky8nFmz1ldANnbiMOHpWQi44p N19zQEBBVfGHFY5mHVMMVSFVqhKWQrpIacQjI6I270i/6s54+LFnUnVODqGmDmEF6zEX 00T/4+x2b0WA+v5h+TL3OnSN+9QcLvMqfIouFEdhZjQQBAe3b62KCksCosFRvRnY9Spn sKXRx5f/mqbEiQdAeMZraIz/CGIcoD+tqFpeH7+dRA/9HLn1fBX48fS10ZtHQGd3vR+m 8pZwLrGvv2/0orTc7dFvO5C012PyJIrzX7fV27A4/Wsqq/Q2BuuUWQe1od2QCM0zGZo5 GP+A== X-Gm-Message-State: APjAAAUkXi7RiwJp4lIcBkWyG92rukoLcfw5UoUrjz3ktObFErJgG7ch vzBTUOWr/AHjhpR4GGUzNZ1tyoQlDTo= X-Google-Smtp-Source: APXvYqzDo7LQxfG9Lj1yQa8kNhTYX3s3PK+vJ0DMArCxjk8MubPnCpPFmIfWYHK+oVonoovRZ8uhtA== X-Received: by 2002:a1c:5641:: with SMTP id k62mr11552857wmb.97.1572178813769; Sun, 27 Oct 2019 05:20:13 -0700 (PDT) Original-Received: from lolita.yourcompany.com ([2001:818:d820:9500:1ebb:afd8:ab26:f0f6]) by smtp.gmail.com with ESMTPSA id d2sm12703072wmd.2.2019.10.27.05.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2019 05:20:11 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sat, 26 Oct 2019 22:04:29 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241516 Archived-At: Stefan Monnier writes: >> I assumed it is. Do you know that it isn't? nil? > I think it can be nil, yes. I just discovered this in the beginning of completion--nth-completion. Doesn't it quash your concerns? (defun completion--nth-completion (n string table pred point metadata) "Call the Nth method of completion styles." (unless metadata (setq metadata (completion-metadata (substring string 0 point) table pred))) =20=20=20=20=20=20=20=20=20=20 >>> BTW, I just changed the bootstrap so that cl-defgeneric should now be >>> usable in minibuffer.el. >> Out of energy right now. Be my guest, the switch to cl-generic is >> trivally outlined in the now-revert commit. > I was about to do that when I saw the issue with `metadata` being > potentially nil. See above. Also, I don't see the change to the bootstrap. Maybe you forgot to push? Jo=C3=A3o