all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master e21a1da: Allow completion styles to adjust completion metadata
Date: Sun, 27 Oct 2019 12:20:08 +0000	[thread overview]
Message-ID: <87a79m9y87.fsf@gmail.com> (raw)
In-Reply-To: <jwvr22z7xp6.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 26 Oct 2019 22:04:29 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I assumed it is.  Do you know that it isn't?  nil?
> I think it can be nil, yes.

I just discovered this in the beginning of completion--nth-completion.
Doesn't it quash your concerns?

(defun completion--nth-completion (n string table pred point metadata)
  "Call the Nth method of completion styles."
  (unless metadata
    (setq metadata
          (completion-metadata (substring string 0 point) table pred)))

          
>>> BTW, I just changed the bootstrap so that cl-defgeneric should now be
>>> usable in minibuffer.el.
>> Out of energy right now.  Be my guest, the switch to cl-generic is
>> trivally outlined in the now-revert commit.
> I was about to do that when I saw the issue with `metadata` being
> potentially nil.

See above.  Also, I don't see the change to the bootstrap. Maybe you
forgot to push?

João



      reply	other threads:[~2019-10-27 12:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191026132223.21074.15227@vcs0.savannah.gnu.org>
     [not found] ` <20191026132224.B05E120664@vcs0.savannah.gnu.org>
2019-10-26 20:52   ` master e21a1da: Allow completion styles to adjust completion metadata Stefan Monnier
2019-10-26 22:03     ` João Távora
2019-10-27  2:04       ` Stefan Monnier
2019-10-27 12:20         ` João Távora [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a79m9y87.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.