From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Tue, 17 Dec 2019 00:29:32 +0200 Organization: LINKOV.NET Message-ID: <87a77rgajf.fsf@mail.linkov.net> References: <8736e3vve8.fsf@gmx.net> <837e3ckbem.fsf@gnu.org> <871rtjn0kt.fsf@mail.linkov.net> <83lfrrigj8.fsf@gnu.org> <87eexiqps5.fsf@mail.linkov.net> <83lfrphp94.fsf@gnu.org> <87wob7g2jk.fsf@mail.linkov.net> <83k177ebs0.fsf@gnu.org> <87muc27prn.fsf@mail.linkov.net> <83tv6acgq5.fsf@gnu.org> <87eexdoygh.fsf@mail.linkov.net> <83tv68c0nb.fsf@gnu.org> <87d0cubfxx.fsf@mail.linkov.net> <83a77y9k35.fsf@gnu.org> <87eex9jf14.fsf@mail.linkov.net> <83d0cs8uw8.fsf@gnu.org> <87a77uh5a5.fsf@mail.linkov.net> <83r21561qd.fsf@gnu.org> <878snd2liu.fsf@mail.linkov.net> <8336dk5k1p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="159166"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 38457@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 16 23:53:51 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1igzFO-000fGt-8e for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Dec 2019 23:53:50 +0100 Original-Received: from localhost ([::1]:33026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igzFN-0003sx-0X for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Dec 2019 17:53:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33168) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igzEi-0002yF-GV for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2019 17:53:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igzEg-0002lC-W1 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2019 17:53:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34515) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igzEg-0002kP-Sf for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2019 17:53:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igzEf-00070q-S3 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2019 17:53:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2019 22:53:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.157653678126886 (code B ref 38457); Mon, 16 Dec 2019 22:53:05 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 16 Dec 2019 22:53:01 +0000 Original-Received: from localhost ([127.0.0.1]:40478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igzEb-0006zW-4C for submit@debbugs.gnu.org; Mon, 16 Dec 2019 17:53:01 -0500 Original-Received: from blue.elm.relay.mailchannels.net ([23.83.212.20]:56344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igzEZ-0006zL-RT for 38457@debbugs.gnu.org; Mon, 16 Dec 2019 17:53:00 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B24A834089A; Mon, 16 Dec 2019 22:52:58 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a19.g.dreamhost.com (100-96-15-224.trex.outbound.svc.cluster.local [100.96.15.224]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 20BC434165C; Mon, 16 Dec 2019 22:52:58 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a19.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 16 Dec 2019 22:52:58 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Bubble-Minister: 0de51e224545341a_1576536778358_2496516364 X-MC-Loop-Signature: 1576536778358:3717511189 X-MC-Ingress-Time: 1576536778357 Original-Received: from pdx1-sub0-mail-a19.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTP id 8314A7F028; Mon, 16 Dec 2019 14:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=FtRgODGfGn5aD8H56RiNNHowLaE=; b= Rl26FTetDk5tLIYa1vl8mYLhCSwHAtwaKQ/IW2hAycG38Fexcg3fjUMKZvU4R3Vc 06PhA0uYoOL89UwMiQpfvpkGhVjQCR1yxTKmuVJibuWMo556+dyKQ17WVGhkVYF9 jHZnkNgE9V1u0RXEBKiAmq+T5bbziZaLK0vFBYeV4c4= Original-Received: from mail.jurta.org (m91-129-107-186.cust.tele2.ee [91.129.107.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTPSA id E6F217EFC4; Mon, 16 Dec 2019 14:52:53 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a19 In-Reply-To: <8336dk5k1p.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Dec 2019 18:09:38 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvddtiedgtdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddukeeinecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrudekiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpeef X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173454 Archived-At: > However, I hoped we could have at least part of what you did in Emacs > 27, and not lose all of it. We could install a function like > 'minimess-minibuffer-message', and make one of the subroutines of > 'message' call it under the right conditions. The most low-level functions where it could be called from are 'set_message' and 'clear_message'. > Then the message which > 'minimess-minibuffer-message' displays could be removed by a timer if > the new timeout defcustom is a number, and if that defcustom is not a > number (which will be the default), the message stays and sit-for is > not called. This is almost how 'minimess-minibuffer-message' was implemented, with one difference: defcustom is a number by default. Why shouldn't it be a number by default? How the user would be able to remove an old message when the function doesn't call sit-for? > Do you see any danger with the above? If not, can I persuade you do > install such a change? I'm not sure if now is the right time to implement this feature. But if implementation would be straightforward and if you see no problems then why not. >> (defun minimess-message (orig-fun format-string &rest args) >> (if (and >> ;; When `inhibit-message' is non-nil, the intention was to just >> ;; log the message to the *Messages* buffer using `message'. >> (null inhibit-message) >> (window-live-p (active-minibuffer-window)) >> (window-live-p (old-selected-window)) >> (bufferp (window-buffer (old-selected-window))) >> (minibufferp (window-buffer (old-selected-window)))) > > Btw, can you explain why every part of this condition is needed? IOW, > why isn't just the below enough? > > (window-live-p (active-minibuffer-window)) > > (I do understand the reason for the test of inhibit-message). > > Maybe the other conditions need a comment to explain them? Unfortunately, I forgot why they were added, i.e. during testing I added them one by one when noticed that some cases don't work. Now I'll try to reproduce these cases by removing conditions and checking which part doesn't work.