From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters Date: Fri, 20 Dec 2019 21:34:07 +0100 Message-ID: <87a77mn3cw.fsf@gmail.com> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> <87imsinbmr.fsf_-_@gmail.com> <87o8yoign9.fsf_-_@gmail.com> <87a77qhzvm.fsf@gmail.com> <87v9qcf00w.fsf@mail.linkov.net> <837e2r1iph.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="231322"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: michael_heerdegen@web.de, 35564@debbugs.gnu.org, npostavs@gmail.com, Juri Linkov , monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 20 21:35:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iiOzQ-000xtW-Dx for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Dec 2019 21:35:12 +0100 Original-Received: from localhost ([::1]:33188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiOzO-00028o-Pk for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Dec 2019 15:35:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57828) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiOzH-00028g-80 for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2019 15:35:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiOzG-0006EE-0T for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2019 15:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41311) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iiOzF-0006D7-Qd for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2019 15:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iiOzF-0007jf-NV for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2019 15:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2019 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.157687405829678 (code B ref 35564); Fri, 20 Dec 2019 20:35:01 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 20 Dec 2019 20:34:18 +0000 Original-Received: from localhost ([127.0.0.1]:47284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiOyX-0007ib-VM for submit@debbugs.gnu.org; Fri, 20 Dec 2019 15:34:18 -0500 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:37740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiOyV-0007iN-HJ for 35564@debbugs.gnu.org; Fri, 20 Dec 2019 15:34:16 -0500 Original-Received: by mail-wr1-f47.google.com with SMTP id w15so10664515wru.4 for <35564@debbugs.gnu.org>; Fri, 20 Dec 2019 12:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=T9afDy9KYFU1Wbni5RbxZP6WXGA02fPS8Mtfdr0d3+Y=; b=IludgO9zb4OjZk+a0CnoCIUhUV9a+GpdAzHtSzdNdPHCQ/PRkYC6f4sqwtNtdqj1Rb fXe/D+jjcpo/5uXpwOyb152wPdcHUL2oDhZ3hx+Iy3ZvDCpTHRymKrguvmlbGE2Mxq1p U9ld/qRnSbe9358gdR2YUgdT9URHmI7kHssrqm7b9tdsx49ULfz0OdrRHHIksib965n0 a7IlsLED3wNoMwXLplkpiqeG6ltipfmRxqChC/AsA/1RULloDv8/X7MJYdSGn2WvSXj/ WsmEcPDDpsX9VNb0GyTqq3BxLbYm/+DDhj829Xxwc9Ejm77QZWUN2w21mxmGrQtBG5iH OoFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=T9afDy9KYFU1Wbni5RbxZP6WXGA02fPS8Mtfdr0d3+Y=; b=r9GerflX4+DaTpNhTyKW9XYq/7q8m2s2gsxuIli+5iodZ05gX16OwGvUPodpgTVtux gIKKi6/ga6SRysezK1nFozWKnvYr3o/ntwNN7jLWIpZvUd0sA82aZ3cpsbc9RmzWXqJN QawRNBMovbJqt379zUnyvz4yltCxiw9MjZkLx2Rl1C2Md01IDvI8p+wTZUdC3FlErfXX mqSZVceLq+5ifcVV6cvq8FykiId9PuY0N+zxkWF4fnCBE4l+dNNCi6FVlEfQBLjY+eGY JmM60kZV/OO0cUXuyoQxljNs9olkpQTtd+zofMHSwoP7eYqe/hGeC/WHobQLrw+9BZ7H bA3w== X-Gm-Message-State: APjAAAU0pIPQiHce0O+JlXUsUNIk51pEOFHl/hhp9vDWyKotqqg6O0qT 04yW23kcYJ3Iztd/OGPRAHk= X-Google-Smtp-Source: APXvYqyyaBCG0vARV4dqbnUxh4+KKrNbSMZL3F3NN2FjAYwOQc00Y9gQRq9hBucpKYW5NAKOyCgMDA== X-Received: by 2002:adf:f10a:: with SMTP id r10mr17018572wro.202.1576874049687; Fri, 20 Dec 2019 12:34:09 -0800 (PST) Original-Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id z187sm11071128wme.16.2019.12.20.12.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2019 12:34:08 -0800 (PST) In-Reply-To: <837e2r1iph.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Dec 2019 10:53:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173585 Archived-At: Eli Zaretskii writes: > I'll let other participants of this long discussion to chime in, but > in general I'd like to postpone this till after the emacs-27 branch is > cut (hopefully, very soon), as this constitutes a significant behavior > change, AFAIU. I won't insist too much for this to land on Emacs 27, since a) the "bug" it fixes is fairly minor, b) I know everyone's plate is quite full, and c) I mostly use the master branch anyway, so it's not like I'll have to wait to benefit. For the record though, I'll point out a few reasons why I think it should be "safe" to include this in the upcoming release: - the changes are fairly limited in scope: they only affect dired-do-shell-command; - in the simplest case, the UI change is minor: it turns this message: > Confirm--do you mean to use =E2=80=98?=E2=80=99 as a wildcard? (y or n) into this one: > 1 occurrence of =E2=80=98?=E2=80=99 will not be substituted. Proceed? = (y, n, ?) ? (or, with read-multiple-choice:) > 1 occurrence of =E2=80=98?=E2=80=99 will not be substituted. Proceed? = (_y_es, _n_o, toggle _d_etails, _?_):=20 - the "riskiest" refactoring changes have been handled by Noam[1] and are partially covered by unit tests. Most of the lengthy discussion was about finding the right balance between message correctness and verbosity; hopefully the eventual behavior change is not that significant. > Thanks. Thank you for your time. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?att=3D2;filename=3D0002-Dedup= -dired-aux-isolated-char-searching-Bug-35564.patch;bug=3D35564;msg=3D202