all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* policy regarding DEFUNs in subr-x.el
@ 2020-03-22 15:46 Štěpán Němec
  2020-03-22 17:12 ` Eli Zaretskii
  0 siblings, 1 reply; 10+ messages in thread
From: Štěpán Němec @ 2020-03-22 15:46 UTC (permalink / raw)
  To: emacs-devel

When fixing bug#39980 [1], it seemed best to me to move a string utility
function to subr-x. Given the file's commentary (notably "NB If you want
to use this library, it's almost always correct to use:
(eval-when-compile (require 'subr-x))") and the fact that with a single
outlier of `replace-region-contents', everything in that file is either
inline functions or macros, I turned the added function into defsubst,
which seems to have raised Lars's eyebrows, and Eli's, probably, too.

Now, it does seem sensible for the function to be a normal, not inline,
function, but what about the commentary and all the other defsubsts,
including the other string utilities?

If the no-defun policy should be changed, or if I was mistaken in
believing there was one to begin with, shouldn't the commentary
recommending compile-time usage be removed, and at least some of the
other defsubsts turned into defuns, too?

Any clarification would be much appreciated.

[1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-03/msg00643.html

-- 
Štěpán



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-03-28 15:45 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-22 15:46 policy regarding DEFUNs in subr-x.el Štěpán Němec
2020-03-22 17:12 ` Eli Zaretskii
2020-03-22 20:38   ` Tassilo Horn
2020-03-28 14:20   ` Štěpán Němec
2020-03-28 14:35     ` Eli Zaretskii
2020-03-28 14:47       ` Štěpán Němec
2020-03-28 14:50         ` Štěpán Němec
2020-03-28 15:04         ` Eli Zaretskii
2020-03-28 15:31           ` Štěpán Němec
2020-03-28 15:45             ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.