From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Date: Tue, 31 Mar 2020 01:40:04 +0300 Organization: LINKOV.NET Message-ID: <87a73xsbzv.fsf@mail.linkov.net> References: <8736avy640.fsf@mail.linkov.net> <76e52ade-bb44-427a-0910-3fe3cf65bf6d@yandex.ru> <87a751uonw.fsf@mail.linkov.net> <9bab3a53-ec31-3300-132f-dc1e17ee0c53@yandex.ru> <875zfd9lzm.fsf@mail.linkov.net> <87mu8mieve.fsf@mail.linkov.net> <87k13pkxdl.fsf@mail.linkov.net> <207d4e30-aa59-b8eb-c39a-0957757f39eb@yandex.ru> <875zf6cy3w.fsf@mail.linkov.net> <9c39f788-29f1-5a68-c8f3-a4b08ae9ea3b@yandex.ru> <87lfo1dvcf.fsf@mail.linkov.net> <44cda45a-db93-f2c1-626d-9ace68cd6fd1@yandex.ru> <87y2rpqt28.fsf@mail.linkov.net> <874kuci4tx.fsf@mail.linkov.net> <786821a9-ceab-bbe8-b02a-69e77ddde426@yandex.ru> <878sjkjb8p.fsf@mail.linkov.net> <7d73cdd2-6af1-270c-1929-1bf618c304db@yandex.ru> <87tv26pzji.fsf@mail.linkov.net> <979c0191-48ce-f13f-361e-a03b3ff393a6@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="130354"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 34949@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 31 00:54:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJ3IM-000Xn0-Fi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Mar 2020 00:54:14 +0200 Original-Received: from localhost ([::1]:57858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJ3IL-0001Ds-Hh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Mar 2020 18:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55528) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJ3IC-0001CF-JK for bug-gnu-emacs@gnu.org; Mon, 30 Mar 2020 18:54:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJ3IA-0002fo-EN for bug-gnu-emacs@gnu.org; Mon, 30 Mar 2020 18:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51929) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJ3IA-0002f8-9h for bug-gnu-emacs@gnu.org; Mon, 30 Mar 2020 18:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJ3IA-0002u7-6o for bug-gnu-emacs@gnu.org; Mon, 30 Mar 2020 18:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Mar 2020 22:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34949-submit@debbugs.gnu.org id=B34949.158560883911138 (code B ref 34949); Mon, 30 Mar 2020 22:54:02 +0000 Original-Received: (at 34949) by debbugs.gnu.org; 30 Mar 2020 22:53:59 +0000 Original-Received: from localhost ([127.0.0.1]:35239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ3I6-0002ta-PW for submit@debbugs.gnu.org; Mon, 30 Mar 2020 18:53:59 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ3I3-0002su-KT for 34949@debbugs.gnu.org; Mon, 30 Mar 2020 18:53:56 -0400 X-Originating-IP: 91.129.102.97 Original-Received: from mail.gandi.net (m91-129-102-97.cust.tele2.ee [91.129.102.97]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5A5CEFF802; Mon, 30 Mar 2020 22:53:47 +0000 (UTC) In-Reply-To: <979c0191-48ce-f13f-361e-a03b3ff393a6@yandex.ru> (Dmitry Gutov's message of "Mon, 30 Mar 2020 23:01:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177891 Archived-At: --=-=-= Content-Type: text/plain >> Actually, marking all files with 'C-u M' is not useless. There are >> other VC commands that make sense to run on all marked files, e.g. >> search in all files marked by 'C-u M', query-replace, delete, etc. > > Hmm, you might be right. If we're sure that people do take advantage of > that, let's keep it. > > We could tweak it a little, though. Like: > > M -> mark all files in the same status > C-u M -> mark all registered files > C-u C-u M -> mark all files in the vc-dir buffer Too messy to overload the binding with long prefixes with different meanings. > Or bind vc-dir-mark-registered to a new char indeed, e.g. 'r'. Better to bind to the mnemonic key '* r' as in this patch. I still don't understand why Drew insists on 100% compatibility between Dired and VC-Dir - they already diverged: 'M' in Dired doesn't mark files like it does in VC-Dir. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-dir-mark-registered-files.patch diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index ab5943917b..0c9e656add 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -147,6 +147,12 @@ vc-dir-menu-map '(menu-item "Unmark Previous " vc-dir-unmark-file-up :help "Move to the previous line and unmark the file")) + (define-key map [mark-unregistered] + '(menu-item "Mark Unregistered" vc-dir-mark-unregistered-files + :help "Mark all files in the unregistered state")) + (define-key map [mark-registered] + '(menu-item "Mark Registered" vc-dir-mark-registered-files + :help "Mark all files in the state edited, added or removed")) (define-key map [mark-all] '(menu-item "Mark All" vc-dir-mark-all-files :help "Mark all files that are in the same state as the current file\ @@ -310,6 +316,10 @@ vc-dir-mode-map (define-key branch-map "l" 'vc-print-branch-log) (define-key branch-map "s" 'vc-retrieve-tag)) + (let ((mark-map (make-sparse-keymap))) + (define-key map "*" mark-map) + (define-key mark-map "r" 'vc-dir-mark-registered-files)) + ;; Hook up the menu. (define-key map [menu-bar vc-dir-mode] `(menu-item @@ -707,6 +717,27 @@ vc-dir-mark-files t)) vc-ewoc)) +(defun vc-dir-mark-state-files (states) + "Mark files that are in the state specified by the list in STATES." + (unless (listp states) + (setq states (list states))) + (ewoc-map + (lambda (filearg) + (when (memq (vc-dir-fileinfo->state filearg) states) + (setf (vc-dir-fileinfo->marked filearg) t) + t)) + vc-ewoc)) + +(defun vc-dir-mark-registered-files () + "Mark files that are in one of registered state: edited, added or removed." + (interactive) + (vc-dir-mark-state-files '(edited added removed))) + +(defun vc-dir-mark-unregistered-files () + "Mark files that are in unregistered state." + (interactive) + (vc-dir-mark-state-files 'unregistered)) + (defun vc-dir-unmark-file () ;; Unmark the current file and move to the next line. (let* ((crt (ewoc-locate vc-ewoc)) --=-=-=--