From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: philip@warpmail.net (Philip K.) Newsgroups: gmane.emacs.bugs Subject: bug#40355: [PATCH] Implement caching for libravatar lookup Date: Wed, 01 Apr 2020 12:34:34 +0200 Message-ID: <87a73vpk91.fsf@bulbul> References: <20200331180336.2999-1-philip@warpmail.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="121466"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40355@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 01 12:35:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJaiG-000VS6-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Apr 2020 12:35:12 +0200 Original-Received: from localhost ([::1]:57718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJaiE-0006ha-Vf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Apr 2020 06:35:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJai7-0006gi-5N for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 06:35:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJai6-0006jN-2k for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 06:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54168) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJai5-0006im-Qj for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 06:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJai5-0006Hq-Nw for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 06:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: philip@warpmail.net (Philip K.) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Apr 2020 10:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40355-submit@debbugs.gnu.org id=B40355.158573729124145 (code B ref 40355); Wed, 01 Apr 2020 10:35:01 +0000 Original-Received: (at 40355) by debbugs.gnu.org; 1 Apr 2020 10:34:51 +0000 Original-Received: from localhost ([127.0.0.1]:37481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJahp-0006HH-OV for submit@debbugs.gnu.org; Wed, 01 Apr 2020 06:34:51 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:42387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJahn-0006H3-ID for 40355@debbugs.gnu.org; Wed, 01 Apr 2020 06:34:44 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 8558861B; Wed, 1 Apr 2020 06:34:37 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 01 Apr 2020 06:34:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type:content-transfer-encoding; s=fm3; bh=iLTZ3pXKiLRoO g6uxVIHXLVjQIm/cPtliZaHnwrxjfA=; b=DzE7nNpfixiaX9yfkQd2UGEtuORr2 2yVPEUavDnwBchIkCzxglaMlRCDmzOsdemU9sdH8owWS/9kwVqgNydkRzhHCef76 DTyxJQx/oX+Zrnffb7yMS/ORqPbHadnwoeduK5ClxZrfuc4E83aa6ylJ0TsQdvK3 /VWF4n322w0XAZ84B9qN1DpnUQsMRkgF1FaPpDvNs+LsQ7UDRqCKn6xHII3ObiAg WV1Qy4BY5EV2sh82mCxBhyjMIh8ME2AxZDvrFWLXUYJdO6Aw/Bmw48M2P6CfYyc4 Gp7tajGCm/21ZlLeis1VbVP0hPEqg2R00Of+u8kTxtpPQ+lWeFOXseaxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=iLTZ3pXKiLRoOg6uxVIHXLVjQIm/cPtliZaHnwrxjfA=; b=IWw5y1FW 4II6EbqBK+nlecvCrPVsktWLqu7qhGXNLja9tMt6zBOlrTELw1FyH74nwX8/5TEe P2gM5VZLs7HDCFFepOYkyBCYgNPTv0o9/yEJYC6SvYJJFETn+mmR4I/QjRFFSUAT VDWnXIfJDGmAtPKUFcjHIKhA8dG4KQeejYE65UkpmAbCyxEDBpiU7BDdoH5E7oVR hVNBaegR2SR54/nQim4C9x7N+Fhn9IsDeyqCijF5TJ3VuYcWiYrgeV1YXv+QuGaI pKKavO9VAbHKsQUxofF/HbdUgHC8HBQpbjhquVOBQlbzvZRePfzXfcmzJHheCr5C YQXIs+oBrq/XTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtddvgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujgffkfggtgfgsehtqhertddttdejnecuhfhrohhmpehphhhilhhiphes figrrhhpmhgrihhlrdhnvghtucdlrfhhihhlihhpucfmrddmnecuffhomhgrihhnpegrth htrdhnvghtpdhfrggtvggsohhokhdrtghomhdpghhoohhglhgvmhgrihhlrdgtohhmpdgt ohhmmhgvrdgtohhmpdhmrghilhdrtghomhdpmhhsnhdrtghomhdpshgstghglhhosggrlh drnhgvthenucfkphepjeelrddvudelrdduleelrddufedtnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilh drnhgvth X-ME-Proxy: Original-Received: from localhost (p4fdbc782.dip0.t-ipconnect.de [79.219.199.130]) by mail.messagingengine.com (Postfix) with ESMTPA id A4014328005A; Wed, 1 Apr 2020 06:34:36 -0400 (EDT) In-Reply-To: (message from Robert Pluim on Wed, 01 Apr 2020 09:27:00 +0200) Autocrypt: addr=philip@warpmail.net; prefer-encrypt=mutual; keydata= mDMEXmoX2BYJKwYBBAHaRw8BAQdA/YuGV2Dy6UZtMk+KfA7Nnlj38k22KQ/+sXVa2ttGaHm0O1Bo aWxpcCBLLiAoZ2VuZXJhdGVkIGJ5IGF1dG9jcnlwdC5lbCkgPHBoaWxpcEB3YXJwbWFpbC5uZXQ+ iJAEExYIADgWIQSx6XCgW+bhLMR4DmPClWiPoyRe6AUCXmoX2AIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRDClWiPoyRe6IDNAP0eOlYoYIGVcCinuewkEb762T6lqA2hIHcNeRyX8LyQ8gEA krv4pIlZNLF+nBvaCtKvCPZF9428X50CvNvRHCNqgwe4OAReahfYEgorBgEEAZdVAQUBAQdACM09 XXce+t9YpOLbLdESh5g4RTY/0Zys7U1FapIZLA4DAQgHiHgEGBYIACAWIQSx6XCgW+bhLMR4DmPC lWiPoyRe6AUCXmoX2AIbDAAKCRDClWiPoyRe6LYcAQDn15KGn/E9MqloWN4mBJ7/tepYIk2IxrkZ imC531HsIAD+LKQYjorQosVe1oym0VZjmgKsem1kJZHG2tY601I+QwM= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177939 Archived-At: Robert Pluim writes: > Philip> I added it because I was considering defining gravatar-librav= atar-cache > Philip> as > > Philip> (let ((cache (make-hash-table :test 'equal))) > Philip> (dolist (domain '("aol.com" "att.net" "comcast.net" "fa= cebook.com" > Philip> "gmail.com" "gmx.com" "googlemail.com= " "google.com" > Philip> "hotmail.com" "hotmail.co.uk" "mac.co= m" "me.com" > Philip> "mail.com" "msn.com" "live.com" "sbcg= lobal.net" > Philip> ;; ... > Philip> )) > Philip> (gravatar--service-libravatar (concat "ignored@" doma= in) cache)) > Philip> cache) > > Philip> with a few popular domains. The only issue is that evaluating= it takes > Philip> forever. > > Perhaps that=CA=BCs a sign that pre-population is not needed :-) It's not needed, but as soon as it is pre-populated the user experience becomes a lot better. But unless there's a sensible way to fix it, I'll just resubmit the patch without the optional argument :/ --=20 Philip K.