From: philip@warpmail.net (Philip K.)
To: Robert Pluim <rpluim@gmail.com>
Cc: 40355@debbugs.gnu.org
Subject: bug#40355: [PATCH] Implement caching for libravatar lookup
Date: Wed, 01 Apr 2020 12:34:34 +0200 [thread overview]
Message-ID: <87a73vpk91.fsf@bulbul> (raw)
In-Reply-To: <m2zhbvzmwr.fsf@gmail.com> (message from Robert Pluim on Wed, 01 Apr 2020 09:27:00 +0200)
Robert Pluim <rpluim@gmail.com> writes:
> Philip> I added it because I was considering defining gravatar-libravatar-cache
> Philip> as
>
> Philip> (let ((cache (make-hash-table :test 'equal)))
> Philip> (dolist (domain '("aol.com" "att.net" "comcast.net" "facebook.com"
> Philip> "gmail.com" "gmx.com" "googlemail.com" "google.com"
> Philip> "hotmail.com" "hotmail.co.uk" "mac.com" "me.com"
> Philip> "mail.com" "msn.com" "live.com" "sbcglobal.net"
> Philip> ;; ...
> Philip> ))
> Philip> (gravatar--service-libravatar (concat "ignored@" domain) cache))
> Philip> cache)
>
> Philip> with a few popular domains. The only issue is that evaluating it takes
> Philip> forever.
>
> Perhaps thatʼs a sign that pre-population is not needed :-)
It's not needed, but as soon as it is pre-populated the user experience
becomes a lot better. But unless there's a sensible way to fix it, I'll
just resubmit the patch without the optional argument :/
--
Philip K.
next prev parent reply other threads:[~2020-04-01 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 18:03 bug#40355: [PATCH] Implement caching for libravatar lookup Philip K
2020-03-31 19:58 ` Robert Pluim
2020-03-31 21:30 ` Philip K.
2020-04-01 7:27 ` Robert Pluim
2020-04-01 10:34 ` Philip K. [this message]
2020-08-08 13:03 ` Lars Ingebrigtsen
2020-08-18 14:46 ` Lars Ingebrigtsen
2020-08-24 14:09 ` Robert Pluim
2020-08-24 14:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a73vpk91.fsf@bulbul \
--to=philip@warpmail.net \
--cc=40355@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.