From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Zhu Zihao Newsgroups: gmane.emacs.devel Subject: Slot accessing issues in EIEIO Date: Wed, 06 May 2020 12:17:28 +0800 Message-ID: <87a72lhf3b.wl-all_but_last@163.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="128878"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/27.0 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 06 06:18:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWBVt-000XOk-QM for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 06:18:29 +0200 Original-Received: from localhost ([::1]:41472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWBVs-0006AK-Rh for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 00:18:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWBVQ-0005kH-T1 for emacs-devel@gnu.org; Wed, 06 May 2020 00:18:00 -0400 Original-Received: from m12-17.163.com ([220.181.12.17]:42771) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWBVL-0003DF-5r for emacs-devel@gnu.org; Wed, 06 May 2020 00:17:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:Message-ID:From:Subject:MIME-Version; bh=yQh4n m6UPq7xCwMQk9wdt1l8Y/z68mJ60X6OPCvkx5E=; b=g4IAk6z+it3RSS0j7ail6 0LdKzrFqmmNwyWeVajf/fGkwpBvnJKoQ/M8XH8PoRIbjrtk/UWSAvBRix9EyB7Q8 luG9cAilVTDFbHMJqsBQkqEC05Pvbn9oBqLwVwKMcMel/rxrcYrpELdY20ITeLWe rkksEgk3jDc49Z3AEP+ebA= Original-Received: from archlinux.163.com (unknown [14.121.132.141]) by smtp13 (Coremail) with SMTP id EcCowAAHzS5gOrJeit_JBA--.4967S2; Wed, 06 May 2020 12:17:39 +0800 (CST) X-Face: :]]%@R1{oDt0%iKgI@Kga#OZ; ogt+%OOne&J4#E*O,TIlI)yEFw--I\:3s~EV97GI$1.1!}8inmF9UgtUBB@#8>'8NWNC8qg/v*OLfQB; Z:@G3HeNf3u& ,&HpBGv%?p{bzsl'|5T";1&X X-CM-TRANSID: EcCowAAHzS5gOrJeit_JBA--.4967S2 X-Coremail-Antispam: 1Uf129KBjvJXoWruw13Wr43GF43Jr17GrW8tFb_yoW8JF1DpF 4a9ayI9r98CF1Fk34vvw4IqF1fJrs0qFZ8Cw1UKr4UZas8X3Z3AFyFyr47CFWDAws3Zw4Y qa1Fya1qy3yDCaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jpc_-UUUUU= X-Originating-IP: [14.121.132.141] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiKQUcr1Xlv6Tr8gAAst Received-SPF: pass client-ip=220.181.12.17; envelope-from=all_but_last@163.com; helo=m12-17.163.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 00:17:42 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249066 Archived-At: This thread(https://lists.gnu.org/archive/html/emacs-devel/2020-05/msg00674.html) reminds me about some issues on slot accessing in EIEIO. Recently, I'm reading the source of closql(https://github.com/emacscollective/closql), A Emacs sqlite database ORM package. It use eieio object, and put a piece of advice on eieio-oref to intercept the reading slot action. I don't think use an advice is the silver bullet. If different package put different advice on the same function. The order of calling will make user puzzled. There's slot-value-using-class for CLOS to handle slot accessing, but there's nothing for EIEIO to do this. Another question is, user may access the slot without the respect of eieio-oref via another public interface, the eieio pattern in pcase. eieio pattern directly access the slot index table to avoid useless type check. But another macro with-slot, have to check for each binding because it use eieio-oref. So I suggest to change the structure of eieio-oref. we can separate checking and accessing into two different function. For macros bind multiple slots, checking should be done once before accessing. And it's possible to introduce slot-value-using-class generic in accessing function. -- Zihao