From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages Date: Mon, 11 May 2020 23:36:32 +0100 Message-ID: <87a72ef6a7.fsf@gmail.com> References: <20200511214134.32634.30981@vcs0.savannah.gnu.org> <20200511214135.F14AF20A23@vcs0.savannah.gnu.org> <54168518-e95e-4eaa-0227-b51466d86cb2@yandex.ru> <87ftc6f7ex.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120014"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 12 00:37:14 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYH2v-000V6b-7b for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 00:37:13 +0200 Original-Received: from localhost ([::1]:50130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYH2u-0004fg-AL for ged-emacs-devel@m.gmane-mx.org; Mon, 11 May 2020 18:37:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYH2L-0004Fe-8v for emacs-devel@gnu.org; Mon, 11 May 2020 18:36:37 -0400 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:42118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYH2K-0005P7-72 for emacs-devel@gnu.org; Mon, 11 May 2020 18:36:36 -0400 Original-Received: by mail-wr1-x42f.google.com with SMTP id s8so12986813wrt.9 for ; Mon, 11 May 2020 15:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=BllxVaQMb+6zKkcPgcuhbJ5TWc9Sr7KIzZjIWM2OG8g=; b=V1BnVxas8sapcLVaP84TARkrwoBvqGzYMxXsL/akrxxVWWUNx4rqLluH1zs5+BPvSQ cxv+AP0xD7OGKRpV6JQXnlY6wQpM638ItCLcgPY3UdMdX+YyvTxqWDXRmHbMr4I10WOr nCwGVT2AJAUq5bIPsw5IZvyNxNyIHF06qxy2EmOx2A+tOxAHu/t/YtxLb0FbUy7mCH9N 0DlRdtbfhzrRHT/WVLdaGOzcBtjihk2LlPFvRF/XYmx2IwYRyogAEUfV2v9fdRvRimXh tCbZd8KjxHevpF89zuP+hU1hoP+bQvi41e5AoIO7g1h1VXRjWvx07lzxYOCAkxwr02bj HNuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=BllxVaQMb+6zKkcPgcuhbJ5TWc9Sr7KIzZjIWM2OG8g=; b=ipHeOFntRXzTLhoKEWJALCPBMmp3wC7vIANiUtX7qfw90pDtigS59AtyR8gz2skwIV NRaEFZFTB3GDBT6EaevC6YSlr+seowTfgrJgG2NThu7/4MN9XkPY8vfyQtePqX+edy5A RE9EgO7imViY4CRocot3kPNmW4U834p75xny2z56T9A3T/UsYdU/KadRc8GTMvtK7SCE pXdRE+aLn10ZQ9/Db9h6qkHAxCdG8zcIr/JlSzZEn/VouQ8kdDqI57CaWMfZhSKnE8ke SqYpS1Y8iMPREKPrCUFOufZP0lXB/lCeS333vmbUAsHx3ORJVuBP8b+3iKpbYB4yP+fe D6tA== X-Gm-Message-State: AGi0PuZW+RhQ+ShcQzVbRnaUi9HENk33PdIdPfjTgNHcyk6WQQlTArln /w+rBfm4Uh8YB5pr7jre8V3seWUhoyo= X-Google-Smtp-Source: APiQypJVGCxv6WvUFgCRLIvxIk67Rq08khCqDcHniZ8KFOVOnBE2/CiFctGfAAtGzz3VpzXcSbPF2w== X-Received: by 2002:a5d:6ca7:: with SMTP id a7mr21377727wra.391.1589236594225; Mon, 11 May 2020 15:36:34 -0700 (PDT) Original-Received: from krug ([89.180.145.206]) by smtp.gmail.com with ESMTPSA id 81sm11833727wme.16.2020.05.11.15.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 15:36:33 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Tue, 12 May 2020 01:21:43 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x42f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249900 Archived-At: Dmitry Gutov writes: > On 12.05.2020 01:12, Jo=C3=A3o T=C3=A1vora wrote: >> Dmitry Gutov writes: >>=20 >>> On 12.05.2020 00:41, Jo=EF=BF=BDo T=EF=BF=BDvora wrote: >>>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el >>>> index f5f4092..6be1500 100644 >>>> --- a/lisp/progmodes/project.el >>>> +++ b/lisp/progmodes/project.el >>>> @@ -1,6 +1,11 @@ >>>> ;;; project.el --- Operations on the current project -*- lexical-b= inding: t; -*- >>>> ;; Copyright (C) 2015-2020 Free Software Foundation, Inc. >>>> +;; Version: 1.0.0 >>> >>> Please make this one "0.1". >> No problem, I guess, but sure you don't want "Semantic Versioning" >> stuff? > > I think we should indicate its current pre-release status somehow. Sounds fair. >> Also, why only that one ? Any reason why I shouldn't _also_ use >> 0.1 for eldoc.el and xref.el? OK >> Regardless, I have two serious-ish problems here: >> 1. xref and project.el have a cyclic dependency. xref.el depends >> (properly) on project.el but it seems project.el also depends on >> xref.el. >>=20 >> (defun project--files-in-directory (dir ignores &optional files) >> (require 'find-dired) >> (require 'xref) >> (defvar find-name-arg) >>=20 >> How should I fix this? Any ideas? Or should I be creative? No idea either. I think it shouldn't be too bad, since the potential loads happen at runtime. Stefan? >> 2. It'd be nice if both xref.el and project.el were available for Emacs >> 26.3. But project.el in Emacs master depends on fileloop.el, which >> in turn depends on generator.el. OK? Should I make both fileloop.el >> and generator.el :core packages, too? > > fileloop is new, but generator.el has been there since Emacs 25, IIUC. Unfortunately fileloop.el requires a generator.el variable that is not in the generator.el of Emacs 26.3, iter-empty. > fileloop could also be an optional dependency, considering it's only > required by a couple of commands. Works for me! But then the comment up there should read: ;;; project.el --- Operations on the current project -*- lexical-bindin= g: t; -*- ... ;; Package-Requires: ((emacs "26.3")) =20=20=20=20 ;; This is a GNU ELPA :core package. Don't use functionality that is ;; not compatible with the version of Emacs recorded above, or avoid ;; that such functionality is compiled by default in that version. Which would make this a question of an eval-when-compile + some version check. Unfortunately, the two definitions ;;;###autoload (defun project-search (regexp) ;;;###autoload (defun project-query-replace-regexp (from to) Are autoloaded, as you can see. Maybe I can just make the definitions fail. Jo=C3=A3o