From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process Date: Thu, 14 May 2020 13:00:44 +0200 Message-ID: <87a72akcgz.fsf@gmx.de> References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="5306"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philipp Stephani , 41099@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 14 13:01:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZBcO-0001Ew-8C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 May 2020 13:01:36 +0200 Original-Received: from localhost ([::1]:44194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZBcL-0001rc-E7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 May 2020 07:01:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZBbq-0001qB-3V for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 07:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZBbp-00010s-QP for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 07:01:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZBbp-0002qd-Oj for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 07:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 May 2020 11:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41099 X-GNU-PR-Package: emacs Original-Received: via spool by 41099-submit@debbugs.gnu.org id=B41099.158945405510927 (code B ref 41099); Thu, 14 May 2020 11:01:01 +0000 Original-Received: (at 41099) by debbugs.gnu.org; 14 May 2020 11:00:55 +0000 Original-Received: from localhost ([127.0.0.1]:60442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZBbj-0002qB-CS for submit@debbugs.gnu.org; Thu, 14 May 2020 07:00:55 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:52863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZBbg-0002pw-OB for 41099@debbugs.gnu.org; Thu, 14 May 2020 07:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1589454046; bh=0EfmV7RHLoubh0fGpG1qXJUKlVN4i9W5b2KTFXoczug=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IyPuF8g2Iz5WZtcAAvodWeqxXWL8v76+qJRz9lfdnnYR66DEFiEuy554T0pmInmkC l7ewyXLFi+3LU7mquAzN/BTDJNZJuXsjf+MmmFp4SSHG+9DjwBRHjefm0+tXPCxQj/ 9GIiQWoW3Etf1Ew4/m6PnaucdLxdZyEtXqAvIYeE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.119.151]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXGrE-1jatTn3tRm-00YmTN; Thu, 14 May 2020 13:00:46 +0200 In-Reply-To: <87v9kzl2ga.fsf@gmail.com> (Noam Postavsky's message of "Wed, 13 May 2020 21:39:33 -0400") X-Provags-ID: V03:K1:/AUzhbXAfxSrDTZhEDxxRK9qxSPrbHreKTqj+j7+8yDSOhFzmOh vXkApwcWe4jtgNCK6b03P7H6rC2cVsu135cuSd83yIJc3amSI3Kv5ik+M5dh8XD46oAwNq4 LzsgjfrgnbxrfQS/GJWWwrGofmrv1Rh7YTlfM6kIoY0ejOdXYGHwfzTFBMoSUSM49iQupnG eLt958EndDBlQagOq7r/w== X-UI-Out-Filterresults: notjunk:1;V03:K0:0OR4evQW/L8=:roLE5iozWm7R0eAi5pECvf ZjcZgFjbSvOJvJsxrX2RAJBGHTAMYjTDIZMd+xMh/Uf7flZSc8vlRYt+pwlWV+G1QRl324H4z 1NZB5JgMLrs5/NPyBWn1p7OdmN9swxjKREa3kYCbRQBZifq3QRfb5M7RaS6R4MmvB5oSX3vGR TXOd8RK60HICWyaPdVkP8mNEN0c879eVU4IgvsPUsk95htjWKsY1/2vsV1LOJWFlYesmZQV/0 qG0rL0+TyAcB6ciNXeJUQerEEGrwpJRbd0agE7+LVcAhdoigrvk59sbLpt51a3vdq1SdDPm1K onP8Tyo8FUbUmuT/TQTiH+DG/9QM9+kAx71PBZv78Mf1YlVh8fQuzLAWCoMN+s/2ZpDUNJCbX KQ6LTPjUOnMBeLBcHmTzhgcDDUfGszvO+FJ2eDFrWImdo4dT5AR/PDb4Mzyhz72S1rPnxV+1H LRcFmcxBUykKTHRBfr6WRzFWBVXKl6wnRI4G+YOz4gEwGGhvNNBjRZrCmkCUSUjFSrEmkMpyM qgBqMRWsaQ3feZy9UQu9Z9uSmuTEgfSdrS6qcD/Z23R2bmuzuoOxuecE84rMNeGO0fO4xwIXi 9lFXgQ2nT3kKqxGBlg9NN0fDp159hj1Q9Q2R9spGLRgmYcsWZdJ/09j+b3AoEDNcTabSVaA+J 2YRNR3u5sZwTK3No87I9j/UcOuNuACodMiHB507IxpHIxcbEE+p8ZJb4Y/91HianKdhzHIL0t uqtbCFlhHrLMuTlqD1eJGl7Tb1n9dpnEWAUUl6HbpRnzZnCH0WITWZk0SAcRxQojn24XwnuI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180201 Archived-At: Noam Postavsky writes: Hi Noam, >>> (defun tramp-process-file (...) >>> (let ((code (...original code...))) >>> (if (> code 128) >>> ;; Probably a signal >>> (format "Signal %d" (- code 128)) >>> code)) >> >> I've pushed a patch to master along these lines. > > I don't think this is sufficiently reliable. With current master: > > (let ((default-directory "/sudo::/home/npostavs/.emacs.d/")) > (process-file "git" nil nil nil "merge-base")) > ;=3D> "Signal 1" > > (let ((default-directory "/home/npostavs/.emacs.d/")) > (process-file "git" nil nil nil "merge-base")) > ;=3D> 129 I see. A short test shows, that git is using exit code 129 in case of error in invocation, although it isn't documented in the man pages. Hmm, this seems to be a contradiction to the specification of reserved exit codes, as described in = . We cannot change git, so either - we keep Tramp's process-file implementation as it is, - we don't return a string in case a signal has interrupted the process, - we install trap handlers in the remote shell in order to let Tramp detect signals reliably. The last alternative might be the best approach to keep the process-file spec. But it sounds expensive to me, and people already complain about Tramp performance. Do we want to go this way? Best regards, Michael.