From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode' Date: Tue, 26 May 2020 15:38:16 -0500 Message-ID: <87a71ue8jr.fsf@red-bean.com> References: <87lfpu9ag8.fsf@marxist.se> <87367qmm0l.fsf@gmail.com> <323e521b-503b-4ed3-bd42-aa3707de37c1@default> <87sgfmfv6v.fsf@red-bean.com> <1fd3ebe3-e447-43af-8086-32a98febe475@default> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="77089"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Matthias Meulien , Stefan Kangas , 39293@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 26 22:39:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdgM0-000JwA-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 22:39:16 +0200 Original-Received: from localhost ([::1]:35882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdgLz-0001r8-DN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 16:39:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdgLm-0001kN-So for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 16:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdgLm-0003px-Hs for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 16:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdgLm-0004Ro-Ev for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 16:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Karl Fogel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 May 2020 20:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39293-submit@debbugs.gnu.org id=B39293.159052550117049 (code B ref 39293); Tue, 26 May 2020 20:39:02 +0000 Original-Received: (at 39293) by debbugs.gnu.org; 26 May 2020 20:38:21 +0000 Original-Received: from localhost ([127.0.0.1]:46471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdgL7-0004Qu-Br for submit@debbugs.gnu.org; Tue, 26 May 2020 16:38:21 -0400 Original-Received: from newsp.red-bean.com ([45.79.25.59]:40442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdgL5-0004Ql-2B for 39293@debbugs.gnu.org; Tue, 26 May 2020 16:38:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2NjGtQ321wS/TZ+IeHEdxw7adHrO9Mx6nwxhlawWykI=; t=1590525499; x=1591735099; b=PBrKGCZ9fP2Sqol1qRgNniMuWgDijzGnAwiEg7IR+wk6vnGuLGtU+vBTUORnIxd8ZjYNKcKFqP Q9lTWBxttEBObxf3LxyZ95XwSVi+XMqm71mTDGYKz9hb81aDZEdf8lAYdilxtNoiN6ShwTLS4oGCR CwPveayUn2PWYJzuXMmcbUNE6Yt9BGqj36U8cAG9WXRqr1agX0viMbkwjZkYI7xM7MdsDyDp/kPJX BnnLO+rTN3o1mA1hdQwdP+Hrdi3lKgS8zJZ0gokjP3U+7Kzr+pcPZQGs6f7gNfAMhaMIv9v+ummqo oZNbDOn+6kvOQW7AJYQcQ6SWj+LXOLAFnI36Q==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:41136 helo=floss) by newsp.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdgL3-0008Ds-AC; Tue, 26 May 2020 20:38:17 +0000 In-Reply-To: <1fd3ebe3-e447-43af-8086-32a98febe475@default> (Drew Adams's message of "Tue, 26 May 2020 13:02:04 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181073 Archived-At: On 26 May 2020, Drew Adams wrote: >Sorry, I really don't have the time to deal with >this now. > >Bookmark+ has lots of added features, and many >have to do with the bookmark-list display. If >you're interested in that, please see its doc. > >Maybe at some point later I'll have the time and >will to tick off things in Bookmark+ that t-l-mode >interferes with or prohibits. > >I think at this point you'll just have to take my >word for it (or not) that it would be far too much >work, too risky, and for no benefit, for me to try >to rewrite such features to adapt to t-l-mode. Okay, fair enough -- I understand about limited time. >And I'm pretty sure that some things would need to >be sacrificed. In my experience just with `apu.el' >(which uses t-l-mode) I ran into limitations that >I had to work around (no, I don't recall what they >were). > >[Can a t-l-mode buffer even have a title (not just >column headings)? With Bookmark+ the listing >reflects the current sorting and filterings, and >the title at the top tells you what the listing is >about.] > >I'm sorry to say it, but I won't try, for Bookmark+. >I don't have the time to waste on that. Sorry. > >Do what you think you have to do. I'll do what I >have to do, given my limited resources. I expect >I'll likely just incorporate the former bookmark.el >code that Bookmark+ currently takes for granted. Well, I don't think we "have to" convert bookmark.el to use t-l-mode at all. >FWIW, I also don't think that bookmark.el's list >of bookmarks is a great candidate for t-l-mode. >I don't think it adds anything important for such >a simple list with 2-3 columns. As I said in my >Jan 26 mail, sorting by those columns (which is >really all that t-l-mode offers here) is not so >helpful. (OK, it has some use.) > >Maybe consider ibuffer.el instead? As I said >earlier, trying ibuffer, which offers a bit more >than a rudimentary listing, might point to some >t-l-mode limitations or complications. And if >it doesn't then so much the better. ;-) Well, I mean, bookmark.el seems to be working fine the way it is right now, without t-l-mode nor ibuffer. So I'm not sure the proposed change is warranted. Stefan, is there a strong motivation here, other than the obvious attractions of re-using code and avoiding multiple implementations of similar functionality? (If we decide not to make the change, then we should add a comment to bookmark.el pointing to this bug-ticket discussion and explaining *why* we have left the code as-is.) >To be clear, I don't think I said that anything >would be limited or broken in _bookmark.el_ by >using t-l-mode. Potential uses of its features, >and existing uses by 3rd-party libraries (e.g. >Bookmark+), could be limited or broken. But I >doubt that anything bookmark.el offers out of >the box would be affected much, if at all. >(bookmark.el could probably drop a good deal of >its code without breaking anything that people >use much). Agreed; that's what I understood you to be saying. Best regards, -Karl