From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Date: Fri, 19 Jun 2020 01:59:48 +0300 Organization: LINKOV.NET Message-ID: <87a710m13v.fsf@mail.linkov.net> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> <87eeqefvba.fsf@mail.linkov.net> <12ad74c6-c5b4-f911-ce29-8f2c1205bf8c@yandex.ru> <87tuz9crt6.fsf@mail.linkov.net> <34f4f136-91c9-e2cd-ddbf-7698fdd9ee10@yandex.ru> <87r1ud9vkg.fsf@mail.linkov.net> <4b27ed2d-09f4-86a4-36ed-92034a786668@yandex.ru> <87mu518eg9.fsf@mail.linkov.net> <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="34699"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org, Theodor Thornhill To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 19 01:05:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jm3b6-0008uQ-3x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Jun 2020 01:05:28 +0200 Original-Received: from localhost ([::1]:60660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jm3b5-0003fb-5f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jun 2020 19:05:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm3ah-0003R6-46 for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 19:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jm3ag-0005W2-RX for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 19:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jm3ag-0005x3-Ms for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 19:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jun 2020 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41890-submit@debbugs.gnu.org id=B41890.159252146022796 (code B ref 41890); Thu, 18 Jun 2020 23:05:02 +0000 Original-Received: (at 41890) by debbugs.gnu.org; 18 Jun 2020 23:04:20 +0000 Original-Received: from localhost ([127.0.0.1]:54641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3a0-0005vc-3B for submit@debbugs.gnu.org; Thu, 18 Jun 2020 19:04:20 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jm3Zx-0005vL-LS for 41890@debbugs.gnu.org; Thu, 18 Jun 2020 19:04:18 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 8C890E0005; Thu, 18 Jun 2020 23:04:09 +0000 (UTC) In-Reply-To: <43b6e723-ccd3-83e2-b11c-bbc463022079@yandex.ru> (Dmitry Gutov's message of "Thu, 18 Jun 2020 02:36:49 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182155 Archived-At: >> BTW, shouldn't 'C-x p v' be bound to the whole vc prefix map? >> So 'C-x p v d' will run vc-dir in the project root dir, >> 'C-x p v =' - vc-root-diff in the project root dir, >> 'C-x p v v' - project's vc-next-action, etc. > > That might be over-engineering it a bit. > > Considering that in the vast majority of cases the VC root and the project > root are going to be the same. > > So the users will get the same results from 'C-x p v =' as from 'C-x v D', > and 'C-x p v d' would usually be the same as 'C-x v d' (but having one > binding for the cases when it's different is fine, I guess). > > How would 'C-x p v v' differ from 'C-x v v'? Actually my question would be better formulated like this: Should we reserve the key 'C-x p v' as a prefix map for possible future extensions when such need to add more vc keys will arise? Currently I see no such need, but who knows.