From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user option to disable location in bookmarks Date: Sun, 21 Jun 2020 10:56:44 +0100 Message-ID: <87a70wkahv.fsf@tcd.ie> References: <87sgep35cb.fsf@gmail.com> <87blld2x5h.fsf@gmail.com> <062414c6-41f4-4803-9a62-28274825b8e0@default> <87r1u9mfo0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="23413"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jamie Beardslee Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 21 11:57:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmwj8-0005y7-5f for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 11:57:26 +0200 Original-Received: from localhost ([::1]:37094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmwj7-0007Na-7g for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 05:57:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmwib-0006kP-0w for emacs-devel@gnu.org; Sun, 21 Jun 2020 05:56:53 -0400 Original-Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:45422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmwiY-0004uh-Ve for emacs-devel@gnu.org; Sun, 21 Jun 2020 05:56:52 -0400 Original-Received: by mail-wr1-x444.google.com with SMTP id c3so13727681wru.12 for ; Sun, 21 Jun 2020 02:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zlVns75QI9WHQZWKXgtSKalnJ0wbCszDWqmLM/s11XY=; b=N2WH26iqDmHB6j0Zc89feFvhrb1PmOgNDSvpf/u3T2sQpPc3mAZH0s28MDzyydZzlZ T2tXT5hWMPggH6TXv/l7J5ZCuovvYv7SUoYmLB1mKGDD3m7PxkRGfndazBDOqg8OyAmS /lqJqPpe21cekPXDNCnv5V/85IQbkjjz59YmKbpldSyOI7Yc0MV0sexVG5XwOKI7sfoa 0gTVcw23ETxlQ4ad+NvesWKR2RD0vQSCuovPyb3a2YimcMtDhglWb+I/PYH0GQfMQ4Yg VL3ydjRFf63i/nVYWCd8tLdmGErwD/j9AJ2vBYGqQsktyShQ3gb9QX1pAFKP4NkINrFm NdPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zlVns75QI9WHQZWKXgtSKalnJ0wbCszDWqmLM/s11XY=; b=rEHCcvMeySx5QuYjczzYPH4kLC5gaJjwfzx6l8j2+ycgmQ0wQk9WJrJB5cKo8yL782 MgBsEKbh9VO4jcyZocfPFTGRyqW1hjcakKm+QVuz6zSRm7xY+4psqzwsXVKTg3uDXQSg r64CvkajgAlU8BjVqv93KCLPBYjh5NmzYA63HvTILmt9b+7646ohFEKLeitE+Fd7Bfhz SQwZMeFCEO2rwDmKN6FIsN85Yip5rLSeyM7pzbmGplWSNjL9VrT6gmsxYC4+JTXE7aJo H6GwWiHqLKhAydSjQCdtMKWE3sCgpUzMe4pCqufwpTzbDkztQ1JULiP4kaFJwqi2lXqg pgZg== X-Gm-Message-State: AOAM532QHZsycaStvSSYQ/QTb+1K3GdHGSLr2PlL+XzIkADd3fIHrdMm CWLoG9OAB4bfpeB5GyURsVMNEw== X-Google-Smtp-Source: ABdhPJzyEGBY83OtX57KcSaAV2booAgmTMewkRPgJUGGRoG7HNgiBf6B0OlPFM4YCGYHT4PLGNDG0A== X-Received: by 2002:a5d:508e:: with SMTP id a14mr12667085wrt.335.1592733407093; Sun, 21 Jun 2020 02:56:47 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id n65sm11319370wmf.47.2020.06.21.02.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 02:56:46 -0700 (PDT) In-Reply-To: <87r1u9mfo0.fsf@gmail.com> (Jamie Beardslee's message of "Sun, 21 Jun 2020 12:22:07 +1200") Received-SPF: none client-ip=2a00:1450:4864:20::444; envelope-from=contovob@tcd.ie; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252489 Archived-At: Jamie Beardslee writes: > (defun save-place--setup-hooks (add) > (cond > (add > (add-hook 'find-file-hook #'save-place-find-file-hook t) > + (eval-after-load "bookmark" > + '(add-hook 'bookmark-after-jump-hook #'save-place-bookmark-hook t)) with-eval-after-load is preferred to eval-after-load, but is it necessary? add-hook knows how to deal with as of yet undefined hook variables. > (add-hook 'dired-initial-position-hook #'save-place-dired-hook) > (unless noninteractive > (add-hook 'kill-emacs-hook #'save-place-kill-emacs-hook)) > @@ -334,6 +344,10 @@ save-place-find-file-hook > ;; and make sure it will be saved again for later > (setq save-place-mode t))))) -- Basil